From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] doc: clarification for hashing git checkouts Date: Sun, 10 Jul 2016 19:16:30 -0400 Message-ID: <20160710231630.GA10509@jasmine> References: <20160710215438.15418.98984@what> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMO7K-0003jm-UW for guix-devel@gnu.org; Sun, 10 Jul 2016 19:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMO7G-0002sU-OX for guix-devel@gnu.org; Sun, 10 Jul 2016 19:26:29 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMO7E-0002s9-F1 for guix-devel@gnu.org; Sun, 10 Jul 2016 19:26:26 -0400 Content-Disposition: inline In-Reply-To: <20160710215438.15418.98984@what> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Troy Sankey Cc: guix-devel On Sun, Jul 10, 2016 at 05:54:38PM -0400, Troy Sankey wrote: > When hashing git checkouts of packages, packagers must first remove the .git > directory. This commit adds this clarification to the "Invoking guix hash" > page in the documentation. Yes! This is one that *everybody* has to ask. I think it would be better in section '5.1.2 origin reference', because that is where the origin methods (url-fetch, git-fetch, etc) and the sha256 field are documented. In that case, it could go along with explanations of how to calculate the hash for cvs-download, hg-download, and svn-download. What do others think?