unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Matthew Jordan <matthewjordandevops@yandex.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [Patch] Tmux Themepack
Date: Sun, 10 Jul 2016 12:19:57 -0400	[thread overview]
Message-ID: <20160710161957.GB20980@jasmine> (raw)
In-Reply-To: <87poqlzkrp.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

On Sun, Jul 10, 2016 at 09:26:50AM -0400, Matthew Jordan wrote:
> Hi I tried applying to patch and git gave me an error asking if I hand
> edited the patch file.

Huh!

> So I added the changes to the attached patch. Let me know if I covered everything.

Thanks! I found myself wondering about some of the new module imports,
in particular (guix build utils), (guix utils), and (gnu packages base).

The latter two are not needed; tmux.scm compiles and tmux and
tmux-themepack can both be built without them.

I think that (guix build utils) should be required to provide
copy-recursively, but everything still works even when I remove the
module. Does anyone know why that is? Is it coming from (guix packages)?

Can you test this and let me know if it works for you? Then we can
finally add tmux-themepack :)

[-- Attachment #2: 0001-gnu-Add-Tmux-Themepack.patch --]
[-- Type: text/x-diff, Size: 3036 bytes --]

From fd78cb1d8c30bb8825cc6330667d3aa886b51777 Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Wed, 18 May 2016 18:20:30 -0400
Subject: [PATCH] gnu: Add Tmux Themepack.

* gnu/packages/tmux.scm (tmux-themepack): New variable.

Signed-off-by: Leo Famulari <leo@famulari.name>
---
 gnu/packages/tmux.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index d89fc16..9174d96 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013 Cyril Roelandt <tipecaml@gmail.com>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,11 +22,13 @@
   #:use-module (guix licenses)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages ncurses))
 
+
 (define-public tmux
   (package
     (name "tmux")
@@ -50,3 +53,38 @@ windows), each running a separate program, to be created, accessed, and
 controlled from a single screen.  tmux may be detached from a screen and
 continue running in the background, then later reattached.")
     (license isc)))
+
+(define-public tmux-themepack
+  (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48")
+        (revision "1"))
+    (package
+      (name "tmux-themepack")
+      (version
+       (string-append "0.0.0-" revision "." (string-take commit 7))) ;; No version tags
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url
+                       (string-append "https://github.com/jimeh/" name ".git"))
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1d3k87mq5lca042jbap5kxskjy3kg79wjhhpnm6jacbn3anc67zl"))
+                (file-name (string-append name "-" version "-checkout"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f ; No test suite
+         #:phases (modify-phases %standard-phases
+                    (delete 'configure)
+                    (delete 'build)
+                    (replace 'install
+                      (lambda* (#:key outputs #:allow-other-keys)
+                        (let* ((out (string-append
+                                     (assoc-ref outputs "out")
+                                     "/share/" ,name "-" ,version)))
+                          (copy-recursively "." out)))))))
+      (home-page "https://github.com/jimeh/tmux-themepack")
+      (synopsis "Collection of themes for Tmux")
+      (description "A collection of various themes for Tmux.")
+      (license
+       (non-copyleft "http://www.wtfpl.net/txt/copying/")))))
-- 
2.9.0


  reply	other threads:[~2016-07-10 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 17:23 [Patch] Tmux Themepack Matthew Jordan
2016-06-11  7:45 ` Ricardo Wurmus
2016-06-12 20:01   ` Matthew Jordan
2016-06-18  0:00     ` Leo Famulari
2016-07-10 13:26       ` Matthew Jordan
2016-07-10 16:19         ` Leo Famulari [this message]
2016-07-10 17:56           ` Matthew Jordan
2016-07-11  8:41           ` Alex Kost
2016-07-10 14:06       ` guix revisions (Re: [Patch] Tmux Themepack) ng0
2016-07-10 15:45         ` Leo Famulari
2016-07-10 16:16           ` guix revisions ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160710161957.GB20980@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=matthewjordandevops@yandex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).