From: Efraim Flashner <efraim@flashner.co.il>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv.
Date: Sun, 10 Jul 2016 07:13:22 +0300 [thread overview]
Message-ID: <20160710041322.GB17662@debian-netbook> (raw)
In-Reply-To: <1467902388.677813.659579777.62341118@webmail.messagingengine.com>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Thu, Jul 07, 2016 at 09:39:48AM -0500, Alex Griffin wrote:
> On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote:
> > > + (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
> > > + version "/gnome-mpv-" version ".tar.xz"))
> >
> > This line looks a bit long to me. Have you checked with “guix lint
> > gnome-mpv”?
>
> Actually, yes I did, and it didn't catch it. Maybe there's a bug in the
> linter?
>
> Anyway, here's an updated patch. In addition to correcting the long
> line, I also tweaked the synopsis and description to make clear that
> this is a media player, for the benefit of anyone who hasn't heard of
> mpv.
> --
> Alex Griffin
packaged pushed!
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-10 4:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 0:04 [PATCH 2/2] gnu: Add gnome-mpv Alex Griffin
2016-07-07 7:10 ` Ricardo Wurmus
2016-07-07 14:39 ` Alex Griffin
2016-07-07 17:07 ` Eric Bavier
2016-07-07 17:17 ` Efraim Flashner
2016-07-10 4:13 ` Efraim Flashner [this message]
2016-07-12 15:34 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160710041322.GB17662@debian-netbook \
--to=efraim@flashner.co.il \
--cc=a@ajgrf.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).