From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add reptyr. Date: Sat, 9 Jul 2016 14:20:35 -0400 Message-ID: <20160709182035.GB2010@jasmine> References: <1468006716.1010694.660917729.687C408B@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLwrz-0000IN-EE for guix-devel@gnu.org; Sat, 09 Jul 2016 14:20:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLwrt-0005Ri-BR for guix-devel@gnu.org; Sat, 09 Jul 2016 14:20:50 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLwrs-0005RX-46 for guix-devel@gnu.org; Sat, 09 Jul 2016 14:20:45 -0400 Content-Disposition: inline In-Reply-To: <1468006716.1010694.660917729.687C408B@webmail.messagingengine.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Griffin Cc: guix-devel@gnu.org On Fri, Jul 08, 2016 at 02:38:36PM -0500, Alex Griffin wrote: > This patch adds reptyr, a tool for reparenting a running program to a > new terminal. I put it in screen.scm because it is usually used to move > a process into a screen or tmux session. Thank you, I will use this :) > Also somewhat related, I think the file tmux.scm should merge with > screen.scm. If we are considering moving these packages around, I think that screen.scm and tmux.scm should go into terminals.scm. But, I also think that this patch should not be held up by that discussion. > + (arguments > + '(#:tests? #f Why skip the tests? We prefer to run tests whenever possible. Otherwise, please add a comment explaining why. For example "No test suite." > + #:phases (alist-delete 'configure %standard-phases))) This is short and sweet, but we like to use modify-phases for consistency. > + (description > + "reptyr is a utility for taking an existing running program and attaching > +it to a new terminal. Started a long-running process over ssh, but have to > +leave and don't want to interrupt it? Just start a screen, use reptyr to grab > +it, and then kill the ssh session and head on home.") We should capitalize the beginning of the description, and I would also wrap 'ssh' and 'screen' in texinfo: @code{ssh} @code{screen}