From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv. Date: Thu, 7 Jul 2016 20:17:17 +0300 Message-ID: <20160707171717.GA12312@debian-netbook> References: <1467849895.1613559.659003001.5BC78E49@webmail.messagingengine.com> <87k2gxzzxt.fsf@mdc-berlin.de> <1467902388.677813.659579777.62341118@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCvd-0006JL-Ly for guix-devel@gnu.org; Thu, 07 Jul 2016 13:17:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLCvY-0002uo-GU for guix-devel@gnu.org; Thu, 07 Jul 2016 13:17:32 -0400 Received: from flashner.co.il ([178.62.234.194]:52510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCvY-0002sk-9L for guix-devel@gnu.org; Thu, 07 Jul 2016 13:17:28 -0400 Content-Disposition: inline In-Reply-To: <1467902388.677813.659579777.62341118@webmail.messagingengine.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Griffin Cc: guix-devel@gnu.org --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 07, 2016 at 09:39:48AM -0500, Alex Griffin wrote: > On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote: > > > + (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/r= eleases/download/v" > > > + version "/gnome-mpv-" version ".tar.xz")) > >=20 > > This line looks a bit long to me. Have you checked with =E2=80=9Cguix = lint > > gnome-mpv=E2=80=9D? >=20 > Actually, yes I did, and it didn't catch it. Maybe there's a bug in the > linter? The linkter checks that there aren't any lines over 90 characters, to allow for incredibly long urls and super-indented code. >=20 > Anyway, here's an updated patch. In addition to correcting the long > line, I also tweaked the synopsis and description to make clear that > this is a media player, for the benefit of anyone who hasn't heard of > mpv. > --=20 > Alex Griffin --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXfo6cAAoJEPTB05F+rO6T1sIQAJsH0rDy/zUdkqlhbSIZhFb5 vp97z6ZDubs+5Rb9r6v3FU/EhXeCxzDjZf+C6bh2ZLxh98SAUf92ZXwUeFiL5uIg OlDLPYIApO4UQ1kMMZH8SRpUlemmaR1FG9wAZGozXY+8uXOhgJJeTf++mWQbCmvq FWR0eXPax9T6aDYd+eU6W4ukoYvkLHjNCDSjgDj/vz+75DRVNexONYZqaSc0+45D heLa97vn1ec119UAYod6Z2IxBC2yEN4g04Bcq6NsfAm6RqOcbzfyqXOWSO/RECC0 CR16ImKVo81w1RxIHexKDseMI217CYd62IHT0nUX2zkkcavegBozfJRNss/6t9dl RFJKeU1KQdLkxq57FKzmv6+iNk026loOifa3F9//8QM4DQG6FXg59bw9+iVAnxzG srjMydCICsT9Ma/1ep0ZzdahYizWqYKWSQnAdvfczLiWfojV3fybQvcgVJ2a/ZsV 9aa91d/QwRGo3fkHqOkHIOwgH1bgJdO3rPWeBEmur8wt1gzYo/Svgncb/+2wDxSd ODle7r7EJv7anL1ZOAGNEp5146HQnqoFOKFweUb/F9ZufQuxh3oVkwsSC/yZk2pP mwRGo93ULDFvVtPEmGpIChrc3E1ZDHO71jJveD6gR7nWTr4Zypq5lBmQBOhlunk1 iwmBx+spnQPeiOY8JKjk =qhfG -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--