[PATCH] ggplot2: fix ggsave('a.svg').

[PATCH] ggplot2: fix ggsave('a.svg').

[Ben Woodcroft]

Hi all,

Beforehand, trying to save an SVG file from a plot generated with ggplot did
not work.  'r-svglite' is only a listed as a suggested dependency for gpglot2,
but given that saving SVGs is reasonably central (at least for me), then I
think we should propagate it.

Test code:
$ R
> library(ggplot2)
> qplot(x=c(1,2,3),y=c(3,4,6))
> ggsave('/tmp/a.svg')
Saving 6.99 x 7 in image

Thanks,
ben

[PATCH 1/3] gnu: Add r-gdtools.

[Ben Woodcroft]

* gnu/packages/statistics.scm (r-gdtools): New variable.
---
 gnu/packages/statistics.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 73c30ae..24fbabe 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -610,6 +610,30 @@ multidimensional conditioning system and a consistent interface to map data to
 aesthetic attributes.")
     (license license:gpl2+)))
 
+(define-public r-gdtools
+  (package
+    (name "r-gdtools")
+    (version "0.0.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "gdtools" version))
+       (sha256
+        (base32
+         "1bmnf9d677f2jy8jnb9ymjz1qzm4yrd0qp6k5qrrly06jfffyx7g"))))
+    (build-system r-build-system)
+    (native-inputs
+     `(("r-rcpp" ,r-rcpp)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("cairo" ,cairo)))
+    (home-page "http://cran.r-project.org/web/packages/gdtools")
+    (synopsis "Utilities for graphical rendering")
+    (description
+     "The @code{gdtools} package provides functionalities to get font metrics
+and to generate base64 encoded string from raster matrix.")
+    (license license:gpl3)))
+
 (define-public r-assertthat
   (package
     (name "r-assertthat")
-- 
2.9.0

Re: [PATCH 1/3] gnu: Add r-gdtools.

[Ricardo Wurmus]

Ben Woodcroft <donttrustben@gmail.com> writes:

> * gnu/packages/statistics.scm (r-gdtools): New variable.
> ---
>  gnu/packages/statistics.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 73c30ae..24fbabe 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -610,6 +610,30 @@ multidimensional conditioning system and a consistent interface to map data to
>  aesthetic attributes.")
>      (license license:gpl2+)))
>  
> +(define-public r-gdtools
> +  (package
> +    (name "r-gdtools")
> +    (version "0.0.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "gdtools" version))
> +       (sha256
> +        (base32
> +         "1bmnf9d677f2jy8jnb9ymjz1qzm4yrd0qp6k5qrrly06jfffyx7g"))))
> +    (build-system r-build-system)
> +    (native-inputs
> +     `(("r-rcpp" ,r-rcpp)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("cairo" ,cairo)))
> +    (home-page "http://cran.r-project.org/web/packages/gdtools")
> +    (synopsis "Utilities for graphical rendering")
> +    (description
> +     "The @code{gdtools} package provides functionalities to get font metrics
> +and to generate base64 encoded string from raster matrix.")
> +    (license license:gpl3)))
> +

Looks like this is indeed “GPLv3 only”.  The README states “The gdtools
package is licensed under the GPLv3.”

Without that notice it would have been GPLv3 or later, because that’s
how the license field in DESCRIPTION files is usually interpreted.

This patch looks good to me.  Thanks!

~~ Ricardo

[PATCH 2/3] gnu: Add r-svglite.

[Ben Woodcroft]

* gnu/packages/statistics.scm (r-svglite): New variable.
---
 gnu/packages/statistics.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 24fbabe..6f27aa6 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -634,6 +634,31 @@ aesthetic attributes.")
 and to generate base64 encoded string from raster matrix.")
     (license license:gpl3)))
 
+(define-public r-svglite
+  (package
+    (name "r-svglite")
+    (version "1.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "svglite" version))
+       (sha256
+        (base32
+         "11ryicjglfi6jvkk4jgg5kra42qbs5z2zid7jjhlslpjcljfwc70"))))
+    (build-system r-build-system)
+    (native-inputs  `(("r-rcpp" ,r-rcpp)))
+    (propagated-inputs
+     `(("r-bh" ,r-bh)
+       ("r-gdtools" ,r-gdtools)))
+    (home-page "https://github.com/hadley/svglite")
+    (synopsis "An 'SVG' Graphics Device")
+    (description
+     "@code{svglite} is a graphics device that produces clean SVG (Scalable
+Vector Graphics) output, suitable for use on the web, or hand editing.
+Compared to the built-in @code{svg()}, @code{svglite} is considerably faster,
+produces smaller files, and leaves text as is.")
+    (license license:gpl2+)))
+
 (define-public r-assertthat
   (package
     (name "r-assertthat")
-- 
2.9.0

Re: [PATCH 2/3] gnu: Add r-svglite.

[Ricardo Wurmus]

Ben Woodcroft <donttrustben@gmail.com> writes:

> * gnu/packages/statistics.scm (r-svglite): New variable.
> ---
>  gnu/packages/statistics.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 24fbabe..6f27aa6 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -634,6 +634,31 @@ aesthetic attributes.")
>  and to generate base64 encoded string from raster matrix.")
>      (license license:gpl3)))
>  
> +(define-public r-svglite
> +  (package
> +    (name "r-svglite")
> +    (version "1.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "svglite" version))
> +       (sha256
> +        (base32
> +         "11ryicjglfi6jvkk4jgg5kra42qbs5z2zid7jjhlslpjcljfwc70"))))
> +    (build-system r-build-system)
> +    (native-inputs  `(("r-rcpp" ,r-rcpp)))
> +    (propagated-inputs
> +     `(("r-bh" ,r-bh)
> +       ("r-gdtools" ,r-gdtools)))
> +    (home-page "https://github.com/hadley/svglite")
> +    (synopsis "An 'SVG' Graphics Device")

How about just “SVG graphics device”?

> +    (description
> +     "@code{svglite} is a graphics device that produces clean SVG (Scalable
> +Vector Graphics) output, suitable for use on the web, or hand
> editing.

How about

    @dfn{SVG} (Scalable Vector Graphics)

?

> +Compared to the built-in @code{svg()}, @code{svglite} is considerably faster,
> +produces smaller files, and leaves text as is.")
> +    (license license:gpl2+)))
> +

The rest looks fine.

~~ Ricardo

Re: [PATCH 2/3] gnu: Add r-svglite.

[Ben Woodcroft]

On 06/07/16 13:30, Ricardo Wurmus wrote:
> Ben Woodcroft <donttrustben@gmail.com> writes:
>
[..]
>> ---
>> +    (synopsis "An 'SVG' Graphics Device")
> How about just “SVG graphics device”?
>
>> +    (description
>> +     "@code{svglite} is a graphics device that produces clean SVG (Scalable
>> +Vector Graphics) output, suitable for use on the web, or hand
>> editing.
> How about
>
>      @dfn{SVG} (Scalable Vector Graphics)
>
> ?

Thanks for the review. I pushed this set with both these changes.

ben

[PATCH 3/3] gnu: r-ggplot2: Add r-svglite to propagated-inputs.

[Ben Woodcroft]

* gnu/packages/statistics.scm (r-ggplot2)[propagated-inputs]: Add
r-svglite.
---
 gnu/packages/statistics.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 6f27aa6..b4e810a 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -598,7 +598,8 @@ legends.")
        ("r-plyr" ,r-plyr)
        ("r-proto" ,r-proto)
        ("r-reshape2" ,r-reshape2)
-       ("r-scales" ,r-scales)))
+       ("r-scales" ,r-scales)
+       ("r-svglite" ,r-svglite)))
     (home-page "http://ggplot2.org")
     (synopsis "An implementation of the grammar of graphics")
     (description
-- 
2.9.0

Re: [PATCH 3/3] gnu: r-ggplot2: Add r-svglite to propagated-inputs.

[Ricardo Wurmus]

Ben Woodcroft <donttrustben@gmail.com> writes:

> * gnu/packages/statistics.scm (r-ggplot2)[propagated-inputs]: Add
> r-svglite.
> ---
>  gnu/packages/statistics.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 6f27aa6..b4e810a 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -598,7 +598,8 @@ legends.")
>         ("r-plyr" ,r-plyr)
>         ("r-proto" ,r-proto)
>         ("r-reshape2" ,r-reshape2)
> -       ("r-scales" ,r-scales)))
> +       ("r-scales" ,r-scales)
> +       ("r-svglite" ,r-svglite)))
>      (home-page "http://ggplot2.org")
>      (synopsis "An implementation of the grammar of graphics")
>      (description

Looks good to me.  Thank you!

~~ Ricardo