From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add di.
Date: Mon, 4 Jul 2016 15:07:33 -0400
Message-ID: <20160704190733.GC8480@jasmine>
References: <87poqvam4v.fsf@hecubus.retroj.net>
	<20160703210212.GA22355@jasmine>
	<87eg7a9y7e.fsf@hecubus.retroj.net>
	<87y45i83pi.fsf@hecubus.retroj.net> <87eg79kims.fsf@gmail.com>
	<87k2h18m91.fsf@hecubus.retroj.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bK9Dg-0004J6-Vf
	for guix-devel@gnu.org; Mon, 04 Jul 2016 15:07:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bK9Dc-0001cV-OL
	for guix-devel@gnu.org; Mon, 04 Jul 2016 15:07:47 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:55189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bK9Db-0001bh-Hd
	for guix-devel@gnu.org; Mon, 04 Jul 2016 15:07:44 -0400
Content-Disposition: inline
In-Reply-To: <87k2h18m91.fsf@hecubus.retroj.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John J Foerch <jjfoerch@earthlink.net>
Cc: guix-devel@gnu.org

On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote:
> * gnu/packages/admin.scm (di): New variable.

A few final nitpicks before others make a decision about the test suite
;)

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)

We prefer to use #:tests? #f instead of deleting the check phase.

> +         (add-before 'build 'setup-environment
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (setenv "CC" "gcc")
> +             (setenv "prefix" (assoc-ref outputs "out"))
> +             #t)))
> +       #:make-flags (list "-e")))

I would like for '-e' to be expanded to '--environment-overrides'. It
seems that Schemers abhor abbreviations.

Sorry for not mentioning these before. I can do them myself when pushing
if there are no other changes to be made.