From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add alot and python-urwidtrees Date: Fri, 1 Jul 2016 17:50:50 -0400 Message-ID: <20160701215050.GA4187@jasmine> References: <1467396878-sup-4584@what> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ6L9-0007O2-7F for guix-devel@gnu.org; Fri, 01 Jul 2016 17:51:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJ6L3-0007Ye-8R for guix-devel@gnu.org; Fri, 01 Jul 2016 17:51:10 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ6L1-0007XP-Uj for guix-devel@gnu.org; Fri, 01 Jul 2016 17:51:05 -0400 Content-Disposition: inline In-Reply-To: <1467396878-sup-4584@what> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Troy Sankey Cc: guix-devel Thanks for this patch! Can you split it into two patches? We prefer to make one change (such as a package addition) per commit. More comments are below. On Fri, Jul 01, 2016 at 02:16:01PM -0400, Troy Sankey wrote: > --- > gnu/packages/mail.scm | 31 +++++++++++++++++++++++++++++++ > gnu/packages/python.scm | 24 ++++++++++++++++++++++++ Please remember to add your name to the list of authors at the beginning of the files. > +(define-public alot > + (uri (string-append "https://github.com/pazz/alot/archive/" > + version ".tar.gz")) When possible, we prefer to use PyPi for downloading Python source code. But in this case, I don't see version 0.3.7 on PyPi, so we'll use GitHub. > + #:python ,python-2)) If Python 3 is unsupported, can you mention it in a brief comment? > + (synopsis "Commandline MUA using notmuch and urwid") How about "Command-line mail client using @code{notmuch} and @code{urwid}"? I'm not sure if the synopses support texinfo markup, while I know the descriptions do. > + (description > + "Alot is an experimental terminal MUA based on notmuch mail. It is > +written in python using the urwid toolkit.") Can you unpack 'MUA' and wrap notmuch and urwid in texinfo as above? > +(define-public python-urwidtrees > + (arguments > + '(#:tests? #f)) If there are no tests, can you say so in a comment as in 'alot'? > + (native-inputs `(("python-setuptools" ,python-setuptools))) > + (inputs `(("python-urwid" ,python-urwid))) > + (home-page "https://github.com/pazz/urwidtrees") > + (synopsis "Tree widgets for urwid") > + (description "Tree widgets for urwid.") How about adapting the description from the home-page? > + (license gpl3+)))