From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v3] gnu: Add python-prompt-toolkit, python2-prompt-toolkit.
Date: Wed, 29 Jun 2016 22:23:32 -0400 [thread overview]
Message-ID: <20160630022332.GA6667@jasmine> (raw)
In-Reply-To: <20160629113033.5297f1e0@scratchpost.org>
On Wed, Jun 29, 2016 at 11:30:33AM +0200, Danny Milosavljevic wrote:
> On Wed, 29 Jun 2016 09:40:40 +0200
> Danny Milosavljevic <dannym+a@scratchpost.org> wrote:
>
> > +(define-public python2-prompt-toolkit
> > + (let ((base (package-with-python2 (strip-python2-variant python-prompt-toolkit))))
> > + (package
> > + (inherit base)
> > + (native-inputs
> > + `(("python2-setuptools" ,python2-setuptools)
> > + ,@(package-native-inputs base))))))
>
>
> Hmm. Now that I made it a native input instead of propagated input, the python2-wcwidth that is compiled alongside python2-prompt-toolkit doesn't find setuptools anymore. Why?
In python-wcwidth and python-prompt-toolkit, the 'properties' field that
makes the python2-variant system work is missing. I missed that in my
review of python-wcwidth.
I'll push a follow up to that commit, and then push this patch with the
properties field added as well.
next prev parent reply other threads:[~2016-06-30 2:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 13:00 [PATCH] gnu: Add python-prompt-toolkit, python2-prompt-toolkit Danny Milosavljevic
2016-06-25 18:17 ` Leo Famulari
2016-06-28 8:19 ` [PATCH v2] " Danny Milosavljevic
2016-06-29 7:40 ` [PATCH v3] " Danny Milosavljevic
2016-06-29 9:30 ` Danny Milosavljevic
2016-06-30 2:23 ` Leo Famulari [this message]
2016-07-06 8:52 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630022332.GA6667@jasmine \
--to=leo@famulari.name \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).