[PATCH 0/2] Add emacs-emms-player-mpv.

[PATCH 0/2] Add emacs-emms-player-mpv.

[Ricardo Wurmus]

Hi Guix,

I think we need to rename the “emms” package to “emacs-emms”.  (This is what
the first patch does.)  Currently, the emacs-build-system will only add to the
Emacs “load-path” the “site-lisp” directories of packages that start with
“emacs-”.  I think it may be necessary to relax this requirement for cases in
which a non-Emacs package provides an Emacs mode.  In the case of “emms”,
however, I think renaming it is justified.

The second patch adds an EMMS player.  The byte-compilation phase only
succeeds after renaming “emms”, because otherwise it wouldn’t find the lisp
files provides by that package.

Ricardo Wurmus (2):
  gnu: emms: Rename package to "emacs-emms".
  gnu: Add emacs-emms-player-mpv.

 gnu/packages/emacs.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

-- 
2.8.4

[PATCH 1/2] gnu: emms: Rename package to "emacs-emms".

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emms): Rename to "emacs-emms".
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 0c0182d..bdfa027 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -829,7 +829,7 @@ provides an optional IDE-like error list.")
 
 (define-public emms
   (package
-    (name "emms")
+    (name "emacs-emms")
     (version "4.1")
     (source (origin
               (method url-fetch)
-- 
2.8.4

[PATCH 2/2] gnu: Add emacs-emms-player-mpv.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-emms-player-mpv): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index bdfa027..b0f1eb2 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -941,6 +941,29 @@ light user interface.")
     (home-page "http://www.gnu.org/software/emms/")
     (license license:gpl3+)))
 
+(define-public emacs-emms-player-mpv
+  (package
+    (name "emacs-emms-player-mpv")
+    (version "0.0.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/dochang/emms-player-mpv/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "01wj410dpx25b3i8781i2j9c6nlvzvvphy9qgh7zfpmyz6a3wsm4"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emms" ,emms)))
+    (home-page "https://github.com/dochang/emms-player-mpv/")
+    (synopsis "Mpv support for EMMS")
+    (description
+     "This package provides an EMMS player that uses mpv.  It supports pause
+and seeking.")
+    (license license:gpl3+)))
+
 \f
 ;;;
 ;;; Miscellaneous.
-- 
2.8.4

Re: [PATCH 0/2] Add emacs-emms-player-mpv.

[Alex Kost]

Ricardo Wurmus (2016-06-29 08:45 +0300) wrote:

> Hi Guix,
>
> I think we need to rename the “emms” package to “emacs-emms”.  (This is what
> the first patch does.)  Currently, the emacs-build-system will only add to the
> Emacs “load-path” the “site-lisp” directories of packages that start with
> “emacs-”.  I think it may be necessary to relax this requirement for cases in
> which a non-Emacs package provides an Emacs mode.

I agree!  I also think this check for "emacs-" is not needed.

> In the case of “emms”,
> however, I think renaming it is justified.

I agree, but note that there was a discussion about renaming all emacs
packages (geiser, magit, etc.) and making alisases for the old names:
<http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00316.html>

> The second patch adds an EMMS player.  The byte-compilation phase only
> succeeds after renaming “emms”, because otherwise it wouldn’t find the lisp
> files provides by that package.
>
> Ricardo Wurmus (2):
>   gnu: emms: Rename package to "emacs-emms".
>   gnu: Add emacs-emms-player-mpv.

Both patches look good to me, but I would wait for other comments about
renaming as it is not very backward compatible :-)

-- 
Alex

Re: [PATCH 0/2] Add emacs-emms-player-mpv.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Ricardo Wurmus (2016-06-29 08:45 +0300) wrote:
>
>> Hi Guix,
>>
>> I think we need to rename the “emms” package to “emacs-emms”.  (This is what
>> the first patch does.)  Currently, the emacs-build-system will only add to the
>> Emacs “load-path” the “site-lisp” directories of packages that start with
>> “emacs-”.  I think it may be necessary to relax this requirement for cases in
>> which a non-Emacs package provides an Emacs mode.
>
> I agree!  I also think this check for "emacs-" is not needed.
>
>> In the case of “emms”,
>> however, I think renaming it is justified.
>
> I agree, but note that there was a discussion about renaming all emacs
> packages (geiser, magit, etc.) and making alisases for the old names:
> <http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00316.html>

A year later, it still looks like a good idea.  :-)

Damn it, we should do something about it.

>> The second patch adds an EMMS player.  The byte-compilation phase only
>> succeeds after renaming “emms”, because otherwise it wouldn’t find the lisp
>> files provides by that package.
>>
>> Ricardo Wurmus (2):
>>   gnu: emms: Rename package to "emacs-emms".
>>   gnu: Add emacs-emms-player-mpv.
>
> Both patches look good to me, but I would wait for other comments about
> renaming as it is not very backward compatible :-)

A mass rename would cause users a lot of pain, but a single package is
OK, IMO.  (Don’t tell me you want to do a mass rename at a one
rename/week rate!  ;-))

Thoughts?

Ludo’.

Re: [PATCH 0/2] Add emacs-emms-player-mpv.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Ricardo Wurmus (2016-06-29 08:45 +0300) wrote:
>>
>>> Hi Guix,
>>>
>>> I think we need to rename the “emms” package to “emacs-emms”.  (This is what
>>> the first patch does.)  Currently, the emacs-build-system will only add to the
>>> Emacs “load-path” the “site-lisp” directories of packages that start with
>>> “emacs-”.  I think it may be necessary to relax this requirement for cases in
>>> which a non-Emacs package provides an Emacs mode.
>>
>> I agree!  I also think this check for "emacs-" is not needed.
>>
>>> In the case of “emms”,
>>> however, I think renaming it is justified.
>>
>> I agree, but note that there was a discussion about renaming all emacs
>> packages (geiser, magit, etc.) and making alisases for the old names:
>> <http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00316.html>
>
> A year later, it still looks like a good idea.  :-)
>
> Damn it, we should do something about it.

I’ll add it to my list in the hope that I can mark it DONE without
having to implement it myself :)  This is how things often go as far as
Guix is concerned.

>>> The second patch adds an EMMS player.  The byte-compilation phase only
>>> succeeds after renaming “emms”, because otherwise it wouldn’t find the lisp
>>> files provides by that package.
>>>
>>> Ricardo Wurmus (2):
>>>   gnu: emms: Rename package to "emacs-emms".
>>>   gnu: Add emacs-emms-player-mpv.
>>
>> Both patches look good to me, but I would wait for other comments about
>> renaming as it is not very backward compatible :-)
>
> A mass rename would cause users a lot of pain, but a single package is
> OK, IMO.

Do you want me to define an alias for “emms” now in the manner you
suggested in your email from 2015?  Or should this be done once the UI
supports dealing with deprecated packages?

~~ Ricardo

Re: [PATCH 0/2] Add emacs-emms-player-mpv.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> Ricardo Wurmus (2016-06-29 08:45 +0300) wrote:
>>>
>>>> Hi Guix,
>>>>
>>>> I think we need to rename the “emms” package to “emacs-emms”.  (This is what
>>>> the first patch does.)  Currently, the emacs-build-system will only add to the
>>>> Emacs “load-path” the “site-lisp” directories of packages that start with
>>>> “emacs-”.  I think it may be necessary to relax this requirement for cases in
>>>> which a non-Emacs package provides an Emacs mode.
>>>
>>> I agree!  I also think this check for "emacs-" is not needed.
>>>
>>>> In the case of “emms”,
>>>> however, I think renaming it is justified.
>>>
>>> I agree, but note that there was a discussion about renaming all emacs
>>> packages (geiser, magit, etc.) and making alisases for the old names:
>>> <http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00316.html>
>>
>> A year later, it still looks like a good idea.  :-)
>>
>> Damn it, we should do something about it.
>
> I’ll add it to my list in the hope that I can mark it DONE without
> having to implement it myself :)  This is how things often go as far as
> Guix is concerned.

:-)

> Do you want me to define an alias for “emms” now in the manner you
> suggested in your email from 2015?  Or should this be done once the UI
> supports dealing with deprecated packages?

Once the UI is done.  Currently this would have no effect.

Ludo’.

Re: [PATCH 0/2] Add emacs-emms-player-mpv.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

>> Do you want me to define an alias for “emms” now in the manner you
>> suggested in your email from 2015?  Or should this be done once the UI
>> supports dealing with deprecated packages?
>
> Once the UI is done.  Currently this would have no effect.

Okay, pushed to master.  Thank you for the review.

~~ Ricardo