From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add khmer. Date: Mon, 27 Jun 2016 01:01:52 -0400 Message-ID: <20160627050152.GA6344@jasmine> References: <1466126601-30932-1-git-send-email-donttrustben@gmail.com> <20160625172911.GD21038@jasmine> <87wplcmfua.fsf@gnu.org> <576FC3B7.2060306@uq.edu.au> <20160626173442.GA5036@jasmine> <976C514C-6D4F-425F-8849-2C0C6C65C038@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHOgc-0001qU-9Y for Guix-devel@gnu.org; Mon, 27 Jun 2016 01:02:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHOgW-0004ss-Bj for Guix-devel@gnu.org; Mon, 27 Jun 2016 01:02:17 -0400 Content-Disposition: inline In-Reply-To: <976C514C-6D4F-425F-8849-2C0C6C65C038@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: Guix-devel@gnu.org On Mon, Jun 27, 2016 at 08:48:14AM +1000, Ben Woodcroft wrote: > On 27 June 2016 3:34:42 AM AEST, Leo Famulari wrote: > >On Sun, Jun 26, 2016 at 09:59:51PM +1000, Ben Woodcroft wrote: > >> I'm not convinced, I'm afraid. According to the SMHasher README [0]: > >> > >> >This is the home for the MurmurHash > >> family of hash > >> functions along with the SMHasher > >> test suite > >used to > >> verify them. > >> > >> So that would count that as an independent upstream distribution of > >> murmurhash, right? > > > >My understanding is that SMHasher does not create a library, but just > >provides raw source code, leaving it up to 3rd party software authors > >to > >integrate it into their applications. Is that right? > > Yes. I don't see how that matters though, it is still bundling which should be avoided if possible right? What am I missing? So far my understanding has been that, in Guix, we don't want to create Guix-specific distributions of upstream code. SMHasher is the canonical source for Murmur, but SMHasher doesn't seem suitable for building a library that other applications can use, right? Do any other distros have a package for Murmur or SMHasher that we can use as an example? Does anyone else have any thoughts about this?