From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 10/10] gnu: Add python-fake-factory and
	python2-fake-factory.
Date: Sat, 25 Jun 2016 13:58:42 -0400
Message-ID: <20160625175842.GI22624@jasmine>
References: <20160623152004.24065-1-iyzsong@gmail.com>
	<20160623152004.24065-6-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGrr3-0001XJ-9f
	for guix-devel@gnu.org; Sat, 25 Jun 2016 13:58:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGrr1-0002Dg-BZ
	for guix-devel@gnu.org; Sat, 25 Jun 2016 13:58:52 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40788)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGrr1-0002CQ-5C
	for guix-devel@gnu.org; Sat, 25 Jun 2016 13:58:51 -0400
Content-Disposition: inline
In-Reply-To: <20160623152004.24065-6-iyzsong@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

On Thu, Jun 23, 2016 at 11:20:04PM +0800, 宋文武 wrote:
> * gnu/packages/python.scm (python-fake-factory, python2-fake-factory):
> New variables.

> +  (arguments
> +   '(#:phases
> +     (modify-phases %standard-phases
> +       (add-before 'check 'disable-failing-test
> +         ;; XXX: faker/tests/ne_np/__init__.py, line 40, in test_names
> +         ;;      first_name, last_name = name.split()
> +         ;; ValueError: too many values to unpack (expected 2)
> +         (lambda _
> +           (delete-file "faker/tests/ne_np/__init__.py")
> +           #t)))))

It's safe to disable this test?

> +  (native-inputs
> +   `(("python-dateutil" ,python-dateutil-2)
> +     ("python-setuptools" ,python-setuptools)
> +     ("python-six" ,python-six)
> +     ;; For testing
> +     ("python-email-validator" ,python-email-validator)
> +     ("python-mock" ,python-mock)
> +     ("python-ukpostcodeparser" ,python-ukpostcodeparser)))

It doesn't need to use dateutil, email-validator, and ukpostcodeparser
at run-time?

> +  (home-page "http://github.com/joke2k/faker")
> +  (synopsis "Python package that generates fake data")
> +  (description
> +   "Faker is a Python package that generates fake data such as names,
> +addresses, and phone numbers.")
> +  (license license:expat)
> +  (properties `((python2-variant . ,(delay python2-fake-factory))))))
> +
> +(define-public python2-fake-factory
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-fake-factory))))
> +    (package
> +      (inherit base)
> +      (native-inputs
> +       `(("python2-ipaddress" ,python2-ipaddress)
> +         ,@(package-native-inputs base))))))

I have the same question for python2-ipaddress.