From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: Add netcat-openbsd. [v2] Date: Wed, 22 Jun 2016 22:43:15 +0000 Message-ID: <20160622224315.GA17885@shadowwalker> References: <20160622000749.GA27984@shadowwalker> <20160622110046.GA12755@shadowwalker> <87r3bolxyn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFqro-0000TF-4B for guix-devel@gnu.org; Wed, 22 Jun 2016 18:43:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFqrj-0002cq-UW for guix-devel@gnu.org; Wed, 22 Jun 2016 18:43:27 -0400 Received: from 93-95-228-168.1984.is ([93.95.228.168]:50134 helo=beleriand.n0.is) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFqrj-0002bi-GU for guix-devel@gnu.org; Wed, 22 Jun 2016 18:43:23 -0400 Received: by beleriand.n0.is (OpenSMTPD) with ESMTPSA id c0ea3a6b TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO for ; Wed, 22 Jun 2016 22:43:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87r3bolxyn.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org On 2016-06-22(11:23:28PM+0200), Ludovic Courtès wrote: > Hi! > > ng0 skribis: > > > * gnu/packages/admin.scm (netcat-openbsd): New variable. > > * patches/netcat-openbsd-0001-port-to-linux-with-libbsd.patch, > > patches/netcat-openbsd-0002-connect-timeout.patch, > > patches/netcat-openbsd-0003-get-sev-by-name.patch, > > patches/netcat-openbsd-0004-poll-hup.patch, > > patches/netcat-openbsd-0005-send-crlf.patch, > > patches/netcat-openbsd-0006-quit-timer.patch, > > patches/netcat-openbsd-0007-udp-scan-timeout.patch, > > patches/netcat-openbsd-0008-verbose-numeric-port.patch, > > patches/netcat-openbsd-0009-dccp-support.patch, > > patches/netcat-openbsd-0010-serialized-handling-multiple-clients.patch, > > patches/netcat-openbsd-0011-misc-failures-and-features.patch: New files. > > Sorry for joining late, but I think 11 non-trivial patches is not OK (we > have the policy of not keeping non-trivial patches, unless they fix an > immediate bug or a Guix-specific issue.) > > Is there an upstream for this package? The upstream is the debian port to linux of the nc binary of OpenBSD (see in code comment on upstream), mentioned in the package. As I understand the binary in OpenBSD compared to Debian, and to what Gentoo, Archlinux, Debian (and possibly every other distro) use, this is the defacto upstream. Maybe many of those patches are not necessary in OpenBSD, but all the Linux ports use them. So those are bug fixes and a minority of feature fixes. I could try to get in contact with the person who wrote the patches in 2012 and/or the current Debian maintainer and see if they ever tried to push the generic changes back to OpenBSD. Second choice, I ask Debian to merge those patches into their upstream, the tarball I downloaded did not have those patches applied. If I can get a reason/feedback on any of these and it turns out that we need those patches, would an exception from the policy be okay? I can look at what they add and further comment or provide comment by Debian upstream on why they are needed. > Thanks, > Ludo’. > -- ♥Ⓐ ng0 For non-prism friendly talk find me on psyced.org / loupsycedyglgamf.onion