From: ng0 <ng0@we.make.ritual.n0.is>
To: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add netcat-openbsd.
Date: Wed, 22 Jun 2016 08:33:04 +0000 [thread overview]
Message-ID: <20160622083304.GB927@shadowwalker> (raw)
In-Reply-To: <20160622045223.GA12510@jasmine>
On 2016-06-22(12:52:23AM-0400), Leo Famulari wrote:
> Thank you for this patch!
>
> On Wed, Jun 22, 2016 at 12:07:50AM +0000, ng0 wrote:
> > Initially, this could make git throw some trailing
> > whitespace problems on the new files in patches dir,
> > but they are fixed by git itself.
>
> I think the whitespace warnings about the patches are fine.
>
> > Subject: [PATCH] gnu: Add netcat-openbsd.
> >
> > * gnu/packages/admin.scm (netcat-openbsd): New variable.
> > * patches/netcat-openbsd-0001-port-to-linux-with-libsd.patch,
> > patches/netcat-openbsd-0002-connect-timeout.patch,
> > patches/netcat-openbsd-0003-get-sev-by-name.patch,
> > patches/netcat-openbsd-0004-poll-hup.patch,
> > patches/netcat-openbsd-0005-send-crlf.patch,
> > patches/netcat-openbsd-0006-quit-timer.patch,
> > patches/netcat-openbsd-0007-udp-scan-timeout.patch,
> > patches/netcat-openbsd-0008-verbose-numeric-port.patch,
> > patches/netcat-openbsd-0009-dccp-support.patch,
> > patches/netcat-openbsd-0010-serialized-handling-multiple-clients.patch,
> > patches/netcat-openbsd-0011-misc-failures-and-features.patch: New files.
>
> Can you add a link to the upstream source of the patch in each patch?
> I think the links containing Git hashes are best. For example, from the
> commit that I think added the patches [0] (they may have been changed
> since), you can navigate the tree to the patches directory and copy the
> URLs.
>
> [0]
> https://anonscm.debian.org/cgit/collab-maint/netcat-openbsd.git/commit/debian?id=db2b1d9a8d4644ef892f47d84606ee96598d23fb
>
Is a comment in the patches like this more like what you want?
Guix: This patch is based db2b1d9a8d4644ef892f47d84606ee96598d23fb
of http://anonscm.debian.org/cgit/collab-maint/netcat-openbsd.git
--
♥Ⓐ ng0
For non-prism friendly talk find me on
psyced.org / loupsycedyglgamf.onion
next prev parent reply other threads:[~2016-06-22 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 0:07 [PATCH] gnu: Add netcat-openbsd ng0
2016-06-22 4:52 ` Leo Famulari
2016-06-22 8:14 ` ng0
2016-06-22 8:33 ` ng0 [this message]
2016-06-22 11:00 ` [PATCH] gnu: Add netcat-openbsd. [v2] ng0
2016-06-22 21:23 ` Ludovic Courtès
2016-06-22 22:43 ` ng0
2016-06-24 11:53 ` Ludovic Courtès
2016-07-08 16:24 ` ng0
2016-06-22 22:46 ` ng0
2016-08-04 8:26 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622083304.GB927@shadowwalker \
--to=ng0@we.make.ritual.n0.is \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).