From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add netcat-openbsd. Date: Wed, 22 Jun 2016 00:52:23 -0400 Message-ID: <20160622045223.GA12510@jasmine> References: <20160622000749.GA27984@shadowwalker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFa9Z-0003lC-HS for guix-devel@gnu.org; Wed, 22 Jun 2016 00:52:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFa9T-0005Wx-Ao for guix-devel@gnu.org; Wed, 22 Jun 2016 00:52:40 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:55693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFa9S-0005Wc-0f for guix-devel@gnu.org; Wed, 22 Jun 2016 00:52:35 -0400 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 5505ACCDB4 for ; Wed, 22 Jun 2016 00:52:25 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20160622000749.GA27984@shadowwalker> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Thank you for this patch! On Wed, Jun 22, 2016 at 12:07:50AM +0000, ng0 wrote: > Initially, this could make git throw some trailing > whitespace problems on the new files in patches dir, > but they are fixed by git itself. I think the whitespace warnings about the patches are fine. > Subject: [PATCH] gnu: Add netcat-openbsd. > > * gnu/packages/admin.scm (netcat-openbsd): New variable. > * patches/netcat-openbsd-0001-port-to-linux-with-libsd.patch, > patches/netcat-openbsd-0002-connect-timeout.patch, > patches/netcat-openbsd-0003-get-sev-by-name.patch, > patches/netcat-openbsd-0004-poll-hup.patch, > patches/netcat-openbsd-0005-send-crlf.patch, > patches/netcat-openbsd-0006-quit-timer.patch, > patches/netcat-openbsd-0007-udp-scan-timeout.patch, > patches/netcat-openbsd-0008-verbose-numeric-port.patch, > patches/netcat-openbsd-0009-dccp-support.patch, > patches/netcat-openbsd-0010-serialized-handling-multiple-clients.patch, > patches/netcat-openbsd-0011-misc-failures-and-features.patch: New files. Can you add a link to the upstream source of the patch in each patch? I think the links containing Git hashes are best. For example, from the commit that I think added the patches [0] (they may have been changed since), you can navigate the tree to the patches directory and copy the URLs. [0] https://anonscm.debian.org/cgit/collab-maint/netcat-openbsd.git/commit/debian?id=db2b1d9a8d4644ef892f47d84606ee96598d23fb