From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add chromium-bsu.
Date: Tue, 21 Jun 2016 17:44:19 -0400
Message-ID: <20160621214419.GA9515@jasmine>
References: <87h9cmtzgc.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bFTTM-00088p-8n
	for guix-devel@gnu.org; Tue, 21 Jun 2016 17:44:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bFTTG-0008SY-88
	for guix-devel@gnu.org; Tue, 21 Jun 2016 17:44:39 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52917)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bFTTE-0008SD-Ub
	for guix-devel@gnu.org; Tue, 21 Jun 2016 17:44:34 -0400
Content-Disposition: inline
In-Reply-To: <87h9cmtzgc.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org

On Tue, Jun 21, 2016 at 09:59:31AM -0400, Kei Kebreau wrote:
> * gnu/packages/games (chromium-bsu): New variable.

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'set-paths 'set-sdl-paths
> +                             (lambda* (#:key inputs #:allow-other-keys)
> +                               (setenv "CPATH"
> +                                       (string-append (assoc-ref inputs "sdl-union")
> +                                                      "/include/SDL"))
> +                               #t)))))

If you move (modify-phases) underneath #:phases, then this will be
comfortably shorter than 80 characters :)

> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("freeglut" ,freeglut)
> +              ("glu" ,glu)
> +              ("quesoglc" ,quesoglc)
> +              ("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer)))))

The output doesn't refer to freeglut. I wonder if it should be
native, propagated, or if it's not needed, etc?

I ran the game on GuixSD, and it did work, although it was much slower
than on my Debian system. I don't know if that was merely a consequence
of the GuixSD system using much older hardware, or if it's related to
the missing reference to freeglut.