unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add chromium-bsu.
Date: Tue, 21 Jun 2016 17:44:19 -0400	[thread overview]
Message-ID: <20160621214419.GA9515@jasmine> (raw)
In-Reply-To: <87h9cmtzgc.fsf@openmailbox.org>

On Tue, Jun 21, 2016 at 09:59:31AM -0400, Kei Kebreau wrote:
> * gnu/packages/games (chromium-bsu): New variable.

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'set-paths 'set-sdl-paths
> +                             (lambda* (#:key inputs #:allow-other-keys)
> +                               (setenv "CPATH"
> +                                       (string-append (assoc-ref inputs "sdl-union")
> +                                                      "/include/SDL"))
> +                               #t)))))

If you move (modify-phases) underneath #:phases, then this will be
comfortably shorter than 80 characters :)

> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("freeglut" ,freeglut)
> +              ("glu" ,glu)
> +              ("quesoglc" ,quesoglc)
> +              ("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer)))))

The output doesn't refer to freeglut. I wonder if it should be
native, propagated, or if it's not needed, etc?

I ran the game on GuixSD, and it did work, although it was much slower
than on my Debian system. I don't know if that was merely a consequence
of the GuixSD system using much older hardware, or if it's related to
the missing reference to freeglut.

  reply	other threads:[~2016-06-21 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 13:59 [PATCH] gnu: Add chromium-bsu Kei Kebreau
2016-06-21 21:44 ` Leo Famulari [this message]
2016-06-22  1:07   ` Kei Kebreau
2016-06-22  8:24   ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160621214419.GA9515@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).