From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add msgpack Date: Mon, 20 Jun 2016 13:09:49 -0400 Message-ID: <20160620170949.GA22393@jasmine> References: <87wpmbuv6m.fsf@openmailbox.org> <20160606140737.GA26555@jasmine> <20160611030655.GA24837@jasmine> <87lh2b7009.fsf@openmailbox.org> <20160612001750.GA9854@jasmine> <87eg836nm3.fsf@openmailbox.org> <20160613165852.GA31846@jasmine> <20160613175910.GA6456@jasmine> <87fusbyhk7.fsf@openmailbox.org> <8737o9onan.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF2i4-0006rL-KR for guix-devel@gnu.org; Mon, 20 Jun 2016 13:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF2hz-00052H-It for guix-devel@gnu.org; Mon, 20 Jun 2016 13:10:03 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF2hy-00050e-6X for guix-devel@gnu.org; Mon, 20 Jun 2016 13:09:59 -0400 Content-Disposition: inline In-Reply-To: <8737o9onan.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Lukas Gradl Cc: guix-devel@gnu.org On Sat, Jun 18, 2016 at 10:44:16PM -0500, Lukas Gradl wrote: > Lukas Gradl writes: > > > So the flags -I, -L, -l for zlib are all there for both dynamic and > > static linking. But still no store reference. > > I think the reason why there is no reference is that msgpack uses > zbuffer only for tests. Before compilation, the file only references > the name "zlib" and does not mention the hash in the path of zlib in the > store. During compilation (during "check"), this mere name "zlib" gets > somehow resolved to the path of zlib in the store. The binary file > resulting from compiling zbuffer should therefore contain a reference to > zlib, which should be detectable by guix gc --references. I think > however, that this binary file does not get installed as it is only used > for tests. All the files that do get installed in the output path of > msgpack in the store do not contain the hash part of the store-path of > zlib. They only refer to zlib by name. IIUC this can not be detected > by guix gc --references since it only searches for the hash part of > the store-path of zlib. > > This is what I grasp from looking at libstore/references.cc and > libstore/store-api.cc. I am not sure about this though. That's my understanding as well. Thanks for trying all the things you described in your previous email. Since we are still stuck on this, I think we should continue with Ring and see if this becomes a problem later on. If so, let's contact the msgpack maintainers and ask for advice. We should add a caveat in a comment in msgpack's package definition, for future readers. I'm curious — how close are you to a Ring package definition?