From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/3] gnu: Add r-vegan. Date: Fri, 17 Jun 2016 21:00:43 -0400 Message-ID: <20160618010043.GA28359@jasmine> References: <1466081273-15127-1-git-send-email-donttrustben@gmail.com> <1466081273-15127-4-git-send-email-donttrustben@gmail.com> <20160618005616.GA25816@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE4dA-0003kp-7d for guix-devel@gnu.org; Fri, 17 Jun 2016 21:01:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE4d6-0003Wf-4v for guix-devel@gnu.org; Fri, 17 Jun 2016 21:01:00 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE4d4-0003UT-V4 for guix-devel@gnu.org; Fri, 17 Jun 2016 21:00:56 -0400 Content-Disposition: inline In-Reply-To: <20160618005616.GA25816@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org On Fri, Jun 17, 2016 at 08:56:16PM -0400, Leo Famulari wrote: > On Thu, Jun 16, 2016 at 10:47:53PM +1000, Ben Woodcroft wrote: > > * gnu/packages/bioinformatics.scm (r-vegan): New variable. > > * gnu/packages/patches/vegan-revert-test-deletion.patch: New file. > > This patch is 460K uncompressed. gzip reduces it to 124K. Currently > `guix pull` downloads a 10.2 MiB tarball. Just food for thought ;) By the way, thanks for addressing the question of the tests with the upstream maintainers! > > > + (license license:gpl2+))) > > The first file I checked in the Git repo has a different license: > https://github.com/vegandevs/vegan/blob/master/src/pnpoly.c > > Can you check if there are any other files with different licenses?