unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add r-vegan.
Date: Fri, 17 Jun 2016 21:00:43 -0400	[thread overview]
Message-ID: <20160618010043.GA28359@jasmine> (raw)
In-Reply-To: <20160618005616.GA25816@jasmine>

On Fri, Jun 17, 2016 at 08:56:16PM -0400, Leo Famulari wrote:
> On Thu, Jun 16, 2016 at 10:47:53PM +1000, Ben Woodcroft wrote:
> > * gnu/packages/bioinformatics.scm (r-vegan): New variable.
> > * gnu/packages/patches/vegan-revert-test-deletion.patch: New file.
> 
> This patch is 460K uncompressed. gzip reduces it to 124K. Currently
> `guix pull` downloads a 10.2 MiB tarball. Just food for thought ;)

By the way, thanks for addressing the question of the tests with the
upstream maintainers!

> 
> > +    (license license:gpl2+)))
> 
> The first file I checked in the Git repo has a different license:
> https://github.com/vegandevs/vegan/blob/master/src/pnpoly.c
> 
> Can you check if there are any other files with different licenses?

  reply	other threads:[~2016-06-18  1:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 12:47 [PATCH 0/3]: Add vegan Ben Woodcroft
2016-06-16 12:47 ` [PATCH 1/3] gnu: Add r-permute Ben Woodcroft
2016-06-16 12:47 ` [PATCH 2/3] gnu: Add r-mgcv Ben Woodcroft
2016-06-16 12:47 ` [PATCH 3/3] gnu: Add r-vegan Ben Woodcroft
2016-06-18  0:56   ` Leo Famulari
2016-06-18  1:00     ` Leo Famulari [this message]
2016-06-19 13:48     ` Ludovic Courtès
2016-06-21 11:43       ` Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160618010043.GA28359@jasmine \
    --to=leo@famulari.name \
    --cc=donttrustben@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).