From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Update python2-jsonrpclib (refactor)
Date: Fri, 17 Jun 2016 20:22:15 -0400
Message-ID: <20160618002215.GB19441@jasmine>
References: <aad4c42c257eda72c5326c620a522e12@d4n1.org>
	<542d6b081afeaf6902b236cb66163958@d4n1.org>
	<e65b5961caadfe449b33dd1d65a556c2@d4n1.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bE41z-00063n-JX
	for guix-devel@gnu.org; Fri, 17 Jun 2016 20:22:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bE41t-0004gV-CY
	for guix-devel@gnu.org; Fri, 17 Jun 2016 20:22:34 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56530)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bE41s-0004gK-66
	for guix-devel@gnu.org; Fri, 17 Jun 2016 20:22:29 -0400
Content-Disposition: inline
In-Reply-To: <e65b5961caadfe449b33dd1d65a556c2@d4n1.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Daniel Pimentel <d4n1@d4n1.org>
Cc: guix-devel@gnu.org

On Thu, Jun 16, 2016 at 09:10:09AM -0300, Daniel Pimentel wrote:
> Subject: [PATCH] gnu: Add python2-jsonrpclib

Thanks! Applied as 0de78c95 with the following minor changes:

> +              (uri (string-append
> +                    "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-"
> +                    version ".tar.gz"))

I re-wrapped the URL to keep it under 80 characters.

> +    (inputs
> +     `(("python2-setuptools" ,python2-setuptools)))

I made setuptools a native-input, since it doesn't appear to be used at
run-time.

> +    (arguments
> +     `(#:tests? #f
> +                #:python ,python-2))

I shifted the indentation left to match the previous line.

> +    (license license:expat)))

I changed this to asl2.0, the Apache License 2.0, since that's what in
LICENSE.txt.