unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Daniel Pimentel <d4n1@d4n1.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Update python2-jsonrpclib (refactor)
Date: Fri, 17 Jun 2016 20:22:15 -0400	[thread overview]
Message-ID: <20160618002215.GB19441@jasmine> (raw)
In-Reply-To: <e65b5961caadfe449b33dd1d65a556c2@d4n1.org>

On Thu, Jun 16, 2016 at 09:10:09AM -0300, Daniel Pimentel wrote:
> Subject: [PATCH] gnu: Add python2-jsonrpclib

Thanks! Applied as 0de78c95 with the following minor changes:

> +              (uri (string-append
> +                    "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-"
> +                    version ".tar.gz"))

I re-wrapped the URL to keep it under 80 characters.

> +    (inputs
> +     `(("python2-setuptools" ,python2-setuptools)))

I made setuptools a native-input, since it doesn't appear to be used at
run-time.

> +    (arguments
> +     `(#:tests? #f
> +                #:python ,python-2))

I shifted the indentation left to match the previous line.

> +    (license license:expat)))

I changed this to asl2.0, the Apache License 2.0, since that's what in
LICENSE.txt.

  reply	other threads:[~2016-06-18  0:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10  0:14 [PATCH] gnu: Add python2-jsonrpclib Daniel Pimentel
2016-06-10  5:50 ` Ben Woodcroft
2016-06-11 23:28   ` d4n1
2016-06-14 19:52 ` [PATCH] gnu: Update python2-jsonrpclib Daniel Pimentel
2016-06-16 12:10   ` [PATCH] gnu: Update python2-jsonrpclib (refactor) Daniel Pimentel
2016-06-18  0:22     ` Leo Famulari [this message]
2016-06-18  0:39       ` [PATCH 1/1] gnu: Update python2-jsonrpclib Daniel Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160618002215.GB19441@jasmine \
    --to=leo@famulari.name \
    --cc=d4n1@d4n1.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).