From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add khmer. Date: Fri, 17 Jun 2016 13:54:31 -0400 Message-ID: <20160617175431.GA9008@jasmine> References: <1466126601-30932-1-git-send-email-donttrustben@gmail.com> <20160617081630.GA6570@jasmine> <5763C61C.1050402@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxyi-0001MU-N0 for Guix-devel@gnu.org; Fri, 17 Jun 2016 13:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxyc-0003KK-M8 for Guix-devel@gnu.org; Fri, 17 Jun 2016 13:54:47 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxyb-0003JY-F7 for Guix-devel@gnu.org; Fri, 17 Jun 2016 13:54:42 -0400 Content-Disposition: inline In-Reply-To: <5763C61C.1050402@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: Guix-devel@gnu.org On Fri, Jun 17, 2016 at 07:42:52PM +1000, Ben Woodcroft wrote: > Hey Leo, thanks for the thoughts. > > On 17/06/16 18:16, Leo Famulari wrote: > > On Fri, Jun 17, 2016 at 11:23:18AM +1000, Ben Woodcroft wrote: > > > 'murmur-hash' takes the code from a repository SMHasher, but I'm not > > > interested in packaging that. That is OK? > > I'll try packaging SMHasher. Hopefully it's not too hard. > > Go right ahead if you like. However, I wouldn't really recommend it because > the only function of it is to test the quality of different hash algorithms, > which probably isn't useful as anything except as an end in itself, and in > that case a user might want to manage the compilation flags themselves > anyway. But I won't stand in your way, of course. I saw that SMHasher was just a test suite for hash algorithms [0], but I don't really have any idea how it would be used in practice. So, perhaps you're right that every user would have their own set of flags they want to build with, making our package less useful. > What if we change the name of the package to 'smhasher' and leave packaging > the binary for later if someone is really interested? Is murmur designed to be bundled? If there are no proper releases of a library, then does it make sense to roll-our-own packaging like this? [0] But also the reference implementation of murmur and potentially some other algorithms?