* syntax check before commit and patch: net-perl-psyc
@ 2016-06-13 14:07 ng0
2016-06-14 10:10 ` Ludovic Courtès
2016-06-14 14:56 ` [PATCH] " ng0
0 siblings, 2 replies; 6+ messages in thread
From: ng0 @ 2016-06-13 14:07 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 3804 bytes --]
Hi,
the following is an insert minus the header etc of
net-perl-psyc. Before I commit and send in a patch, I'd
like to check if there's anything I can improve.
I have not yet set a synopsis and description, this
was just as a place holder.
;; highly optional dependencies: rxaudio (mp3 binary from 1996)
;; opt. perl: MP3::List (psycmp3), Curses (psycion), pwd.pl
;; (psyccmd), SGI::FAM module (psycfilemonitor); for full
;; functionality package all except MP3::List.
(define-public perl-net-psyc
(let ((commit "4176f5236e73e99391c0877152d5596ab0a9b154"))
(package
(name "perl-net-psyc")
(version (string-append "1.0" "-"
(string-take commit 7)))
(source (origin
(method git-fetch)
(uri (git-reference
(url "git://git.psyced.org/git/perlpsyc")
(commit commit)))
(file-name (string-append name "-" version))
(sha256
(base32
"19msvr1kriqa6n8cnk8z96xd5i0v5cy2y52jsj08vaj79b4m7sph"))))
(build-system perl-build-system)
(arguments
`(#:phases
(modify-phases %standard-phases
(delete 'configure)
(delete 'build)
(replace
'install
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
(doc (string-append out "/share/doc/perl-net-psyc"))
(libpsyc (string-append out "/lib/psyc/ion"))
(libperl (string-append out "/lib/perl5/site_perl/"
,(package-version perl)))
(bin (string-append out "/bin")))
(copy-recursively "lib/perl5" libperl)
(copy-recursively "lib/psycion" libpsyc)
(copy-recursively "bin" bin)
(install-file "cgi/psycpager" (string-append doc "/cgi"))
(copy-recursively "contrib" (string-append doc "/contrib"))
(copy-recursively "hooks" (string-append doc "/hooks"))
(copy-recursively "sdj" (string-append doc "/sdj"))
(install-file "README.txt" doc)
(install-file "TODO.txt" doc)
#t)))
(add-after 'install 'wrap-programs
(lambda* (#:key outputs #:allow-other-keys)
;; Make sure all executables in "bin" find the Perl modules
;; provided by this package at runtime.
(let* ((out (assoc-ref outputs "out"))
(bin (string-append out "/bin/"))
(path (string-append out "/lib/perl5/site_perl")))
(for-each (lambda (file)
(wrap-program file
`("PERL5LIB" ":" prefix (,path))))
(find-files bin "\\.*$"))
;; XXX: hooks/dpa2psyc,examples/{recvtest,sendtest},
;; cgi/psycpager,contrib/{makenoise,keefchat
;; contrib/MovableTypeBlog/plugins/psyc.pl
#t))))))
(description
"Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
(synopsis
"Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
(home-page "http://perlpsyc.pages.de")
;;dual licensed: gpl2+ Artistic
(license (list gpl2+ (package-license perl))))))
thanks,
--
♥Ⓐ ng0
For non-prism friendly talk find me on
psyced.org / loupsycedyglgamf.onion
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: syntax check before commit and patch: net-perl-psyc
2016-06-13 14:07 syntax check before commit and patch: net-perl-psyc ng0
@ 2016-06-14 10:10 ` Ludovic Courtès
2016-06-14 12:39 ` ng0
2016-06-14 14:56 ` [PATCH] " ng0
1 sibling, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-06-14 10:10 UTC (permalink / raw)
To: guix-devel
Hello!
ng0 <ng0@we.make.ritual.n0.is> skribis:
> the following is an insert minus the header etc of
> net-perl-psyc. Before I commit and send in a patch, I'd
> like to check if there's anything I can improve.
Overall it looks good!
> (replace
> 'install
> (lambda* (#:key outputs #:allow-other-keys)
> (let* ((out (assoc-ref outputs "out"))
> (doc (string-append out "/share/doc/perl-net-psyc"))
> (libpsyc (string-append out "/lib/psyc/ion"))
> (libperl (string-append out "/lib/perl5/site_perl/"
> ,(package-version perl)))
> (bin (string-append out "/bin")))
> (copy-recursively "lib/perl5" libperl)
> (copy-recursively "lib/psycion" libpsyc)
> (copy-recursively "bin" bin)
> (install-file "cgi/psycpager" (string-append doc "/cgi"))
> (copy-recursively "contrib" (string-append doc "/contrib"))
> (copy-recursively "hooks" (string-append doc "/hooks"))
> (copy-recursively "sdj" (string-append doc "/sdj"))
> (install-file "README.txt" doc)
> (install-file "TODO.txt" doc)
> #t)))
Doesn’t “./Build install” do that? (This is what ‘perl-build-system’
does, see (guix build perl-build-system).)
> (add-after 'install 'wrap-programs
> (lambda* (#:key outputs #:allow-other-keys)
> ;; Make sure all executables in "bin" find the Perl modules
> ;; provided by this package at runtime.
> (let* ((out (assoc-ref outputs "out"))
> (bin (string-append out "/bin/"))
> (path (string-append out "/lib/perl5/site_perl")))
> (for-each (lambda (file)
> (wrap-program file
> `("PERL5LIB" ":" prefix (,path))))
> (find-files bin "\\.*$"))
> ;; XXX: hooks/dpa2psyc,examples/{recvtest,sendtest},
> ;; cgi/psycpager,contrib/{makenoise,keefchat
> ;; contrib/MovableTypeBlog/plugins/psyc.pl
> #t))))))
This reminds me that we should eventually update ‘perl-build-system’ to
have a ‘wrap’ phase similar to that of ‘python-build-system’.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: syntax check before commit and patch: net-perl-psyc
2016-06-14 10:10 ` Ludovic Courtès
@ 2016-06-14 12:39 ` ng0
2016-06-14 12:59 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: ng0 @ 2016-06-14 12:39 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 4047 bytes --]
On 2016-06-14(12:10:05+0200), Ludovic Courtès wrote:
> Hello!
>
> ng0 <ng0@we.make.ritual.n0.is> skribis:
>
> > the following is an insert minus the header etc of
> > net-perl-psyc. Before I commit and send in a patch, I'd
> > like to check if there's anything I can improve.
>
> Overall it looks good!
>
> > (replace
> > 'install
> > (lambda* (#:key outputs #:allow-other-keys)
> > (let* ((out (assoc-ref outputs "out"))
> > (doc (string-append out "/share/doc/perl-net-psyc"))
> > (libpsyc (string-append out "/lib/psyc/ion"))
> > (libperl (string-append out "/lib/perl5/site_perl/"
> > ,(package-version perl)))
> > (bin (string-append out "/bin")))
> > (copy-recursively "lib/perl5" libperl)
> > (copy-recursively "lib/psycion" libpsyc)
> > (copy-recursively "bin" bin)
> > (install-file "cgi/psycpager" (string-append doc "/cgi"))
> > (copy-recursively "contrib" (string-append doc "/contrib"))
> > (copy-recursively "hooks" (string-append doc "/hooks"))
> > (copy-recursively "sdj" (string-append doc "/sdj"))
> > (install-file "README.txt" doc)
> > (install-file "TODO.txt" doc)
> > #t)))
>
> Doesn’t “./Build install” do that? (This is what ‘perl-build-system’
> does, see (guix build perl-build-system).)
>
No, as it's not existing in the perlpsyc repository,
and the install above does what our gentoo overlay
ebuild of Net-PSYC does, which the author of the
software themselves maintains.
~/src/re-src/psyced/perlpsyc/INSTALL.txt:
You can simply move the contents of bin and lib into
the respective directories of /usr/local and things
should work from there. You can also put things into
/usr/depot, then add /usr/depot/bin to your PATH.
You may want to install a perl interpreter.
For a proper integration into your Unix distribution,
reach out for your vendor team.
> > (add-after 'install 'wrap-programs
> > (lambda* (#:key outputs #:allow-other-keys)
> > ;; Make sure all executables in "bin" find the Perl modules
> > ;; provided by this package at runtime.
> > (let* ((out (assoc-ref outputs "out"))
> > (bin (string-append out "/bin/"))
> > (path (string-append out "/lib/perl5/site_perl")))
> > (for-each (lambda (file)
> > (wrap-program file
> > `("PERL5LIB" ":" prefix (,path))))
> > (find-files bin "\\.*$"))
> > ;; XXX: hooks/dpa2psyc,examples/{recvtest,sendtest},
> > ;; cgi/psycpager,contrib/{makenoise,keefchat
> > ;; contrib/MovableTypeBlog/plugins/psyc.pl
> > #t))))))
>
> This reminds me that we should eventually update ‘perl-build-system’ to
> have a ‘wrap’ phase similar to that of ‘python-build-system’.
>
> Thanks,
> Ludo’.
>
Thanks for taking the time to look into it.
Would you know if other than the source of perl-build-system, the section 7.2.6.1
"Locale Data Compatibility Considerations" and the section above (and below?) in
the manual could serve as an explanation to the authors question of
"Why do you wrap such a simple language as perl?" ?
I know it becomes more obvious once you look more into details, but maybe you
have an explanation which wouldn't take so many turns as mine, or be too simple
("look at the source").
thanks,
--
♥Ⓐ ng0
For non-prism friendly talk find me on
psyced.org / loupsycedyglgamf.onion
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: syntax check before commit and patch: net-perl-psyc
2016-06-14 12:39 ` ng0
@ 2016-06-14 12:59 ` Ricardo Wurmus
0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2016-06-14 12:59 UTC (permalink / raw)
To: ng0; +Cc: guix-devel
ng0 <ng0@we.make.ritual.n0.is> writes:
> On 2016-06-14(12:10:05+0200), Ludovic Courtès wrote:
>> This reminds me that we should eventually update ‘perl-build-system’ to
>> have a ‘wrap’ phase similar to that of ‘python-build-system’.
>>
>> Thanks,
>> Ludo’.
>>
>
> Thanks for taking the time to look into it.
> Would you know if other than the source of perl-build-system, the section 7.2.6.1
> "Locale Data Compatibility Considerations" and the section above (and below?) in
> the manual could serve as an explanation to the authors question of
> "Why do you wrap such a simple language as perl?" ?
>
> I know it becomes more obvious once you look more into details, but maybe you
> have an explanation which wouldn't take so many turns as mine, or be too simple
> ("look at the source").
The wrapping is a necessity that stems from two causes:
- we install all packages (including Perl modules) to their very own
prefixes under /gnu/store
- Perl (like Python, Guile, R, and other languages, but unlike C) looks
up modules by name in a list of directories.
To ensure that a Perl script can find all modules it depends on we
create a wrapper that sets an environment variable such that it contains
the location of all Perl modules that are needed at runtime. In a
traditional system that adheres to the FHS this is not required because
modules are installed into *one* location which happens to be among the
standard directories that Perl natively searches.
Without a wrapper users would need to do one of these two things:
- install Perl and all dependent modules into a profile (that’s what
happens when we propagate packages); then set the module path
environment variable to the shared directory for Perl modules in the
profile.
- manually assemble a list of directories in /gnu/store and set the
environment variable to it. We do this with a wrapper instead.
~~ Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Re: syntax check before commit and patch: net-perl-psyc
2016-06-13 14:07 syntax check before commit and patch: net-perl-psyc ng0
2016-06-14 10:10 ` Ludovic Courtès
@ 2016-06-14 14:56 ` ng0
2016-06-15 13:11 ` Ludovic Courtès
1 sibling, 1 reply; 6+ messages in thread
From: ng0 @ 2016-06-14 14:56 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1.1: Type: text/plain, Size: 4879 bytes --]
From 771d300cd6f195720e782464ce7a7328edcf566f Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Tue, 14 Jun 2016 14:52:52 +0000
Subject: [PATCH] gnu: Add perl-net-psyc.
* gnu/packages/perl.scm (perl-net-psyc): New Variable.
---
gnu/packages/perl.scm | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index e7e7967..c16a913 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2016 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Jochem Raat <jchmrt@riseup.net>
;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -28,6 +29,7 @@
#:use-module (gnu packages)
#:use-module (guix packages)
#:use-module (guix download)
+ #:use-module (guix git-download)
#:use-module (guix build-system gnu)
#:use-module (guix build-system perl))
@@ -3865,6 +3867,73 @@ cycle. Functions called in the package itself will still be bound by their
name, but they won't show up as methods on your class or instances.")
(license (package-license perl))))
+;; highly optional dependencies: rxaudio (mp3 binary from 1996)
+;; opt. perl: MP3::List (psycmp3), Curses (psycion), pwd.pl
+;; (psyccmd), SGI::FAM module (psycfilemonitor); for full
+;; functionality package all except MP3::List.
+(define-public perl-net-psyc
+ (let ((commit "4176f5236e73e99391c0877152d5596ab0a9b154"))
+ (package
+ (name "perl-net-psyc")
+ (version (string-append "1.0" "-"
+ (string-take commit 7)))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "git://git.psyced.org/git/perlpsyc")
+ (commit commit)))
+ (file-name (string-append name "-" version))
+ (sha256
+ (base32
+ "19msvr1kriqa6n8cnk8z96xd5i0v5cy2y52jsj08vaj79b4m7sph"))))
+ (build-system perl-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'build)
+ (replace
+ 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (doc (string-append out "/share/doc/perl-net-psyc"))
+ (libpsyc (string-append out "/lib/psyc/ion"))
+ (libperl (string-append out "/lib/perl5/site_perl/"
+ ,(package-version perl)))
+ (bin (string-append out "/bin")))
+ (copy-recursively "lib/perl5" libperl)
+ (copy-recursively "lib/psycion" libpsyc)
+ (copy-recursively "bin" bin)
+ (install-file "cgi/psycpager" (string-append doc "/cgi"))
+ (copy-recursively "contrib" (string-append doc "/contrib"))
+ (copy-recursively "hooks" (string-append doc "/hooks"))
+ (copy-recursively "sdj" (string-append doc "/sdj"))
+ (install-file "README.txt" doc)
+ (install-file "TODO.txt" doc)
+ #t)))
+ (add-after 'install 'wrap-programs
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; Make sure all executables in "bin" find the Perl modules
+ ;; provided by this package at runtime.
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (path (string-append out "/lib/perl5/site_perl")))
+ (for-each (lambda (file)
+ (wrap-program file
+ `("PERL5LIB" ":" prefix (,path))))
+ (find-files bin "\\.*$"))
+ ;; XXX: hooks/dpa2psyc,examples/{recvtest,sendtest},
+ ;; cgi/psycpager,contrib/{makenoise,keefchat
+ ;; contrib/MovableTypeBlog/plugins/psyc.pl
+ #t))))))
+ (description
+ "Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
+ (synopsis
+ "Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
+ (home-page "http://perlpsyc.pages.de")
+ ;;dual licensed: gpl2+ Artistic
+ (license (list gpl2+ (package-license perl))))))
+
(define-public perl-number-compare
(package
(name "perl-number-compare")
--
2.8.4
[-- Attachment #1.2: 0001-gnu-Add-perl-net-psyc.patch --]
[-- Type: text/x-diff, Size: 4884 bytes --]
From 771d300cd6f195720e782464ce7a7328edcf566f Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Tue, 14 Jun 2016 14:52:52 +0000
Subject: [PATCH] gnu: Add perl-net-psyc.
* gnu/packages/perl.scm (perl-net-psyc): New Variable.
---
gnu/packages/perl.scm | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index e7e7967..c16a913 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2016 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Jochem Raat <jchmrt@riseup.net>
;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -28,6 +29,7 @@
#:use-module (gnu packages)
#:use-module (guix packages)
#:use-module (guix download)
+ #:use-module (guix git-download)
#:use-module (guix build-system gnu)
#:use-module (guix build-system perl))
@@ -3865,6 +3867,73 @@ cycle. Functions called in the package itself will still be bound by their
name, but they won't show up as methods on your class or instances.")
(license (package-license perl))))
+;; highly optional dependencies: rxaudio (mp3 binary from 1996)
+;; opt. perl: MP3::List (psycmp3), Curses (psycion), pwd.pl
+;; (psyccmd), SGI::FAM module (psycfilemonitor); for full
+;; functionality package all except MP3::List.
+(define-public perl-net-psyc
+ (let ((commit "4176f5236e73e99391c0877152d5596ab0a9b154"))
+ (package
+ (name "perl-net-psyc")
+ (version (string-append "1.0" "-"
+ (string-take commit 7)))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "git://git.psyced.org/git/perlpsyc")
+ (commit commit)))
+ (file-name (string-append name "-" version))
+ (sha256
+ (base32
+ "19msvr1kriqa6n8cnk8z96xd5i0v5cy2y52jsj08vaj79b4m7sph"))))
+ (build-system perl-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (delete 'build)
+ (replace
+ 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (doc (string-append out "/share/doc/perl-net-psyc"))
+ (libpsyc (string-append out "/lib/psyc/ion"))
+ (libperl (string-append out "/lib/perl5/site_perl/"
+ ,(package-version perl)))
+ (bin (string-append out "/bin")))
+ (copy-recursively "lib/perl5" libperl)
+ (copy-recursively "lib/psycion" libpsyc)
+ (copy-recursively "bin" bin)
+ (install-file "cgi/psycpager" (string-append doc "/cgi"))
+ (copy-recursively "contrib" (string-append doc "/contrib"))
+ (copy-recursively "hooks" (string-append doc "/hooks"))
+ (copy-recursively "sdj" (string-append doc "/sdj"))
+ (install-file "README.txt" doc)
+ (install-file "TODO.txt" doc)
+ #t)))
+ (add-after 'install 'wrap-programs
+ (lambda* (#:key outputs #:allow-other-keys)
+ ;; Make sure all executables in "bin" find the Perl modules
+ ;; provided by this package at runtime.
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (path (string-append out "/lib/perl5/site_perl")))
+ (for-each (lambda (file)
+ (wrap-program file
+ `("PERL5LIB" ":" prefix (,path))))
+ (find-files bin "\\.*$"))
+ ;; XXX: hooks/dpa2psyc,examples/{recvtest,sendtest},
+ ;; cgi/psycpager,contrib/{makenoise,keefchat
+ ;; contrib/MovableTypeBlog/plugins/psyc.pl
+ #t))))))
+ (description
+ "Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
+ (synopsis
+ "Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
+ (home-page "http://perlpsyc.pages.de")
+ ;;dual licensed: gpl2+ Artistic
+ (license (list gpl2+ (package-license perl))))))
+
(define-public perl-number-compare
(package
(name "perl-number-compare")
--
2.8.4
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Re: syntax check before commit and patch: net-perl-psyc
2016-06-14 14:56 ` [PATCH] " ng0
@ 2016-06-15 13:11 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-06-15 13:11 UTC (permalink / raw)
To: guix-devel
ng0 <ng0@we.make.ritual.n0.is> skribis:
> + (description
> + "Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
> + (synopsis
> + "Perl implementation of PSYC protocol plus psycion, remotor, psycmp3 etc.")
The rest looks OK, but you forgot to update these two. Please see
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-15 13:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-13 14:07 syntax check before commit and patch: net-perl-psyc ng0
2016-06-14 10:10 ` Ludovic Courtès
2016-06-14 12:39 ` ng0
2016-06-14 12:59 ` Ricardo Wurmus
2016-06-14 14:56 ` [PATCH] " ng0
2016-06-15 13:11 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).