Re: [PATCH 02/14] gnu: Add qtimageformats.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 2589 bytes --]

On Tue, Jun 14, 2016 at 11:07:03AM +0200, Andreas Enge wrote:
> On Sun, Jun 12, 2016 at 11:20:24PM +0300, Efraim Flashner wrote:
> > quite possibly the inputs could be shortened, but since they're all
> > using qmake for configure I don't really know how to check.
> 
> You could compile the packages and use "guix gc --references" to check
> which of the inputs are used.
> 
> Two basic situations could occur:
> - Essentially all inputs of qtbase are also needed for the other packages.
>   Then in this special case, I think it does not matter too much to have
>   added a few additional inputs, which in any case will have no effect on
>   the build result or on installations.
> - Only qtbase is used as an input, and the occasional additional one.
>   Then I would add the inputs one by one by hand, until the package builds.
> I think that the first case is more likely, and would be happy with you
> pushing the packages then.
> 
> Andreas
> 

$ guix gc --references $(./pre-inst-env guix build qtsvg)

...

@ build-succeeded /gnu/store/1np6wm8mm9l8gljbr7qbknsbz8gz297j-qtsvg-5.6.1.drv -
   /gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22
   /gnu/store/fikq4039zcbsa2wqlx33rq4kgp9gswk9-qtbase-5.6.1
   /gnu/store/hsxhfmjgh8m4c0pavq3gd3gcrn8zrgxj-zlib-1.2.8
   /gnu/store/lnrclizlj6kj5dag7f6fgc68nqybb941-mesa-11.0.9
   /gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib

$ guix gc --references $(./pre-inst-env guix build qtimageformats)

...

@ build-succeeded /gnu/store/7xsiyx1mampavj7c92by7ng8ml564grl-qtimageformats-5.6.1.drv -
     /gnu/store/39hhrf0sasq4qzmnz2nyji8xgzcwgj5h-libmng-2.0.3
     /gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22
     /gnu/store/fikq4039zcbsa2wqlx33rq4kgp9gswk9-qtbase-5.6.1
     /gnu/store/hsxhfmjgh8m4c0pavq3gd3gcrn8zrgxj-zlib-1.2.8
     /gnu/store/lnrclizlj6kj5dag7f6fgc68nqybb941-mesa-11.0.9
     /gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib

It looks like they don't need the full list of inputs, so I'll run
through them and see how much it can be cleaned up. The other thing I
notice is that qtbase and these two all have references to mesa, which
makes me think it may not need to be propagated in qtbase afterall. Then
again, removing it may cause some packages that count on qt/qtbase's
mesa as an input will come up a dependancy short.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]