From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add msgpack Date: Mon, 13 Jun 2016 13:59:10 -0400 Message-ID: <20160613175910.GA6456@jasmine> References: <87wpmbuv6m.fsf@openmailbox.org> <20160606140737.GA26555@jasmine> <20160611030655.GA24837@jasmine> <87lh2b7009.fsf@openmailbox.org> <20160612001750.GA9854@jasmine> <87eg836nm3.fsf@openmailbox.org> <20160613165852.GA31846@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCW94-0004hd-8X for guix-devel@gnu.org; Mon, 13 Jun 2016 13:59:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCW8w-0007fm-HD for guix-devel@gnu.org; Mon, 13 Jun 2016 13:59:29 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCW8v-0007dj-4v for guix-devel@gnu.org; Mon, 13 Jun 2016 13:59:22 -0400 Content-Disposition: inline In-Reply-To: <20160613165852.GA31846@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Lukas Gradl Cc: guix-devel@gnu.org On Mon, Jun 13, 2016 at 12:58:52PM -0400, Leo Famulari wrote: > On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote: > > Oh, that is true. I searched around, but I could not find anything > > about zbuffer.h[pp]. I am not sure what it is used for. FWIW, it is > > only referenced in src/Makefile, src/Makefile.in, src/Makefile.am > > CMakeLists.txt and in the tests: > > [...] > > > Judging from this, I am inclined to think that msgpack does not use > > these two headers for anything but tests. But I am not sure about > > this. > > I think that another application would call the zbuffer functions, > although the string 'zbuffer' does not exist in the opendht source code. > But, we should make sure msgpack will work for other calling > applications that might be added later. > > On #guix, bavier suggested we patch 'msgpack.pc.in'. Specifically, we > should append the include flag to 'Cflags:' and create a 'Libs.private:' > field for the -L and -l flags. There are some examples in > 'gnu/packages'. > > More details on the IRC log: > https://gnunet.org/bot/log/guix/2016-06-13#T1056507 > > I've cc-ed Eric since I don't know much about pkg-config. Of course, I forgot to do this :p