From: Leo Famulari <leo@famulari.name>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add msgpack
Date: Mon, 13 Jun 2016 12:58:52 -0400 [thread overview]
Message-ID: <20160613165852.GA31846@jasmine> (raw)
In-Reply-To: <87eg836nm3.fsf@openmailbox.org>
On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote:
> Oh, that is true. I searched around, but I could not find anything
> about zbuffer.h[pp]. I am not sure what it is used for. FWIW, it is
> only referenced in src/Makefile, src/Makefile.in, src/Makefile.am
> CMakeLists.txt and in the tests:
[...]
> Judging from this, I am inclined to think that msgpack does not use
> these two headers for anything but tests. But I am not sure about
> this.
I think that another application would call the zbuffer functions,
although the string 'zbuffer' does not exist in the opendht source code.
But, we should make sure msgpack will work for other calling
applications that might be added later.
On #guix, bavier suggested we patch 'msgpack.pc.in'. Specifically, we
should append the include flag to 'Cflags:' and create a 'Libs.private:'
field for the -L and -l flags. There are some examples in
'gnu/packages'.
More details on the IRC log:
https://gnunet.org/bot/log/guix/2016-06-13#T1056507
I've cc-ed Eric since I don't know much about pkg-config.
> FWIW, I looked at what other distributions do:
>
> The Arch PKGBUILD does not refer to Zlib at all:
> https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/msgpack-c
>
> Gentoo has Zlib for tests:
> https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/msgpack/msgpack-1.1.0.ebuild
>
> Debian seems to not refer to Zlib:
> https://packages.debian.org/jessie/libmsgpackc2
> https://packages.debian.org/jessie/libmsgpack3
> https://packages.debian.org/jessie/libmsgpack-dev
I think that zlib is so ubiquitous that it's a safe assumption it will
can be found in the environment on the '/usr' distros.
> This Nix expression does not mention zlib:
> https://github.com/NixOS/nixpkgs/blob/f199be0fafcff0713dd4340b4373e575294aad58/pkgs/development/libraries/libmsgpack/generic.nix#L41
An oversight? I don't know the Nix equivalent of `guix refresh -l` to
check which of their packages use msgpack.
next prev parent reply other threads:[~2016-06-13 16:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 20:50 [PATCH] Add msgpack Lukas Gradl
2016-05-31 21:45 ` Leo Famulari
2016-06-01 4:49 ` Efraim Flashner
2016-06-03 0:50 ` Lukas Gradl
2016-06-06 14:07 ` Leo Famulari
2016-06-11 3:06 ` Leo Famulari
2016-06-11 23:56 ` Lukas Gradl
2016-06-12 0:17 ` Leo Famulari
2016-06-12 4:24 ` Lukas Gradl
2016-06-13 16:58 ` Leo Famulari [this message]
2016-06-13 17:59 ` Leo Famulari
2016-06-17 15:13 ` Lukas Gradl
2016-06-19 3:44 ` Lukas Gradl
2016-06-20 17:09 ` Leo Famulari
2016-06-21 13:55 ` Lukas Gradl
2016-06-21 16:06 ` Leo Famulari
2016-06-21 15:59 ` Lukas Gradl
2016-06-21 16:49 ` Efraim Flashner
2016-06-22 6:05 ` Lukas Gradl
2016-06-22 5:56 ` Lukas Gradl
2016-06-21 8:38 ` Ludovic Courtès
2016-06-21 13:31 ` Lukas Gradl
2016-06-21 14:11 ` Ludovic Courtès
2016-06-25 15:31 ` Leo Famulari
2016-06-25 16:40 ` Lukas Gradl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613165852.GA31846@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=lgradl@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).