From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add awesome.
Date: Mon, 13 Jun 2016 11:46:19 -0400
Message-ID: <20160613154619.GA13902@jasmine>
References: <1465776755-16444-1-git-send-email-carlo@zancanaro.id.au>
	<1465778333-19689-1-git-send-email-carlo@zancanaro.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bCU4Q-0002dZ-EA
	for guix-devel@gnu.org; Mon, 13 Jun 2016 11:46:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bCU4M-0007Xr-OP
	for guix-devel@gnu.org; Mon, 13 Jun 2016 11:46:34 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38738)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bCU4L-0007V8-Az
	for guix-devel@gnu.org; Mon, 13 Jun 2016 11:46:30 -0400
Content-Disposition: inline
In-Reply-To: <1465778333-19689-1-git-send-email-carlo@zancanaro.id.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: guix-devel@gnu.org

On Mon, Jun 13, 2016 at 10:38:53AM +1000, Carlo Zancanaro wrote:
> * gnu/packages/awesome.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

Thanks for this patch!

> +              ("imagemagick" ,imagemagick)))

I think that imagemagick is only required while building, so it can be a
'native-input'.

You can check what packages the built output refers to: $ guix gc
--references $(./pre-inst-env guix build awesome)

Imagemagick is not in the list.

> +    (license license:gpl2)

I noticed that several of the files have the "or later" text. If they
are all like that, we could use gpl2+. Did you check if there are any
files with licenses besides GPL2+?