From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH] gnu: Add awesome.
Date: Mon, 13 Jun 2016 09:53:31 +0200
Message-ID: <20160613095331.76d99012@scratchpost.org>
References: <1465776755-16444-1-git-send-email-carlo@zancanaro.id.au>
	<1465778333-19689-1-git-send-email-carlo@zancanaro.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52471)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bCMgv-0003oR-EC
	for guix-devel@gnu.org; Mon, 13 Jun 2016 03:53:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bCMgr-0004A3-AX
	for guix-devel@gnu.org; Mon, 13 Jun 2016 03:53:48 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:47427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bCMgr-00049r-3K
	for guix-devel@gnu.org; Mon, 13 Jun 2016 03:53:45 -0400
In-Reply-To: <1465778333-19689-1-git-send-email-carlo@zancanaro.id.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: guix-devel@gnu.org

Hi,

thanks for the patch.

I think it would be better if it went into wm.scm . 

> +    (arguments `(#:phases (modify-phases %standard-phases
> +                            (replace 'check
> +                              (lambda* _
> +                                (zero? (system* "../build/awesome" "-v")))))))

What's up with the tests? Why disable them like this?