From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH 02/14] gnu: Add qtimageformats.
Date: Sun, 12 Jun 2016 16:12:21 +0200
Message-ID: <20160612141221.GA20207@solar>
References: <20160610121025.6632-1-efraim@flashner.co.il>
	<20160610121025.6632-3-efraim@flashner.co.il>
	<20160610163045.GB29669@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33199)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bC67s-0003pJ-GI
	for guix-devel@gnu.org; Sun, 12 Jun 2016 10:12:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bC67n-0005aU-FJ
	for guix-devel@gnu.org; Sun, 12 Jun 2016 10:12:32 -0400
Received: from mailrelay6.public.one.com ([91.198.169.200]:31987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bC67n-0005aL-1N
	for guix-devel@gnu.org; Sun, 12 Jun 2016 10:12:27 -0400
Content-Disposition: inline
In-Reply-To: <20160610163045.GB29669@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

On Fri, Jun 10, 2016 at 12:30:45PM -0400, Leo Famulari wrote:
> On Fri, Jun 10, 2016 at 03:10:13PM +0300, Efraim Flashner wrote:
> > +(define-public qtimageformats
> > +  (package (inherit qtsvg)
> These patches make me realize my understanding of package inheritance is
> unclear.
> 
> If qtsvg is updated, but no other changes are made, will qtimageformats
> (and all the other packages that inherit from qtsvg) need to be rebuilt
> as well?
> 
> Looking at `guix refresh -l` and `guix gc --references` suggests the
> answer is "no".

My understanding is that not the package definition, but the derivation
counts. So for instance, if the version is increased in qtsvg, this new
version also appears in qtimageformats, but if it is set back there, not
even the package definition has changed.

So this should be safe; in a sense, the inheritance from qtsvg creates a
"qt build system"; since this is so far only used internally to build qt
itself, I think it is okay to not expose it to the exterior world.

However, another question: Are all the inputs for qtbase needed for all the
other modules, too, or could the list be trimmed?

Andreas