unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add nethack.
Date: Tue, 7 Jun 2016 13:20:28 -0400	[thread overview]
Message-ID: <20160607172028.GA19231@jasmine> (raw)
In-Reply-To: <20160606162541.5254ed6c@openmailbox.org>

On Mon, Jun 06, 2016 at 04:25:41PM -0400, Kei Kebreau wrote:
> ludo@gnu.org (Ludovic Courtès) wrote:
> > > +         (add-after 'move-state-files 'wrap-program
> > 
> > Do we really need this wrapper?  Can’t we instead take it as a patch
> > from Debian or something?  I’m not a fan of inline Bash code, and not
> > very confident of scripts that do ‘rm -rf’.  :-)
> > 
> Unfortunately, Debian doesn't have any related patches because it's
> state files are writable in the equivalent of our store directories. It
> seems like the bash script will have to stay for the sake of
> functionality unless someone comes up with something cleaner, though I
> prefer to avoid them. Long ago, I lost a GNU/Linux installation to
> "rm -rf"...

If Nethack lacks the ability to configure the location of the state
files, there is still a string (or several) in the source code that
looks like '/usr/share/nethack'. I think we should change this string to
something more appropriate instead of wrapping Nethack.

  reply	other threads:[~2016-06-07 17:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 21:56 [PATCH] gnu: Add nethack Kei Kebreau
2016-06-04 21:15 ` Ludovic Courtès
2016-06-06 20:25   ` Kei Kebreau
2016-06-07 17:20     ` Leo Famulari [this message]
2016-06-08 12:59       ` Ludovic Courtès
2016-06-08 18:05         ` Kei Kebreau
2016-06-08 20:44           ` Leo Famulari
2016-06-09  1:17             ` Kei Kebreau
2016-12-30 21:30               ` Chris Marusich
2016-12-30 21:47                 ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607172028.GA19231@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).