[PATCH 0/5] gnucash: Add AqBanking support.

[PATCH 0/5] gnucash: Add AqBanking support.

[Ricardo Wurmus]

Hi Guix,

this patch set adds AqBanking to Gnucash.  AqBanking adds online banking
support to Gnucash, allowing people with German bank accounts to download
transactions and balances directly from their banks.

~~ Ricardo

Ricardo Wurmus (5):
  gnu: gnucash: Add "license:" prefix.
  gnu: xmlsec: Enable gnutls support.
  gnu: Add gwenhywfar.
  gnu: Add AqBanking.
  gnu: gnucash: Add support for AqBanking.

 gnu/packages/gnucash.scm | 96 ++++++++++++++++++++++++++++++++++++++++++++++--
 gnu/packages/xml.scm     |  7 +++-
 2 files changed, 97 insertions(+), 6 deletions(-)

-- 
2.8.3

[PATCH 1/5] gnu: gnucash: Add "license:" prefix.

[Ricardo Wurmus]

* gnu/packages/gnucash.scm: Import licenses with "license:" prefix.
(gnucash)[license]: Add prefix.
---
 gnu/packages/gnucash.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index 5c0ce4f..c39324c 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015, 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;;
@@ -19,7 +19,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages gnucash)
-  #:use-module (guix licenses)
+  #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
@@ -106,4 +106,4 @@ It can be used to track bank accounts, stocks, income and expenses, based on
 the double-entry accounting practice.  It includes support for QIF/OFX/HBCI
 import and transaction matching.  It also automates several tasks, such as
 financial calculations or scheduled transactions.")
-    (license gpl3+)))
+    (license license:gpl3+)))
-- 
2.8.3

Re: [PATCH 1/5] gnu: gnucash: Add "license:" prefix.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/gnucash.scm: Import licenses with "license:" prefix.
> (gnucash)[license]: Add prefix.

OK!

[PATCH 2/5] gnu: xmlsec: Enable gnutls support.

[Ricardo Wurmus]

* gnu/packages/xml.scm (xmlsec)[native-inputs]: Add pkg-config.
---
 gnu/packages/xml.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index dc5c60d..43072dc 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -3,7 +3,7 @@
 ;;; Copyright © 2013, 2015 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2015 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
-;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015, 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Raimon Grau <raimonster@gmail.com>
@@ -40,7 +40,8 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
-  #:use-module (gnu packages linux))
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages pkg-config))
 
 (define-public expat
   (package
@@ -635,6 +636,8 @@ XSL-T processor.  It also performs any necessary post-processing.")
      `(("gnutls" ,gnutls)
        ("libgcrypt" ,libgcrypt)
        ("libltdl" ,libltdl)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
     (home-page "http://www.libexpat.org/")
     (synopsis "XML Security Library")
     (description
-- 
2.8.3

Re: [PATCH 2/5] gnu: xmlsec: Enable gnutls support.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/xml.scm (xmlsec)[native-inputs]: Add pkg-config.

Good catch.  LGTM!

Ludo’.

[PATCH 3/5] gnu: Add gwenhywfar.

[Ricardo Wurmus]

* gnu/packages/gnucash.scm (gwenhywfar): New variable.
---
 gnu/packages/gnucash.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index c39324c..25801aa 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -25,12 +25,14 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gnupg)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xml))
@@ -107,3 +109,44 @@ the double-entry accounting practice.  It includes support for QIF/OFX/HBCI
 import and transaction matching.  It also automates several tasks, such as
 financial calculations or scheduled transactions.")
     (license license:gpl3+)))
+
+(define-public gwenhywfar
+  (package
+    (name "gwenhywfar")
+    (version "4.15.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.aquamaniac.de/sites/download/download.php?"
+                           "package=01&release=201&file=01&dummy=gwenhywfar-"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0fp67s932x66xfljb26zbrn8ambbc5y5c3hllr6l284nr63qf3ka"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "--disable-network-checks"
+             ;; Both GTK+2 and QT4 are supported.
+             "--with-guis=gtk2"
+             (string-append "--with-openssl-includes="
+                            (assoc-ref %build-inputs "openssl") "/include")
+             (string-append "--with-openssl-libs="
+                            (assoc-ref %build-inputs "openssl") "/lib"))))
+    (inputs
+     `(("libgcrypt" ,libgcrypt)
+       ("gnutls" ,gnutls)
+       ("openssl" ,openssl)
+       ("gtk+" ,gtk+-2)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "http://www.aquamaniac.de/sites/aqbanking/index.php")
+    (synopsis "Utility library for networking and security applications")
+    (description
+     "This package provides a helper library for networking and security
+applications and libraries.  It is used by AqBanking.")
+    ;; The license includes an explicit additional permission to compile and
+    ;; distribute this library with the OpenSSL Toolkit.
+    (license license:lgpl2.1+)))
+
-- 
2.8.3

Re: [PATCH 3/5] gnu: Add gwenhywfar.

[Leo Famulari]

On Mon, Jun 06, 2016 at 03:22:59PM +0200, Ricardo Wurmus wrote:
> * gnu/packages/gnucash.scm (gwenhywfar): New variable.

> +    ;; The license includes an explicit additional permission to compile and
> +    ;; distribute this library with the OpenSSL Toolkit.
> +    (license license:lgpl2.1+)))

Only with OpenSSL, but not any other free software TLS implementations?

Re: [PATCH 3/5] gnu: Add gwenhywfar.

[Ricardo Wurmus]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Jun 06, 2016 at 03:22:59PM +0200, Ricardo Wurmus wrote:
>> * gnu/packages/gnucash.scm (gwenhywfar): New variable.
>
>> +    ;; The license includes an explicit additional permission to compile and
>> +    ;; distribute this library with the OpenSSL Toolkit.
>> +    (license license:lgpl2.1+)))
>
> Only with OpenSSL, but not any other free software TLS implementations?

Yes.  Here’s the relevant section from COPYING:

~~~~~~~~~~~~~~~~~~~~~~~~~~~
Gwenhywfar is licensed under the GNU LGPL (see below) with this exception:

As the copyright holder of Gwenhywfar, Martin Preuss grants the following
license exception:

Martin Preuss explicitly allows the compilation and distribution of
Gwenhywfar with the OpenSSL Toolkit.
No developer is required to provide this exception in a derived work.
~~~~~~~~~~~~~~~~~~~~~~~~~~~

~~ Ricardo

Re: [PATCH 3/5] gnu: Add gwenhywfar.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Mon, Jun 06, 2016 at 05:19:16PM +0200, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Mon, Jun 06, 2016 at 03:22:59PM +0200, Ricardo Wurmus wrote:
> >> * gnu/packages/gnucash.scm (gwenhywfar): New variable.
> >
> >> +    ;; The license includes an explicit additional permission to compile and
> >> +    ;; distribute this library with the OpenSSL Toolkit.
> >> +    (license license:lgpl2.1+)))
> >
> > Only with OpenSSL, but not any other free software TLS implementations?
> 
> Yes.  Here’s the relevant section from COPYING:

offlineimap has a similar openssl exception

> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Gwenhywfar is licensed under the GNU LGPL (see below) with this exception:
> 
> As the copyright holder of Gwenhywfar, Martin Preuss grants the following
> license exception:
> 
> Martin Preuss explicitly allows the compilation and distribution of
> Gwenhywfar with the OpenSSL Toolkit.
> No developer is required to provide this exception in a derived work.
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> ~~ Ricardo
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 3/5] gnu: Add gwenhywfar.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/gnucash.scm (gwenhywfar): New variable.

[...]

> +    (inputs
> +     `(("libgcrypt" ,libgcrypt)
> +       ("gnutls" ,gnutls)
> +       ("openssl" ,openssl)

Do all three libraries show up in ‘guix gc --references’?  In particular
are there programs linked against both OpenSSL and GnuTLS?  That seems a
bit crazy to me, but if it needs to be, then that’s fine!

Otherwise the package LGTM.

Thank you!

Ludo’.

Re: [PATCH 3/5] gnu: Add gwenhywfar.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/gnucash.scm (gwenhywfar): New variable.
>
> [...]
>
>> +    (inputs
>> +     `(("libgcrypt" ,libgcrypt)
>> +       ("gnutls" ,gnutls)
>> +       ("openssl" ,openssl)
>
> Do all three libraries show up in ‘guix gc --references’?  In particular
> are there programs linked against both OpenSSL and GnuTLS?  That seems a
> bit crazy to me, but if it needs to be, then that’s fine!

References to all three libraries are, in fact, retained and they are
reported by “guix gc --references”.

~~ Ricardo

Re: [PATCH 3/5] gnu: Add gwenhywfar.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/gnucash.scm (gwenhywfar): New variable.
>
> [...]
>
>> +    (inputs
>> +     `(("libgcrypt" ,libgcrypt)
>> +       ("gnutls" ,gnutls)
>> +       ("openssl" ,openssl)
>
> Do all three libraries show up in ‘guix gc --references’?  In particular
> are there programs linked against both OpenSSL and GnuTLS?  That seems a
> bit crazy to me, but if it needs to be, then that’s fine!

References to all three libraries are, in fact, retained and they are
reported by “guix gc --references”.

~~ Ricardo

[PATCH 4/5] gnu: Add AqBanking.

[Ricardo Wurmus]

* gnu/packages/gnucash.scm (aqbanking): New variable.
---
 gnu/packages/gnucash.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index 25801aa..06a2261 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -24,12 +24,14 @@
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages icu4c)
+  #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
@@ -150,3 +152,44 @@ applications and libraries.  It is used by AqBanking.")
     ;; distribute this library with the OpenSSL Toolkit.
     (license license:lgpl2.1+)))
 
+(define-public aqbanking
+  (package
+    (name "aqbanking")
+    (version "5.6.10")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.aquamaniac.de/sites/download/download.php?"
+                           "package=03&release=206&file=01&dummy=aqbanking-"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1x0isvpk43rq2zlyyb9p0kgjmqv7yq07vgkiprw3f5sjkykvxw6d"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(;; Parallel building fails because aqhbci is required before it's
+       ;; built.
+       #:parallel-build? #f
+       #:configure-flags
+       (list (string-append "--with-gwen-dir="
+                            (assoc-ref %build-inputs "gwenhywfar")))))
+    (propagated-inputs
+     `(("gwenhywfar" ,gwenhywfar)))
+    (inputs
+     `(("gmp" ,gmp)
+       ("xmlsec" ,xmlsec)
+       ("gnutls" ,gnutls)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("libltdl" ,libltdl)))
+    (home-page "http://www.aquamaniac.de/sites/aqbanking/index.php")
+    (synopsis "Interface for online banking tasks")
+    (description
+     "AqBanking is a modular and generic interface to online banking tasks,
+financial file formats (import/export) and bank/country/currency information.
+AqBanking uses backend plugins to actually perform the online tasks.  HBCI,
+OFX DirectConnect, YellowNet, GeldKarte, and DTAUS discs are currently
+supported.  AqBanking is used by GnuCash, KMyMoney, and QBankManager.")
+    ;; AqBanking is licensed under the GPLv2 or GPLv3
+    (license (list license:gpl2+ license:gpl3+))))
-- 
2.8.3

Re: [PATCH 4/5] gnu: Add AqBanking.

[Leo Famulari]

On Mon, Jun 06, 2016 at 03:23:00PM +0200, Ricardo Wurmus wrote:
> * gnu/packages/gnucash.scm (aqbanking): New variable.

> +    ;; AqBanking is licensed under the GPLv2 or GPLv3
> +    (license (list license:gpl2+ license:gpl3+))))

Should it be (list license:gpl2 license:gpl3) in that case?

Re: [PATCH 4/5] gnu: Add AqBanking.

[Ricardo Wurmus]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Jun 06, 2016 at 03:23:00PM +0200, Ricardo Wurmus wrote:
>> * gnu/packages/gnucash.scm (aqbanking): New variable.
>
>> +    ;; AqBanking is licensed under the GPLv2 or GPLv3
>> +    (license (list license:gpl2+ license:gpl3+))))
>
> Should it be (list license:gpl2 license:gpl3) in that case?

Yes, I think you are right.

~~ Ricardo

Re: [PATCH 4/5] gnu: Add AqBanking.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/gnucash.scm (aqbanking): New variable.

Nothing to add to what Leo wrote.  :-)

[PATCH 5/5] gnu: gnucash: Add support for AqBanking.

[Ricardo Wurmus]

* gnu/packages/gnucash.scm (gnucash)[inputs]: Add aqbanking.
[arguments]: Add configure flag to enable aqbanking.
---
 gnu/packages/gnucash.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index 06a2261..5bac5a1 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -63,6 +63,7 @@
        ("libxml2" ,libxml2)
        ("libxslt" ,libxslt)
        ("webkitgtk" ,webkitgtk/gtk+-2)
+       ("aqbanking" ,aqbanking)
        ("perl-date-manip" ,perl-date-manip)
        ("perl-finance-quote" ,perl-finance-quote)))
     (native-inputs
@@ -71,7 +72,8 @@
        ("pkg-config" ,pkg-config)))
     (arguments
      `(#:tests? #f ;FIXME: failing at /qof/gnc-date/qof print date dmy buff
-       #:configure-flags '("--disable-dbi")
+       #:configure-flags '("--disable-dbi"
+                           "--enable-aqbanking")
        #:phases
        (modify-phases %standard-phases
          (add-after
-- 
2.8.3

Re: [PATCH 5/5] gnu: gnucash: Add support for AqBanking.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/gnucash.scm (gnucash)[inputs]: Add aqbanking.
> [arguments]: Add configure flag to enable aqbanking.

LGTM!

Thanks,
Ludo'.