From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add googletest
Date: Wed, 1 Jun 2016 21:49:44 -0400
Message-ID: <20160602014944.GB31306@jasmine>
References: <874m9fwa0k.fsf@openmailbox.org> <87lh2q2v1u.fsf@openmailbox.org>
	<20160531214400.GA22303@jasmine> <87twhdez33.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b8Hlp-0005ZP-Hz
	for guix-devel@gnu.org; Wed, 01 Jun 2016 21:50:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b8Hlj-0002nS-OO
	for guix-devel@gnu.org; Wed, 01 Jun 2016 21:50:00 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b8Hli-0002n0-HO
	for guix-devel@gnu.org; Wed, 01 Jun 2016 21:49:55 -0400
Content-Disposition: inline
In-Reply-To: <87twhdez33.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org

On Wed, Jun 01, 2016 at 09:57:53AM -0500, Lukas Gradl wrote:
> Leo Famulari <leo@famulari.name> writes:
> > I noticed in the README.md that upstream suggests use of GNU Make unless
> > building from a Git checkout. Did you try that?
> 
> I have not tried that.  Their README.md left me under the impression
> that tests are not supported useing GNU Make, but I just looked at their
> Makefile and there are test targets, so I can try using the
> gnu-build-system, if that is preferred?

All else being equal, my personal preference is to use GNU tools. But
otherwise, we should use the build system that upstream supports most
fully. Especially, we should use the one that runs the tests.

> It seems they generate c++ header files using pump.py.  I will look into
> that more.  Python is also needed for tests.

Thanks for looking into that. If the header files are generated by other
code, then we prefer to build them ourselves rather than use the
"pre-compiled" headers.