[PATCH 01/10] gnu: Add emacs-smex.

[PATCH 01/10] gnu: Add emacs-smex.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-smex): New variable.
---
 gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index b7c0a1f..71f2f8b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;; Copyright © 2016 humanitiesNerd <catonano@gmail.com>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 David Thompson <davet@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
 Emacs default configuration in uncontroversial ways that nearly everyone can
 agree upon.")
     (license license:gpl3+)))
+
+(define-public emacs-smex
+  (package
+    (name "emacs-smex")
+    (version "3.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com"
+                                  "/nonsequitur/smex/" version "/smex.el"))
+              (file-name (string-append "smex-" version ".el"))
+              (sha256
+               (base32
+                "0ar310zx9k5y4i1vl2rawvi712xj9gx77160860jbs691p77cxqp"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/nonsequitur/smex/")
+    (synopsis "M-x interface with Ido-style fuzzy matching")
+    (description
+     "Smex is a M-x enhancement for Emacs.  Built on top of Ido, it provides a
+convenient interface to your recently and most frequently used commands.  And
+to all the other commands, too.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 02/10] gnu: Add emacs-js2-mode.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-js2-mode): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 71f2f8b..cad843c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1817,3 +1817,26 @@ agree upon.")
 convenient interface to your recently and most frequently used commands.  And
 to all the other commands, too.")
     (license license:gpl3+)))
+
+(define-public emacs-js2-mode
+  (package
+    (name "emacs-js2-mode")
+    (version "20150909")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/mooz/js2-mode/archive/"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1nsm36c4kwb473p13i58fgrnlk8fbn3rdhj47d9xz70az4ra44q0"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/mooz/js2-mode/")
+    (synopsis "Improved JavaScript editing mode for Emacs")
+    (description
+     "Js2-mode provides a JavaScript major mode for Emacs that is more
+advanced than the built-in javascript-mode.  Features include accurate syntax
+highlighting using a recursive-descent parser, on-the-fly reporting of syntax
+errors and strict-mode warnings, smart line-wrapping within comments and
+strings, and code folding.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 03/10] gnu: Add emacs-markdown-mode.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-markdown-mode): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cad843c..cd64383 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1840,3 +1840,24 @@ highlighting using a recursive-descent parser, on-the-fly reporting of syntax
 errors and strict-mode warnings, smart line-wrapping within comments and
 strings, and code folding.")
     (license license:gpl3+)))
+
+(define-public emacs-markdown-mode
+  (package
+    (name "emacs-markdown-mode")
+    (version "2.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com/jrblevin"
+                                  "/markdown-mode/v" version
+                                  "/markdown-mode.el"))
+              (file-name (string-append "markdown-mode-" version ".el"))
+              (sha256
+               (base32
+                "1faibar32jnjia9202swblw91q6z1g5s4k9xmypwjahfh8yznl6w"))))
+    (build-system emacs-build-system)
+    (home-page "http://jblevins.org/projects/markdown-mode/")
+    (synopsis "Emacs Major mode for Markdown files")
+    (description
+     "Markdown-mode is a major mode for editing Markdown-formatted text files
+in Emacs.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 04/10] gnu: Add emacs-projectile.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-projectile): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cd64383..1b54439 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1861,3 +1861,29 @@ strings, and code folding.")
      "Markdown-mode is a major mode for editing Markdown-formatted text files
 in Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-projectile
+  (package
+    (name "emacs-projectile")
+    (version "0.13.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com/bbatsov"
+                                  "/projectile/v" version "/projectile.el"))
+              (file-name (string-append "projectile-" version ".el"))
+              (sha256
+               (base32
+                "1pc6xb61hzxzc5hkqkli1ab0s7wz0rfgx4kcn9y30ksvhw18smbz"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-pkg-info" ,emacs-pkg-info)))
+    (home-page "https://github.com/bbatsov/projectile")
+    (synopsis "Manage and navigate projects in Emacs easily")
+    (description
+     "This library provides easy project management and navigation.  The
+concept of a project is pretty basic - just a folder containing special file.
+Currently git, mercurial and bazaar repos are considered projects by default.
+If you want to mark a folder manually as a project just create an empty
+.projectile file in it.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 05/10] gnu: Add emacs-elfeed.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/pacakges/emacs.scm (emacs-elfeed): New variable.
---
 gnu/packages/emacs.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 1b54439..04dc759 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1887,3 +1887,23 @@ Currently git, mercurial and bazaar repos are considered projects by default.
 If you want to mark a folder manually as a project just create an empty
 .projectile file in it.")
     (license license:gpl3+)))
+
+(define-public emacs-elfeed
+  (package
+    (name "emacs-elfeed")
+    (version "1.4.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/skeeto/elfeed/archive/"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0i75r8x9ypbfjlnym04h16ikcrlks86p7wsgawrx7mh1lk4inp89"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/skeeto/elfeed")
+    (synopsis "Atom/RSS feed reader for Emacs")
+    (description
+     "Elfeed is an extensible web feed reader for Emacs, supporting both Atom
+and RSS, with a user interface inspired by notmuch.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 06/10] gnu: Add emacs-rainbow-delimiters.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-rainbow-delimiters): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 04dc759..54885f4 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1907,3 +1907,27 @@ If you want to mark a folder manually as a project just create an empty
      "Elfeed is an extensible web feed reader for Emacs, supporting both Atom
 and RSS, with a user interface inspired by notmuch.")
     (license license:gpl3+)))
+
+(define-public emacs-rainbow-delimiters
+  (package
+    (name "emacs-rainbow-delimiters")
+    (version "2.1.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com/Fanael"
+                                  "/rainbow-delimiters/" version
+                                  "/rainbow-delimiters.el"))
+              (file-name (string-append "rainbow-delimiters-" version ".el"))
+              (sha256
+               (base32
+                "1b3kampwsjabhcqdp0khgff13wc5jqhy3rbvaa12vnv7qy22l9ck"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/Fanael/rainbow-delimiters")
+    (synopsis "Highlight brackets according to their depth")
+    (description
+     "Rainbow-delimiters is a \"rainbow parentheses\"-like mode for Emacs which
+highlights parentheses, brackets, and braces according to their depth.  Each
+successive level is highlighted in a different color, making it easy to spot
+matching delimiters, orient yourself in the code, and tell which statements
+are at a given level.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 07/10] gnu: Add emacs-ido-completing-read+.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-ido-completing-read+): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 54885f4..ee875ef 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1931,3 +1931,26 @@ successive level is highlighted in a different color, making it easy to spot
 matching delimiters, orient yourself in the code, and tell which statements
 are at a given level.")
     (license license:gpl3+)))
+
+(define-public emacs-ido-completing-read+
+  (package
+    (name "emacs-ido-completing-read+")
+    (version "3.12")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com"
+                                  "/DarwinAwardWinner/ido-ubiquitous/v"
+                                  version "/ido-completing-read+.el"))
+              (file-name (string-append "ido-completing-read+-" version ".el"))
+              (sha256
+               (base32
+                "1cyalb0p7nfsm4n6n9q6rjmvn6adqc0fq8ybnlj3n41n289dkfjf"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
+    (synopsis "Replacement for completing-read using ido")
+    (description
+     "The ido-completing-read+ function is a wrapper for ido-completing-read.
+Importantly, it detects edge cases that ordinary ido cannot handle and either
+adjusts them so ido can handle them, or else simply falls back to the standard
+Emacs completion function instead.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 08/10] gnu: Add emacs-ido-ubiquitous.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-ido-ubiquitous): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ee875ef..0ea317a 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1954,3 +1954,26 @@ Importantly, it detects edge cases that ordinary ido cannot handle and either
 adjusts them so ido can handle them, or else simply falls back to the standard
 Emacs completion function instead.")
     (license license:gpl3+)))
+
+(define-public emacs-ido-ubiquitous
+  (package
+    (name "emacs-ido-ubiquitous")
+    (version "3.12")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com"
+                                  "/DarwinAwardWinner/ido-ubiquitous/v"
+                                  version "/ido-ubiquitous.el"))
+              (file-name (string-append "ido-ubiquitous-" version ".el"))
+              (sha256
+               (base32
+                "197ypji0fb6jsdcq40rpnknwlh3imas6s6jbsvkfm0pz9988c3q2"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)))
+    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
+    (synopsis "Use ido (nearly) everywhere")
+    (description
+     "Ido-ubiquitous enables ido-style completion for almost every function
+that uses the standard completion function completing-read.")
+  (license license:gpl3+)))
-- 
2.8.3

[PATCH 09/10] gnu: Add emacs-yaml-mode.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-yaml-mode): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 0ea317a..bfa46c4 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1977,3 +1977,26 @@ Emacs completion function instead.")
      "Ido-ubiquitous enables ido-style completion for almost every function
 that uses the standard completion function completing-read.")
   (license license:gpl3+)))
+
+(define-public emacs-yaml-mode
+  (package
+    (name "emacs-yaml-mode")
+    (version "0.0.12")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com/yoshiki"
+                                  "/yaml-mode/v" version "/yaml-mode.el"))
+              (file-name (string-append "yaml-mode-" version ".el"))
+              (sha256
+               (base32
+                "05zbb7l5j0jhn1z65lhy1f6yf77rd3rsf5ayvwm5a6dfkhr9zwnm"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/yoshiki/yaml-mode")
+    (synopsis "Major mode for editing YAML files")
+    (description
+     "Yaml-mode is an Emacs major mode for editing files in the YAML data
+serialization format.  It was initially developed by Yoshiki Kurihara and many
+features were added by Marshall Vandegrift.  As YAML and Python share the fact
+that indentation determines structure, this mode provides indentation and
+indentation command behavior very similar to that of python-mode.")
+    (license license:gpl3+)))
-- 
2.8.3

[PATCH 10/10] gnu: Add emacs-web-mode.

[David Thompson]

From: David Thompson <davet@gnu.org>

* gnu/packages/emacs.scm (emacs-web-mode): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index bfa46c4..95e6bea 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2000,3 +2000,26 @@ features were added by Marshall Vandegrift.  As YAML and Python share the fact
 that indentation determines structure, this mode provides indentation and
 indentation command behavior very similar to that of python-mode.")
     (license license:gpl3+)))
+
+(define-public emacs-web-mode
+  (package
+    (name "emacs-web-mode")
+    (version "14")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://raw.githubusercontent.com/fxbois"
+                                  "/web-mode/v" version "/web-mode.el"))
+              (file-name (string-append "web-mode-" version ".el"))
+              (sha256
+               (base32
+                "086hik5fmxg3kx74qmransx9cz961qd22d4m6ah2dw6cwaj1s3s5"))))
+    (build-system emacs-build-system)
+    (synopsis "Major mode for editing web templates")
+    (description "Web-mode is an Emacs major mode for editing web templates
+aka HTML files embedding parts (CSS/JavaScript) and blocks (pre rendered by
+client/server side engines).  Web-mode is compatible with many template
+engines: PHP, JSP, ASP, Django, Twig, Jinja, Mustache, ERB, FreeMarker,
+Velocity, Cheetah, Smarty, CTemplate, Mustache, Blade, ErlyDTL, Go Template,
+Dust.js, React/JSX, Angularjs, ejs, etc.")
+    (home-page "http://web-mode.org/")
+    (license license:gpl3+)))
-- 
2.8.3

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Alex Kost]

David Thompson (2016-06-01 17:05 +0300) wrote:

> From: David Thompson <davet@gnu.org>
>
> * gnu/packages/emacs.scm (emacs-smex): New variable.
> ---
>  gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index b7c0a1f..71f2f8b 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -10,6 +10,7 @@
>  ;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
>  ;;; Copyright © 2016 humanitiesNerd <catonano@gmail.com>
>  ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2016 David Thompson <davet@gnu.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>  Emacs default configuration in uncontroversial ways that nearly everyone can
>  agree upon.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-smex
> +  (package
> +    (name "emacs-smex")
> +    (version "3.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://raw.githubusercontent.com"
> +                                  "/nonsequitur/smex/" version "/smex.el"))

Hm, I see in some packages you use these "githubusercontent" URLs
instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
we usually do for github.  IIUC you did it to avoid extra files
(".gitignore", etc.) in the final package directory, right?  If so, I
think it is not needed, I would still use a link to a tagged source code
archive.  Moreover I think it's a problem of emacs-build-system that
these uninteresting files are not removed.

Overall, I don't mind against "githubusercontent", I was just wondering.
Actually, I think you found a good way how to pick the needed files to
make several packages from a single repo (as you did for
"ido-ubiquitous" and "ido-completing-read+").

> +              (file-name (string-append "smex-" version ".el"))
> +              (sha256
> +               (base32
> +                "0ar310zx9k5y4i1vl2rawvi712xj9gx77160860jbs691p77cxqp"))))
> +    (build-system emacs-build-system)
> +    (home-page "http://github.com/nonsequitur/smex/")
> +    (synopsis "M-x interface with Ido-style fuzzy matching")
> +    (description
> +     "Smex is a M-x enhancement for Emacs.  Built on top of Ido, it provides a
> +convenient interface to your recently and most frequently used commands.  And
> +to all the other commands, too.")
> +    (license license:gpl3+)))

-- 
Alex

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Thompson, David]

On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost <alezost@gmail.com> wrote:
> David Thompson (2016-06-01 17:05 +0300) wrote:
>
>> From: David Thompson <davet@gnu.org>
>>
>> * gnu/packages/emacs.scm (emacs-smex): New variable.
>> ---
>>  gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index b7c0a1f..71f2f8b 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -10,6 +10,7 @@
>>  ;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
>>  ;;; Copyright © 2016 humanitiesNerd <catonano@gmail.com>
>>  ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
>> +;;; Copyright © 2016 David Thompson <davet@gnu.org>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>>  Emacs default configuration in uncontroversial ways that nearly everyone can
>>  agree upon.")
>>      (license license:gpl3+)))
>> +
>> +(define-public emacs-smex
>> +  (package
>> +    (name "emacs-smex")
>> +    (version "3.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://raw.githubusercontent.com"
>> +                                  "/nonsequitur/smex/" version "/smex.el"))
>
> Hm, I see in some packages you use these "githubusercontent" URLs
> instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
> we usually do for github.  IIUC you did it to avoid extra files
> (".gitignore", etc.) in the final package directory, right?  If so, I
> think it is not needed, I would still use a link to a tagged source code
> archive.  Moreover I think it's a problem of emacs-build-system that
> these uninteresting files are not removed.
>
> Overall, I don't mind against "githubusercontent", I was just wondering.
> Actually, I think you found a good way how to pick the needed files to
> make several packages from a single repo (as you did for
> "ido-ubiquitous" and "ido-completing-read+").

Yes, I did this to avoid all sorts of unnecessary files making into
the store, as well as making it more closely mimic the single elisp
files that were released on MELPA or whatever.  These URLs are stable,
so I thought it had a good clever/useful hack ratio. :)

- Dave

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Ludovic Courtès]

"Thompson, David" <dthompson2@worcester.edu> skribis:

> On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost <alezost@gmail.com> wrote:
>> David Thompson (2016-06-01 17:05 +0300) wrote:
>>
>>> From: David Thompson <davet@gnu.org>
>>>
>>> * gnu/packages/emacs.scm (emacs-smex): New variable.
>>> ---
>>>  gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>>>  1 file changed, 22 insertions(+)
>>>
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index b7c0a1f..71f2f8b 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -10,6 +10,7 @@
>>>  ;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
>>>  ;;; Copyright © 2016 humanitiesNerd <catonano@gmail.com>
>>>  ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
>>> +;;; Copyright © 2016 David Thompson <davet@gnu.org>
>>>  ;;;
>>>  ;;; This file is part of GNU Guix.
>>>  ;;;
>>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>>>  Emacs default configuration in uncontroversial ways that nearly everyone can
>>>  agree upon.")
>>>      (license license:gpl3+)))
>>> +
>>> +(define-public emacs-smex
>>> +  (package
>>> +    (name "emacs-smex")
>>> +    (version "3.0")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append "https://raw.githubusercontent.com"
>>> +                                  "/nonsequitur/smex/" version "/smex.el"))
>>
>> Hm, I see in some packages you use these "githubusercontent" URLs
>> instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
>> we usually do for github.  IIUC you did it to avoid extra files
>> (".gitignore", etc.) in the final package directory, right?  If so, I
>> think it is not needed, I would still use a link to a tagged source code
>> archive.  Moreover I think it's a problem of emacs-build-system that
>> these uninteresting files are not removed.
>>
>> Overall, I don't mind against "githubusercontent", I was just wondering.
>> Actually, I think you found a good way how to pick the needed files to
>> make several packages from a single repo (as you did for
>> "ido-ubiquitous" and "ido-completing-read+").
>
> Yes, I did this to avoid all sorts of unnecessary files making into
> the store, as well as making it more closely mimic the single elisp
> files that were released on MELPA or whatever.  These URLs are stable,
> so I thought it had a good clever/useful hack ratio. :)

I think the downside is that the GitHub updater won’t be able to
identify these, although I’m not 100% sure of that.

Anyway, since the URLs are stable, it’s OK.

Thanks,
Ludo’.

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Ludovic Courtès]

Hi!

I skimmed over these patches, and apart from the question regarding the
GitHub updater vs. githubusercontent.com, they LGTM.

Thanks!

Ludo’.

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Ben Woodcroft]

On 06/03/2016 06:14 PM, Ludovic Courtès wrote:
> "Thompson, David" <dthompson2@worcester.edu> skribis:
>
>> On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost <alezost@gmail.com> wrote:
>>> David Thompson (2016-06-01 17:05 +0300) wrote:
>>>
>>>> From: David Thompson <davet@gnu.org>
>>>>
>>>> * gnu/packages/emacs.scm (emacs-smex): New variable.
>>>> ---
>>>>   gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>>>>   1 file changed, 22 insertions(+)
>>>>
>>>>
>>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>>> index b7c0a1f..71f2f8b 100644
>>>> --- a/gnu/packages/emacs.scm
>>>> +++ b/gnu/packages/emacs.scm
>>>> @@ -10,6 +10,7 @@
>>>>   ;;; Copyright © 2015, 2016 Christopher Allan Webber <cwebber@dustycloud.org>
>>>>   ;;; Copyright © 2016 humanitiesNerd <catonano@gmail.com>
>>>>   ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
>>>> +;;; Copyright © 2016 David Thompson <davet@gnu.org>
>>>>   ;;;
>>>>   ;;; This file is part of GNU Guix.
>>>>   ;;;
>>>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>>>>   Emacs default configuration in uncontroversial ways that nearly everyone can
>>>>   agree upon.")
>>>>       (license license:gpl3+)))
>>>> +
>>>> +(define-public emacs-smex
>>>> +  (package
>>>> +    (name "emacs-smex")
>>>> +    (version "3.0")
>>>> +    (source (origin
>>>> +              (method url-fetch)
>>>> +              (uri (string-append "https://raw.githubusercontent.com"
>>>> +                                  "/nonsequitur/smex/" version "/smex.el"))
>>> Hm, I see in some packages you use these "githubusercontent" URLs
>>> instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
>>> we usually do for github.  IIUC you did it to avoid extra files
>>> (".gitignore", etc.) in the final package directory, right?  If so, I
>>> think it is not needed, I would still use a link to a tagged source code
>>> archive.  Moreover I think it's a problem of emacs-build-system that
>>> these uninteresting files are not removed.
>>>
>>> Overall, I don't mind against "githubusercontent", I was just wondering.
>>> Actually, I think you found a good way how to pick the needed files to
>>> make several packages from a single repo (as you did for
>>> "ido-ubiquitous" and "ido-completing-read+").
>> Yes, I did this to avoid all sorts of unnecessary files making into
>> the store, as well as making it more closely mimic the single elisp
>> files that were released on MELPA or whatever.  These URLs are stable,
>> so I thought it had a good clever/useful hack ratio. :)
> I think the downside is that the GitHub updater won’t be able to
> identify these, although I’m not 100% sure of that.

I haven't actually tested but I would think that is right Ludo. However, 
I expect this issue is solvable with modifications to the GitHub updater.

ben

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Thompson, David]

On Fri, Jun 3, 2016 at 4:16 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi!
>
> I skimmed over these patches, and apart from the question regarding the
> GitHub updater vs. githubusercontent.com, they LGTM.

Thanks, I've pushed the patches.  If githubusercontent.com becomes a
problem we can change them back.

- Dave

Re: [PATCH 09/10] gnu: Add emacs-yaml-mode.

[Mark H Weaver]

David Thompson <dthompson2@worcester.edu> writes:
> * gnu/packages/emacs.scm (emacs-yaml-mode): New variable.

Hydra failed to build this one, because of a hash mismatch.

  http://hydra.gnu.org/build/1223022

  Starting download of
  /gnu/store/lky7x8fw5rd6h28x3xrwlqwjbyj0lss9-yaml-mode-0.0.12.el From
  https://raw.githubusercontent.com/yoshiki/yaml-mode/v0.0.12/yaml-mode.el...

  [...]

  Failed: output path
  `/gnu/store/lky7x8fw5rd6h28x3xrwlqwjbyj0lss9-yaml-mode-0.0.12.el'
  should have sha256 hash
  `05zbb7l5j0jhn1z65lhy1f6yf77rd3rsf5ayvwm5a6dfkhr9zwnm', instead has
  `17wq433ycli0qx4gdhgrmb392qblm6y2dwcyn38j5ja1lasfb0ax'

Can you investigate?

     Thanks!
       Mark
       

> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 0ea317a..bfa46c4 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1977,3 +1977,26 @@ Emacs completion function instead.")
>       "Ido-ubiquitous enables ido-style completion for almost every function
>  that uses the standard completion function completing-read.")
>    (license license:gpl3+)))
> +
> +(define-public emacs-yaml-mode
> +  (package
> +    (name "emacs-yaml-mode")
> +    (version "0.0.12")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://raw.githubusercontent.com/yoshiki"
> +                                  "/yaml-mode/v" version "/yaml-mode.el"))
> +              (file-name (string-append "yaml-mode-" version ".el"))
> +              (sha256
> +               (base32
> +                "05zbb7l5j0jhn1z65lhy1f6yf77rd3rsf5ayvwm5a6dfkhr9zwnm"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/yoshiki/yaml-mode")
> +    (synopsis "Major mode for editing YAML files")
> +    (description
> +     "Yaml-mode is an Emacs major mode for editing files in the YAML data
> +serialization format.  It was initially developed by Yoshiki Kurihara and many
> +features were added by Marshall Vandegrift.  As YAML and Python share the fact
> +that indentation determines structure, this mode provides indentation and
> +indentation command behavior very similar to that of python-mode.")
> +    (license license:gpl3+)))

Re: [PATCH 09/10] gnu: Add emacs-yaml-mode.

[Thompson, David]

On Fri, Jun 3, 2016 at 11:37 AM, Mark H Weaver <mhw@netris.org> wrote:
> David Thompson <dthompson2@worcester.edu> writes:
>> * gnu/packages/emacs.scm (emacs-yaml-mode): New variable.
>
> Hydra failed to build this one, because of a hash mismatch.
>
>   http://hydra.gnu.org/build/1223022
>
>   Starting download of
>   /gnu/store/lky7x8fw5rd6h28x3xrwlqwjbyj0lss9-yaml-mode-0.0.12.el From
>   https://raw.githubusercontent.com/yoshiki/yaml-mode/v0.0.12/yaml-mode.el...
>
>   [...]
>
>   Failed: output path
>   `/gnu/store/lky7x8fw5rd6h28x3xrwlqwjbyj0lss9-yaml-mode-0.0.12.el'
>   should have sha256 hash
>   `05zbb7l5j0jhn1z65lhy1f6yf77rd3rsf5ayvwm5a6dfkhr9zwnm', instead has
>   `17wq433ycli0qx4gdhgrmb392qblm6y2dwcyn38j5ja1lasfb0ax'
>
> Can you investigate?

I updated the hash.  Thanks!

- Dave

Re: [PATCH 01/10] gnu: Add emacs-smex.

[Ludovic Courtès]

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 06/03/2016 06:14 PM, Ludovic Courtès wrote:

[...]

>> I think the downside is that the GitHub updater won’t be able to
>> identify these, although I’m not 100% sure of that.
>
> I haven't actually tested but I would think that is right
> Ludo.

Indeed:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(guix upstream)
scheme@(guile-user)> ,use(guix import github)
scheme@(guile-user)> ,use(gnu packages emacs)
scheme@(guile-user)> (package-update-path emacs-smex (list %github-updater))
$2 = #f
scheme@(guile-user)> ((upstream-updater-latest %github-updater) emacs-smex)
$3 = #f
scheme@(guile-user)> ((upstream-updater-predicate %github-updater) emacs-smex)
$4 = #f
--8<---------------cut here---------------end--------------->8---

> However, I expect this issue is solvable with modifications to the
> GitHub updater.

Yeah, we should probably do it eventually.

Thanks for your feedback,
Ludo’.