From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] Add googletest Date: Wed, 1 Jun 2016 07:48:29 +0300 Message-ID: <20160601044829.GA20978@debian-netbook> References: <874m9fwa0k.fsf@openmailbox.org> <87lh2q2v1u.fsf@openmailbox.org> <20160531214400.GA22303@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7y5G-0006KF-VO for guix-devel@gnu.org; Wed, 01 Jun 2016 00:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7y5D-0002io-Pq for guix-devel@gnu.org; Wed, 01 Jun 2016 00:48:46 -0400 Received: from flashner.co.il ([178.62.234.194]:50408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7y5D-0002cZ-EL for guix-devel@gnu.org; Wed, 01 Jun 2016 00:48:43 -0400 Content-Disposition: inline In-Reply-To: <20160531214400.GA22303@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 31, 2016 at 05:44:00PM -0400, Leo Famulari wrote: > On Tue, May 31, 2016 at 08:53:17AM -0500, Lukas Gradl wrote: > > * gnu/packages/check.scm (googletest): New variable. >=20 > Awesome, thanks for this patch! >=20 > > + (build-system cmake-build-system) >=20 > I noticed in the README.md that upstream suggests use of GNU Make unless > building from a Git checkout. Did you try that? >=20 > > + (native-inputs > > + `(("python-2" ,python-2))) >=20 > The README also suggests that this is only necessary for building from > Git, although it's worth finding out what they mean by "re-generating > certain source files from templates". We prefer to re-build "generated" > source files since they are not really "source files" in many cases. >=20 > > + (replace 'install > > + (lambda _ > > + (let ((out (assoc-ref %outputs "out"))) > > + (and > > + (mkdir-p (string-append out "/lib")) > > + (mkdir-p (string-append out "/include")) > > + (zero? > > + (system* "cp" "-r" > > + "../googletest-release-1.7.0/includ= e" > > + out)) > > + (zero? (system* "cp" "libgtest.a" "libgtest_m= ain.a" > > + (string-append out "/lib"))))= )))))) >=20 > I think these uses of (system*) could be replaced by (copy-recursively) > and (install-file), respectively. >=20 I haven't tried building this package yet (and -> you can probably switch this for a (begin googletest-release-1.7.0 -> (string-append "../google-release-" version "/include") (zero? (system* "cp" "libgtest.a" "libgtest_main.a" won't this just copy libgtest.a to libgtest_main.a ? --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXTmkcAAoJEPTB05F+rO6T3AwQAJaURiCxcuQKTpTTTUoFkIhO iz2JARCXDQ8KaWQvnI/YVhuwCTvboVJJlZCz4o3YVATqOw6ooOCLTBot3/8BXgqx 3sbPNSiyfL3SkF/bzLYNbzuZdMKmMWaD5Nv1EUebh+2gDuv+oJMhRSBLGvrxZjM/ 3t7rygRXso+zgKdaymBjSQSQwjFcszAJNZol3ysEfBHM0J6ATySey5x8oGmq4M6s 7halkM8czJUe/e1NnU2ehAtRbio9NewNJSBnxF7TNvclqwPD6aB8CHFm/iij079Z BkdwWmjDxJU4cqn0jp/Ff8xVvsGXurfY2Z9IcVK8HZ5GLQ6Z2nuAmEw9Y8IUOTVU krB5+65Fz2EYBQCWMj5Qx/cpBPVzxwRq7AmUwhf6RuPpRDPbBAp4CTM9bxpYVUMs rN3g/TCJUCOLPyDE6AfxkJSeggsRMinn/i/CecnkAuieJPyII+6q8ijSaMGDjLJL 1HSVkEb7EQ6WqFsJ3QsxPBVWztuu9xl4rzcmTXKTJEZQo1zJdwJ8oGZsgX3MlGu2 PkbYX4JaYgsED99K+9RzSw+FDJlcwUH0tE13GDuyHH4XfcL7T0xqUtbs94ALcqQ9 t5T2KU42Bc3FiAGgn6uWgWWQmbk1jZ9PnLAFqcN37jmw4KRykJR/opCrPWYaPVPI Xb+FVMIWQkujcu4L676V =bi7D -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--