From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add googletest
Date: Tue, 31 May 2016 17:44:00 -0400
Message-ID: <20160531214400.GA22303@jasmine>
References: <874m9fwa0k.fsf@openmailbox.org> <87lh2q2v1u.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b7rSR-0003D6-3I
	for guix-devel@gnu.org; Tue, 31 May 2016 17:44:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b7rSN-0003Om-9d
	for guix-devel@gnu.org; Tue, 31 May 2016 17:44:13 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52146)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b7rSL-0003M0-8Q
	for guix-devel@gnu.org; Tue, 31 May 2016 17:44:11 -0400
Content-Disposition: inline
In-Reply-To: <87lh2q2v1u.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org

On Tue, May 31, 2016 at 08:53:17AM -0500, Lukas Gradl wrote:
> * gnu/packages/check.scm (googletest): New variable.

Awesome, thanks for this patch!

> +    (build-system cmake-build-system)

I noticed in the README.md that upstream suggests use of GNU Make unless
building from a Git checkout. Did you try that?

> +    (native-inputs
> +     `(("python-2" ,python-2)))

The README also suggests that this is only necessary for building from
Git, although it's worth finding out what they mean by "re-generating
certain source files from templates". We prefer to re-build "generated"
source files since they are not really "source files" in many cases.

> +                  (replace 'install
> +                    (lambda _
> +                      (let ((out (assoc-ref %outputs "out")))
> +                        (and
> +                         (mkdir-p (string-append out "/lib"))
> +                         (mkdir-p (string-append out "/include"))
> +                         (zero?
> +                          (system* "cp" "-r"
> +                                   "../googletest-release-1.7.0/include"
> +                                   out))
> +                         (zero? (system* "cp" "libgtest.a" "libgtest_main.a"
> +                                         (string-append out "/lib"))))))))))

I think these uses of (system*) could be replaced by (copy-recursively)
and (install-file), respectively.