* [Patch] ruby-debug-inspector
@ 2016-05-31 15:32 Matthew Jordan
2016-05-31 17:59 ` Efraim Flashner
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Jordan @ 2016-05-31 15:32 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
Good Day,
This patch is part of a series of patches related to rails@4.2.6. I'll
send a couple at time once the previous ones have been accepted.
[-- Attachment #2: Patch for ruby-debug-inspector. --]
[-- Type: text/x-patch, Size: 3037 bytes --]
From ee75250f7328aae1bf1886c730d2cbe4b30ea91a Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:26:24 -0400
Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.
* gnu/local.mk: Modfied file.
* gnu/packages/rails.scm: New file.
---
gnu/local.mk | 1 +
gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+)
create mode 100644 gnu/packages/rails.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index 86b56d4..4c21827 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/qemu.scm \
%D%/packages/qt.scm \
%D%/packages/ragel.scm \
+ %D%/packages/rails.scm \
%D%/packages/ratpoison.scm \
%D%/packages/rc.scm \
%D%/packages/rdesktop.scm \
diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
new file mode 100644
index 0000000..8241c18
--- /dev/null
+++ b/gnu/packages/rails.scm
@@ -0,0 +1,53 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rails)
+ #:use-module (guix licenses)
+ #:use-module (gnu packages)
+ #:use-module (guix download)
+ #:use-module (guix packages)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages node)
+ #:use-module (gnu packages ruby)
+ #:use-module (gnu packages gcc)
+ #:use-module (guix build-system ruby))
+
+(define-public ruby-debug-inspector
+ (package
+ (name "ruby-debug-inspector")
+ (version "0.0.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "debug_inspector" version))
+ (sha256
+ (base32
+ "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:tests? #f))
+ (inputs
+ `(("ruby-bacon" ,ruby-bacon)))
+ (synopsis
+ "A Ruby wrapper for the MRI 2.0 debug_inspector API")
+ (description
+ "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector API")
+ (home-page
+ "https://github.com/banister/debug_inspector")
+ (license #f)))
--
2.8.3
[-- Attachment #3: Type: text/plain, Size: 53 bytes --]
Respectuflly,
--
Matthew Jordan
Sent with my mu4e
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Patch] ruby-debug-inspector
2016-05-31 15:32 [Patch] ruby-debug-inspector Matthew Jordan
@ 2016-05-31 17:59 ` Efraim Flashner
2016-05-31 20:44 ` Matthew Jordan
0 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2016-05-31 17:59 UTC (permalink / raw)
To: Matthew Jordan; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 3994 bytes --]
On Tue, May 31, 2016 at 11:32:45AM -0400, Matthew Jordan wrote:
>
> Good Day,
>
> This patch is part of a series of patches related to rails@4.2.6. I'll
> send a couple at time once the previous ones have been accepted.
>
> From ee75250f7328aae1bf1886c730d2cbe4b30ea91a Mon Sep 17 00:00:00 2001
> From: Matthew Jordan <matthewjordandevops@yandex.com>
> Date: Tue, 31 May 2016 07:26:24 -0400
> Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.
>
> * gnu/local.mk: Modfied file.
> * gnu/packages/rails.scm: New file.
> ---
> gnu/local.mk | 1 +
> gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 gnu/packages/rails.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 86b56d4..4c21827 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
> %D%/packages/qemu.scm \
> %D%/packages/qt.scm \
> %D%/packages/ragel.scm \
> + %D%/packages/rails.scm \
> %D%/packages/ratpoison.scm \
> %D%/packages/rc.scm \
> %D%/packages/rdesktop.scm \
> diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
> new file mode 100644
> index 0000000..8241c18
> --- /dev/null
> +++ b/gnu/packages/rails.scm
> @@ -0,0 +1,53 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages rails)
> + #:use-module (guix licenses)
> + #:use-module (gnu packages)
> + #:use-module (guix download)
> + #:use-module (guix packages)
> + #:use-module (gnu packages base)
> + #:use-module (gnu packages python)
> + #:use-module (gnu packages node)
> + #:use-module (gnu packages ruby)
> + #:use-module (gnu packages gcc)
> + #:use-module (guix build-system ruby))
> +
> +(define-public ruby-debug-inspector
> + (package
> + (name "ruby-debug-inspector")
> + (version "0.0.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "debug_inspector" version))
> + (sha256
> + (base32
> + "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
> + (build-system ruby-build-system)
> + (arguments
> + `(#:tests? #f))
Why are the tests not run? Please include a comment explaining.
> + (inputs
> + `(("ruby-bacon" ,ruby-bacon)))
> + (synopsis
> + "A Ruby wrapper for the MRI 2.0 debug_inspector API")
> + (description
> + "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector API")
^^^
needs a period at the end
> + (home-page
> + "https://github.com/banister/debug_inspector")
> + (license #f)))
^^^
oops ;)
> --
> 2.8.3
>
>
> Respectuflly,
>
> --
> Matthew Jordan
> Sent with my mu4e
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Patch] ruby-debug-inspector
2016-05-31 17:59 ` Efraim Flashner
@ 2016-05-31 20:44 ` Matthew Jordan
2016-06-01 7:02 ` Efraim Flashner
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Jordan @ 2016-05-31 20:44 UTC (permalink / raw)
To: Efraim Flashner; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
Updated patch with the suggested changes.
[-- Attachment #2: Patch to add ruby-debug-inspector. --]
[-- Type: text/x-patch, Size: 3090 bytes --]
From 20f94a54c63023c3bf3d8d556385f520aaf09a3f Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:26:24 -0400
Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.
* gnu/local.mk: Modfied file.
* gnu/packages/rails.scm: New file.
---
gnu/local.mk | 1 +
gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+)
create mode 100644 gnu/packages/rails.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index 86b56d4..4c21827 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/qemu.scm \
%D%/packages/qt.scm \
%D%/packages/ragel.scm \
+ %D%/packages/rails.scm \
%D%/packages/ratpoison.scm \
%D%/packages/rc.scm \
%D%/packages/rdesktop.scm \
diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
new file mode 100644
index 0000000..4612bb1
--- /dev/null
+++ b/gnu/packages/rails.scm
@@ -0,0 +1,53 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rails)
+ #:use-module (guix licenses)
+ #:use-module (gnu packages)
+ #:use-module (guix download)
+ #:use-module (guix packages)
+ #:use-module (gnu packages base)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages node)
+ #:use-module (gnu packages ruby)
+ #:use-module (gnu packages gcc)
+ #:use-module (guix build-system ruby))
+
+(define-public ruby-debug-inspector
+ (package
+ (name "ruby-debug-inspector")
+ (version "0.0.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "debug_inspector" version))
+ (sha256
+ (base32
+ "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
+ (inputs
+ `(("ruby-bacon" ,ruby-bacon)))
+ (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
+ (description
+ "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
+API.")
+ (home-page
+ "https://github.com/banister/debug_inspector")
+ (license expat)))
--
2.8.3
[-- Attachment #3: Type: text/plain, Size: 3964 bytes --]
--
Matthew Jordan
Sent with my mu4e
Efraim Flashner writes:
> On Tue, May 31, 2016 at 11:32:45AM -0400, Matthew Jordan wrote:
>>
>> Good Day,
>>
>> This patch is part of a series of patches related to rails@4.2.6. I'll
>> send a couple at time once the previous ones have been accepted.
>>
>
>> From ee75250f7328aae1bf1886c730d2cbe4b30ea91a Mon Sep 17 00:00:00 2001
>> From: Matthew Jordan <matthewjordandevops@yandex.com>
>> Date: Tue, 31 May 2016 07:26:24 -0400
>> Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.
>>
>> * gnu/local.mk: Modfied file.
>> * gnu/packages/rails.scm: New file.
>> ---
>> gnu/local.mk | 1 +
>> gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 54 insertions(+)
>> create mode 100644 gnu/packages/rails.scm
>>
>> diff --git a/gnu/local.mk b/gnu/local.mk
>> index 86b56d4..4c21827 100644
>> --- a/gnu/local.mk
>> +++ b/gnu/local.mk
>> @@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
>> %D%/packages/qemu.scm \
>> %D%/packages/qt.scm \
>> %D%/packages/ragel.scm \
>> + %D%/packages/rails.scm \
>> %D%/packages/ratpoison.scm \
>> %D%/packages/rc.scm \
>> %D%/packages/rdesktop.scm \
>> diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
>> new file mode 100644
>> index 0000000..8241c18
>> --- /dev/null
>> +++ b/gnu/packages/rails.scm
>> @@ -0,0 +1,53 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages rails)
>> + #:use-module (guix licenses)
>> + #:use-module (gnu packages)
>> + #:use-module (guix download)
>> + #:use-module (guix packages)
>> + #:use-module (gnu packages base)
>> + #:use-module (gnu packages python)
>> + #:use-module (gnu packages node)
>> + #:use-module (gnu packages ruby)
>> + #:use-module (gnu packages gcc)
>> + #:use-module (guix build-system ruby))
>> +
>> +(define-public ruby-debug-inspector
>> + (package
>> + (name "ruby-debug-inspector")
>> + (version "0.0.2")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (rubygems-uri "debug_inspector" version))
>> + (sha256
>> + (base32
>> + "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
>> + (build-system ruby-build-system)
>> + (arguments
>> + `(#:tests? #f))
> Why are the tests not run? Please include a comment explaining.
>
>> + (inputs
>> + `(("ruby-bacon" ,ruby-bacon)))
>> + (synopsis
>> + "A Ruby wrapper for the MRI 2.0 debug_inspector API")
>> + (description
>> + "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector API")
> ^^^
> needs a period at the end
>> + (home-page
>> + "https://github.com/banister/debug_inspector")
>> + (license #f)))
> ^^^
> oops ;)
>> --
>> 2.8.3
>>
>
>>
>> Respectuflly,
>>
>> --
>> Matthew Jordan
>> Sent with my mu4e
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Patch] ruby-debug-inspector
2016-05-31 20:44 ` Matthew Jordan
@ 2016-06-01 7:02 ` Efraim Flashner
2016-06-01 7:35 ` Ben Woodcroft
0 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2016-06-01 7:02 UTC (permalink / raw)
To: Matthew Jordan; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 4506 bytes --]
On Tue, May 31, 2016 at 04:44:56PM -0400, Matthew Jordan wrote:
>
> Updated patch with the suggested changes.
>
> From 20f94a54c63023c3bf3d8d556385f520aaf09a3f Mon Sep 17 00:00:00 2001
> From: Matthew Jordan <matthewjordandevops@yandex.com>
> Date: Tue, 31 May 2016 07:26:24 -0400
> Subject: [PATCH 1/4] gnu: Add ruby-debug-inspector.
>
> * gnu/local.mk: Modfied file.
this one -^ should be:
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/rails.scm: New file.
> ---
> gnu/local.mk | 1 +
> gnu/packages/rails.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 gnu/packages/rails.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 86b56d4..4c21827 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
> %D%/packages/qemu.scm \
> %D%/packages/qt.scm \
> %D%/packages/ragel.scm \
> + %D%/packages/rails.scm \
> %D%/packages/ratpoison.scm \
> %D%/packages/rc.scm \
> %D%/packages/rdesktop.scm \
> diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
> new file mode 100644
> index 0000000..4612bb1
> --- /dev/null
> +++ b/gnu/packages/rails.scm
> @@ -0,0 +1,53 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
it turns out you have a couple of extra modules here:
> +(define-module (gnu packages rails)
> + #:use-module (guix licenses)
> + #:use-module (gnu packages)
this one isn't needed -^
> + #:use-module (guix download)
> + #:use-module (guix packages)
> + #:use-module (gnu packages base)
> + #:use-module (gnu packages python)
> + #:use-module (gnu packages node)
these 3 either -^
> + #:use-module (gnu packages ruby)
> + #:use-module (gnu packages gcc)
or this one -^
> + #:use-module (guix build-system ruby))
> +
> +(define-public ruby-debug-inspector
> + (package
> + (name "ruby-debug-inspector")
> + (version "0.0.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "debug_inspector" version))
> + (sha256
> + (base32
> + "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
> + (build-system ruby-build-system)
> + (arguments
> + `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
> + (inputs
> + `(("ruby-bacon" ,ruby-bacon)))
> + (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
> + (description
> + "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
> +API.")
> + (home-page
> + "https://github.com/banister/debug_inspector")
> + (license expat)))
> --
> 2.8.3
>
>
> --
> Matthew Jordan
> Sent with my mu4e
>
Here's the error from having the tests enabled:
starting phase `check'
bacon -Itest -rubygems -a -q
Usage: bacon [options] [files | -a] [-- untouched arguments]
rake aborted!
Command failed with status (1): [bacon -Itest -rubygems -a -q...]
/tmp/guix-build-ruby-debug-inspector-0.0.2.drv-0/gem/Rakefile:21:in
`block in <top (required)>'
Tasks: TOP => test
(See full trace by running task with --trace)
I'm not a ruby person so I don't really know what that means.
Other than the last few things it looks good to me. I'll push it with the
few edits later today unless someone with more ruby experience comes and
says I'm missing something :)
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Patch] ruby-debug-inspector
2016-06-01 7:02 ` Efraim Flashner
@ 2016-06-01 7:35 ` Ben Woodcroft
2016-06-01 18:24 ` Matthew Jordan
2016-06-03 5:33 ` Matthew Jordan
0 siblings, 2 replies; 11+ messages in thread
From: Ben Woodcroft @ 2016-06-01 7:35 UTC (permalink / raw)
To: Efraim Flashner, Matthew Jordan; +Cc: guix-devel
Hi Matthew,
Thanks for the patch, all patches toward rails are much appreciated. I
do have a few comments though.
>> * gnu/packages/rails.scm: New file.
I'm of the opinion that we should keep most ruby packages in
gnu/packages/ruby.scm because to me "is this ruby package a rails
package?" is not one with a straightforward answer. We already have
activesupport in ruby.scm for instance, and that is more of a rails
package than this I would argue.
>> + #:use-module (guix build-system ruby))
>> +
>> +(define-public ruby-debug-inspector
>> + (package
>> + (name "ruby-debug-inspector")
>> + (version "0.0.2")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (rubygems-uri "debug_inspector" version))
>> + (sha256
>> + (base32
>> + "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
>> + (build-system ruby-build-system)
>> + (arguments
>> + `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
Looking a bit closer at this it appears the test directory is missing
from the gem but even the repository too. Maybe instead we add a cheap
and cheerful test like this:
(arguments
`(#:phases
(modify-phases %standard-phases
(replace 'check
(lambda _
(zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))
WDYT?
>> + (inputs
>> + `(("ruby-bacon" ,ruby-bacon)))
bacon is not a dependency other than for testing, is that right? If so I
don't think it is necessary.
>> + (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
>> + (description
>> + "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
>> +API.")
>> + (home-page
>> + "https://github.com/banister/debug_inspector")
>> + (license expat)))
Can you send an updated patch please? I'll look at your other patches
soon too.
Thanks,
ben
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Patch] ruby-debug-inspector
2016-06-01 7:35 ` Ben Woodcroft
@ 2016-06-01 18:24 ` Matthew Jordan
2016-06-03 5:33 ` Matthew Jordan
1 sibling, 0 replies; 11+ messages in thread
From: Matthew Jordan @ 2016-06-01 18:24 UTC (permalink / raw)
To: Ben Woodcroft; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
Good day,
I have updated the patch based on the suggestions made.
Thanks for the feedback.
> Thanks for the patch, all patches toward rails are much appreciated. I
> do have a few comments though.
>>> * gnu/packages/rails.scm: New file.
> I'm of the opinion that we should keep most ruby packages in
> gnu/packages/ruby.scm because to me "is this ruby package a rails
> package?" is not one with a straightforward answer. We already have
> activesupport in ruby.scm for instance, and that is more of a rails
> package than this I would argue.
While this is true to some extent, would it really be a good idea to put
all ruby packages in one file?
Also if I absolutely have to move them to ruby.scm, could I do so in
different patch, as I have several patches in that branch that would
need to be rebased (probably manually).
> Can you send an updated patch please? I'll look at your other patches
> soon too.
I have no problem making changes and updates, I still have much to
learn. And about the other patches much appreciated.
[-- Attachment #2: patch to add ruby-debug-inspector. --]
[-- Type: text/x-patch, Size: 2974 bytes --]
From 5d1ba9e16d5cdd37521f068f0304730e39837e9f Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:26:24 -0400
Subject: [PATCH] gnu: Add ruby-debug-inspector.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
* gnu/packages/rails.scm: New file.
---
gnu/local.mk | 1 +
gnu/packages/rails.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 gnu/packages/rails.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index 86b56d4..4c21827 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/qemu.scm \
%D%/packages/qt.scm \
%D%/packages/ragel.scm \
+ %D%/packages/rails.scm \
%D%/packages/ratpoison.scm \
%D%/packages/rc.scm \
%D%/packages/rdesktop.scm \
diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
new file mode 100644
index 0000000..77ab354
--- /dev/null
+++ b/gnu/packages/rails.scm
@@ -0,0 +1,50 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rails)
+ #:use-module (guix licenses)
+ #:use-module (guix download)
+ #:use-module (guix packages)
+ #:use-module (gnu packages ruby)
+ #:use-module (guix build-system ruby))
+
+(define-public ruby-debug-inspector
+ (package
+ (name "ruby-debug-inspector")
+ (version "0.0.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "debug_inspector" version))
+ (sha256
+ (base32
+ "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda _
+ (zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))
+ (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
+ (description
+ "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
+API.")
+ (home-page
+ "https://github.com/banister/debug_inspector")
+ (license expat)))
--
2.8.3
[-- Attachment #3: Type: text/plain, Size: 53 bytes --]
Respectuflly,
--
Matthew Jordan
Sent with my mu4e
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Patch] ruby-debug-inspector
2016-06-01 7:35 ` Ben Woodcroft
2016-06-01 18:24 ` Matthew Jordan
@ 2016-06-03 5:33 ` Matthew Jordan
2016-06-03 23:42 ` Ben Woodcroft
1 sibling, 1 reply; 11+ messages in thread
From: Matthew Jordan @ 2016-06-03 5:33 UTC (permalink / raw)
To: Ben Woodcroft; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 92 bytes --]
Good Day,
This patch includes the suggested changes, and an update to the
license prefix.
[-- Attachment #2: Add package ruby-debug-inspector. --]
[-- Type: text/x-patch, Size: 3006 bytes --]
From cfb727017d298c71b925c835f8f298c8db45fd7c Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:26:24 -0400
Subject: [PATCH 1/2] gnu: Add ruby-debug-inspector.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
* gnu/packages/rails.scm: New file.
---
gnu/local.mk | 1 +
gnu/packages/rails.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 gnu/packages/rails.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index 59aaccc..5665aae 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/qemu.scm \
%D%/packages/qt.scm \
%D%/packages/ragel.scm \
+ %D%/packages/rails.scm \
%D%/packages/ratpoison.scm \
%D%/packages/rc.scm \
%D%/packages/rdesktop.scm \
diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
new file mode 100644
index 0000000..80e73d7
--- /dev/null
+++ b/gnu/packages/rails.scm
@@ -0,0 +1,50 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rails)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix download)
+ #:use-module (guix packages)
+ #:use-module (gnu packages ruby)
+ #:use-module (guix build-system ruby))
+
+(define-public ruby-debug-inspector
+ (package
+ (name "ruby-debug-inspector")
+ (version "0.0.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "debug_inspector" version))
+ (sha256
+ (base32
+ "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda _
+ (zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))
+ (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
+ (description
+ "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
+API.")
+ (home-page
+ "https://github.com/banister/debug_inspector")
+ (license license:expat)))
--
2.8.3
[-- Attachment #3: Type: text/plain, Size: 48 bytes --]
Regards,
--
Matthew Jordan
Sent with my mu4e
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Patch] ruby-debug-inspector
2016-06-03 5:33 ` Matthew Jordan
@ 2016-06-03 23:42 ` Ben Woodcroft
2016-06-04 0:04 ` Matthew Jordan
0 siblings, 1 reply; 11+ messages in thread
From: Ben Woodcroft @ 2016-06-03 23:42 UTC (permalink / raw)
To: Matthew Jordan; +Cc: guix-devel
On 06/03/2016 03:33 PM, Matthew Jordan wrote:
> Good Day,
>
> This patch includes the suggested changes, and an update to the
> license prefix.
Thanks. However, I realised that the testing phase was ineffective
because the code catches the LoadError and returns without error. So I
modified it to actually use the debug_inspector code, and pushed.
I hope this is the first of the many patches in rails.scm.
Thanks.
ben
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Patch] ruby-debug-inspector
2016-06-03 23:42 ` Ben Woodcroft
@ 2016-06-04 0:04 ` Matthew Jordan
2016-06-04 1:43 ` Ben Woodcroft
0 siblings, 1 reply; 11+ messages in thread
From: Matthew Jordan @ 2016-06-04 0:04 UTC (permalink / raw)
To: Ben Woodcroft; +Cc: guix-devel
Okay and thanks.
Also yes that patch is the first in rails patch series.
Ben Woodcroft writes:
> On 06/03/2016 03:33 PM, Matthew Jordan wrote:
>> Good Day,
>>
>> This patch includes the suggested changes, and an update to the
>> license prefix.
>
> Thanks. However, I realised that the testing phase was ineffective
> because the code catches the LoadError and returns without error. So I
> modified it to actually use the debug_inspector code, and pushed.
>
> I hope this is the first of the many patches in rails.scm.
>
> Thanks.
> ben
--
Matthew Jordan
Sent with my mu4e
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-06-04 13:36 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 15:32 [Patch] ruby-debug-inspector Matthew Jordan
2016-05-31 17:59 ` Efraim Flashner
2016-05-31 20:44 ` Matthew Jordan
2016-06-01 7:02 ` Efraim Flashner
2016-06-01 7:35 ` Ben Woodcroft
2016-06-01 18:24 ` Matthew Jordan
2016-06-03 5:33 ` Matthew Jordan
2016-06-03 23:42 ` Ben Woodcroft
2016-06-04 0:04 ` Matthew Jordan
2016-06-04 1:43 ` Ben Woodcroft
2016-06-04 13:35 ` Matthew Jordan
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).