From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add gparted. Date: Sat, 28 May 2016 12:18:55 -0400 Message-ID: <20160528161855.GC16585@jasmine> References: <87shx2xjrj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6gxF-0002qB-2y for guix-devel@gnu.org; Sat, 28 May 2016 12:19:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6gxB-0003JV-1U for guix-devel@gnu.org; Sat, 28 May 2016 12:19:13 -0400 Content-Disposition: inline In-Reply-To: <87shx2xjrj.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote: > Dear Guix, > > I wonder if my ChangeLog-format commit message is OK this way. How about wording it as in bf50f7b5870? I don't think it's necessary to list the affected packages if it applies to the entire module. > Also, is it OK to push this patch for GParted? To avoid a name > collision for 'zlib' (both a license and a package), I added the > usual 'license:' prefix to the other packages in this file. Okay! > * gnu/packages/disk.scm (gparted): New variable. > (parted, fdisk, ddrescue, dosfstools, sdparm, idle3-tools): Avoid ambiguity by > adding a prefix to license symbols. It runs and finds my partitions! I didn't try to actually do anything... > + (arguments > + `(#:tests? #f ; Tests require a network connection. Is it just a small subset of the tests that require the network? Maybe we could disable only those tests? > + #:configure-flags '("--disable-scrollkeeper"))) I'm not sure what this means. Can you leave a comment explaining it? > + (inputs > + `(("util-linux" ,util-linux) Since util-linux is just a mish-mash of miscellaneous utilities, I like it when packagers leave a hint of what it's being used for, either in a comment, or by naming it after the used library, as in the jack-1 package.