From: Leo Famulari <leo@famulari.name>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add gparted.
Date: Sat, 28 May 2016 12:18:55 -0400 [thread overview]
Message-ID: <20160528161855.GC16585@jasmine> (raw)
In-Reply-To: <87shx2xjrj.fsf@gnu.org>
On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote:
> Dear Guix,
>
> I wonder if my ChangeLog-format commit message is OK this way.
How about wording it as in bf50f7b5870? I don't think it's necessary to
list the affected packages if it applies to the entire module.
> Also, is it OK to push this patch for GParted? To avoid a name
> collision for 'zlib' (both a license and a package), I added the
> usual 'license:' prefix to the other packages in this file.
Okay!
> * gnu/packages/disk.scm (gparted): New variable.
> (parted, fdisk, ddrescue, dosfstools, sdparm, idle3-tools): Avoid ambiguity by
> adding a prefix to license symbols.
It runs and finds my partitions! I didn't try to actually do anything...
> + (arguments
> + `(#:tests? #f ; Tests require a network connection.
Is it just a small subset of the tests that require the network? Maybe
we could disable only those tests?
> + #:configure-flags '("--disable-scrollkeeper")))
I'm not sure what this means. Can you leave a comment explaining it?
> + (inputs
> + `(("util-linux" ,util-linux)
Since util-linux is just a mish-mash of miscellaneous utilities, I like
it when packagers leave a hint of what it's being used for, either in a
comment, or by naming it after the used library, as in the jack-1
package.
next prev parent reply other threads:[~2016-05-28 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 15:52 [PATCH] gnu: Add gparted Roel Janssen
2016-05-28 16:18 ` Leo Famulari [this message]
2016-05-28 18:34 ` Roel Janssen
2016-05-28 19:15 ` Alex Kost
2016-05-28 19:28 ` Leo Famulari
2016-05-28 19:41 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160528161855.GC16585@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).