From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, Danny Milosavljevic <dannym+a@scratchpost.org>
Subject: Re: [PATCH] gnu: Add rofi.
Date: Tue, 24 May 2016 23:38:00 -0400 [thread overview]
Message-ID: <20160525033800.GA26173@jasmine> (raw)
In-Reply-To: <20160524085502.2f095f2f@scratchpost.org>
On Tue, May 24, 2016 at 08:55:02AM +0200, Danny Milosavljevic wrote:
> On Mon, 23 May 2016 00:28:26 -0400
> Leo Famulari <leo@famulari.name> wrote:
>
> > The failing test (helper_expand) seems to fail when it can't find
> > `which`.
>
> The failing test is test/helper-expand.c and it tries to do this:
>
> str = rofi_expand_path ( "~/" ); <----- oh oh
[...]
> str = rofi_expand_path ( "~root/" ); <--- oh oh
[...]
> str[i] = g_strdup ( g_get_home_dir () ); <----------- oh oh
[...]
> struct passwd *p = getpwnam ( &( str[i][1] ) ); <---------- oh oh
> What should we do about it?
How about disabling that test only? You can comment it out of wherever
it's invoked, or make it return true immediately. I'm not sure if we
have a canonical method... I think it depends on the language and
implementation.
next prev parent reply other threads:[~2016-05-25 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 4:29 [PATCH] gnu: Add rofi Danny Milosavljevic
2016-05-23 4:28 ` Leo Famulari
2016-05-24 6:55 ` Danny Milosavljevic
2016-05-25 3:38 ` Leo Famulari [this message]
2016-05-26 0:56 ` [PATCH v2] * gnu/packages/xdisorg.scm (rofi): New variable Danny Milosavljevic
2016-05-27 17:41 ` Leo Famulari
2016-05-27 18:23 ` [PATCH v3] gnu: Add rofi Danny Milosavljevic
2016-05-27 18:35 ` Leo Famulari
2016-05-27 18:54 ` Danny Milosavljevic
2016-05-31 21:25 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525033800.GA26173@jasmine \
--to=leo@famulari.name \
--cc=dannym+a@scratchpost.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).