From: Leo Famulari <leo@famulari.name>
To: Jeremy Robst <jpro@bas.ac.uk>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add hdf4
Date: Mon, 23 May 2016 14:17:19 -0400 [thread overview]
Message-ID: <20160523181719.GA11083@jasmine> (raw)
In-Reply-To: <alpine.DEB.2.20.1605231817490.16068@jpro.nerc-bas.ac.uk>
On Mon, May 23, 2016 at 06:22:09PM +0100, Jeremy Robst wrote:
Welcome, and thanks for the patch!
Unfortunately, I can't seem to apply it to my source tree. Is anybody
else able to do so? I can't figure *why* it doesn't apply. Jeremy, are
you able to apply it with `patch -p1` or `git am`?
> +(define-public hdf4
> + (package
> + (name "hdf4")
> + (version "4.2.11")
> + (source + (origin + (method url-fetch)
This is strange. It renders as expected once the patch is downloaded,
but in Mutt, it looks like this. I wonder if this has to do with the
patch not applying?
> + (arguments '(#:tests? #f))
We prefer to add a comment explaining why test are disabled. If there
are no tests, then the comment can be "No test suite."
> + (license (license:x11-style
> + "https://www.hdfgroup.org/ftp/HDF/HDF_Current/src/unpacked/COPYING"))))
To me, this looks more like a variation on the BSD license than the x11
license. Perhaps non-copyleft is a more appropriate choice. Can you look
at some of our packages using non-copyleft and report back?
Can you look into these questions and send an updated patch?
next prev parent reply other threads:[~2016-05-23 18:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 17:22 [PATCH] gnu: Add hdf4 Jeremy Robst
2016-05-23 18:17 ` Leo Famulari [this message]
2016-05-24 13:20 ` Jeremy Robst
2016-05-24 19:06 ` Eric Bavier
2016-05-25 17:42 ` Jeremy Robst
2016-05-27 17:19 ` Leo Famulari
2016-05-28 14:32 ` Ludovic Courtès
2016-05-29 17:36 ` Jeremy Robst
2016-05-29 22:07 ` Ludovic Courtès
2016-06-02 14:43 ` Eric Bavier
2016-06-02 14:58 ` Jeremy Robst
2016-06-03 8:37 ` Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2016-10-11 8:57 Thomas Danckaert
2016-10-12 12:54 ` Ludovic Courtès
2016-10-12 18:50 ` Thomas Danckaert
2016-10-12 20:28 ` Ludovic Courtès
2016-10-14 8:11 ` Andreas Enge
2016-10-14 11:13 ` Thomas Danckaert
[not found] ` <20161014.110029.603260973900204345.post@thomasdanckaert.be>
2016-10-16 15:05 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523181719.GA11083@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=jpro@bas.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).