unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Roel Janssen <roel@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add poppler-qt5.
Date: Mon, 23 May 2016 14:40:26 +0300	[thread overview]
Message-ID: <20160523114026.GA3721@debian-netbook> (raw)
In-Reply-To: <87r3ctzly6.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

On Mon, May 23, 2016 at 01:56:17AM +0200, Roel Janssen wrote:
> Dear Guix,
> 
> I need poppler-qt5 for Texmaker (see other patch), so here is a patch:
> 
> >From ef330ec9125246f81094ac36c2f564f3f3fca029 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Mon, 23 May 2016 01:47:11 +0200
> Subject: [PATCH] gnu: Add poppler-qt5.
> 
> * gnu/packages/pdf.scm (poppler-qt5): New variable.
> ---
>  gnu/packages/pdf.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index ef05def..d577afd 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -109,6 +109,13 @@
>               ,@(package-inputs poppler)))
>     (synopsis "Qt4 frontend for the Poppler PDF rendering library")))
>  
> +(define-public poppler-qt5
> +  (package (inherit poppler)
> +   (name "poppler-qt5")
> +   (inputs `(("qt" ,qt)
> +             ,@(package-inputs poppler)))
> +   (synopsis "Qt5 frontend for the Poppler PDF rendering library")))
> +
>  (define-public python-poppler-qt4
>    (package
>      (name "python-poppler-qt4")
> -- 
> 2.7.4
> 

This looks good and built fine.
I added a copyright line for you at the top and pushed it.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-05-23 11:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-22 23:56 [PATCH] gnu: Add poppler-qt5 Roel Janssen
2016-05-23 11:40 ` Efraim Flashner [this message]
2016-05-23 11:46   ` Roel Janssen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523114026.GA3721@debian-netbook \
    --to=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=roel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).