unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 0/1] GRUB: Use Parted in tests
@ 2016-05-22 23:28 Leo Famulari
  2016-05-22 23:28 ` [PATCH 1/1] gnu: grub: Re-enable test Leo Famulari
  2016-05-23  8:10 ` [PATCH 0/1] GRUB: Use Parted in tests Efraim Flashner
  0 siblings, 2 replies; 5+ messages in thread
From: Leo Famulari @ 2016-05-22 23:28 UTC (permalink / raw)
  To: guix-devel

I noticed that we disable a test in GRUB's test suite because it
required Parted and (presumably) had not packaged it yet.

I added it to native-inputs and successfully built GRUB on x86_64 and
i686.

Leo Famulari (1):
  gnu: grub: Re-enable test.

 gnu/packages/grub.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.8.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] gnu: grub: Re-enable test.
  2016-05-22 23:28 [PATCH 0/1] GRUB: Use Parted in tests Leo Famulari
@ 2016-05-22 23:28 ` Leo Famulari
  2016-05-23  8:10 ` [PATCH 0/1] GRUB: Use Parted in tests Efraim Flashner
  1 sibling, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2016-05-22 23:28 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/grub.scm (grub)[arguments]: Re-enable test.
---
 gnu/packages/grub.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/grub.scm b/gnu/packages/grub.scm
index ec2feeb..31b270c 100644
--- a/gnu/packages/grub.scm
+++ b/gnu/packages/grub.scm
@@ -25,6 +25,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages disk)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages fontutils)
@@ -99,11 +100,6 @@
                      ;; Make the font visible.
                      (copy-file (assoc-ref inputs "unifont") "unifont.bdf.gz")
                      (system* "gunzip" "unifont.bdf.gz")
-
-                     ;; TODO: Re-enable this test when we have Parted.
-                     (substitute* "tests/partmap_test.in"
-                       (("set -e") "exit 77"))
-
                      #t)))))
     (inputs
      `(;; ("lvm2" ,lvm2)
@@ -121,6 +117,7 @@
 
        ;; Dependencies for the test suite.  The "real" QEMU is needed here,
        ;; because several targets are used.
+       ("parted" ,parted)
        ("qemu" ,qemu-for-tests)
        ("xorriso" ,xorriso)))
     (home-page "http://www.gnu.org/software/grub/")
-- 
2.8.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] GRUB: Use Parted in tests
  2016-05-22 23:28 [PATCH 0/1] GRUB: Use Parted in tests Leo Famulari
  2016-05-22 23:28 ` [PATCH 1/1] gnu: grub: Re-enable test Leo Famulari
@ 2016-05-23  8:10 ` Efraim Flashner
  2016-05-23 21:29   ` Ludovic Courtès
  1 sibling, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2016-05-23  8:10 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
> I noticed that we disable a test in GRUB's test suite because it
> required Parted and (presumably) had not packaged it yet.
> 
> I added it to native-inputs and successfully built GRUB on x86_64 and
> i686.
> 
> Leo Famulari (1):
>   gnu: grub: Re-enable test.
> 
>  gnu/packages/grub.scm | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> -- 
> 2.8.2
> 

It looks good to me

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] GRUB: Use Parted in tests
  2016-05-23  8:10 ` [PATCH 0/1] GRUB: Use Parted in tests Efraim Flashner
@ 2016-05-23 21:29   ` Ludovic Courtès
  2016-05-23 22:48     ` Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2016-05-23 21:29 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: guix-devel

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
>> I noticed that we disable a test in GRUB's test suite because it
>> required Parted and (presumably) had not packaged it yet.
>> 
>> I added it to native-inputs and successfully built GRUB on x86_64 and
>> i686.
>> 
>> Leo Famulari (1):
>>   gnu: grub: Re-enable test.
>> 
>>  gnu/packages/grub.scm | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>> 
>> -- 
>> 2.8.2
>> 
>
> It looks good to me

+1

Thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/1] GRUB: Use Parted in tests
  2016-05-23 21:29   ` Ludovic Courtès
@ 2016-05-23 22:48     ` Leo Famulari
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2016-05-23 22:48 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Mon, May 23, 2016 at 11:29:00PM +0200, Ludovic Courtès wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
> >> Leo Famulari (1):
> >>   gnu: grub: Re-enable test.
> >> 
> >>  gnu/packages/grub.scm | 7 ++-----
> >>  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > It looks good to me
> 
> +1

Thanks for the reviews. Pushed as 7febe3a28.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-05-23 22:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-22 23:28 [PATCH 0/1] GRUB: Use Parted in tests Leo Famulari
2016-05-22 23:28 ` [PATCH 1/1] gnu: grub: Re-enable test Leo Famulari
2016-05-23  8:10 ` [PATCH 0/1] GRUB: Use Parted in tests Efraim Flashner
2016-05-23 21:29   ` Ludovic Courtès
2016-05-23 22:48     ` Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).