[PATCH] Add Bluetooth support to Pulseaudio.

[PATCH] Add Bluetooth support to Pulseaudio.

[Ricardo Wurmus]

Hello Guix,

this patch adds Bluetooth support to pulseaudio.  (Since bluez5 there
is no native support for the ALSA backend any more.)  This adds very
little to the pulseaudio closure as you can see below.

Note that this depends on the previous patch adding SBC.

More than 100 packages would need to be rebuilt.  Among those are big
packages like GNOME, Blender, and conkeror.  Should I push this to
core-updates then?

Without Bluetooth support:

store item                                                       total    self
/gnu/store/0r8ppfz6nlgfllnqkdllc7a7p9dkw8ql-pulseaudio-8.0         153.8     7.7   5.0%
/gnu/store/ls0g4gd1mrky3zgf6nw2khxkvjpqsvh7-avahi-0.6.31           113.0     2.4   1.5%
/gnu/store/m5hvapdxh6l8sr4b7mp23hb96csqmp4y-eudev-3.1.5             96.9     7.0   4.5%
/gnu/store/66nq87yz0syphfzay4x5w810jpf5dl5n-util-linux-2.27         88.5    10.2   6.6%
/gnu/store/lbkdykh3aa1469li01rwyya02q50r3b9-glib-2.46.1             86.0    13.2   8.6%
/gnu/store/vhl6a5harxz1pxjnkvqrm3f5fhygcx6k-fftwf-3.3.4             75.9     3.6   2.3%
/gnu/store/ndf679ac3g9kjfqika5fr73wg6zrdrnr-kmod-17                 74.1     0.3   0.2%
/gnu/store/z8vgpay1q450ndgil902xxxz5mq0b1qr-xz-5.2.2                73.4     1.1   0.7%
/gnu/store/dafbdv4drmyc40gia6hhin9n1s4aj0m6-dbus-1.10.0             73.2     1.7   1.1%
/gnu/store/7cdd8s466qyjh64m0byq0rz9gk1jid40-bash-4.3.42             72.3     4.7   3.1%
/gnu/store/xqzmjw2b2j5i9pmkjmnjp3dm7hdiqln0-libx11-1.6.3            70.9     4.9   3.2%
/gnu/store/jvxkis7gibms9x5irnvwha0a7x0zrsbi-libsndfile-1.0.26       68.0     1.8   1.2%
/gnu/store/p7kjmkfsax6qgz2ihh2wiicxmd0mydhz-readline-6.3            67.6     1.2   0.8%
/gnu/store/xadbq6k36aphlx0haxxzym3xmd5r1rp8-ncurses-6.0             66.4     5.7   3.7%
/gnu/store/jsy847sch7lnxjppkn1s1as22dbx74fx-libxcb-1.11             65.9     5.0   3.3%
/gnu/store/xr9p87kwcdgcxb0la74d7ichrshykz14-libvorbis-1.3.5         64.0     2.8   1.8%
/gnu/store/ryy53w510l3ppw3a0lspzqxbdkyg2li2-flac-1.3.1              63.4     2.2   1.5%
/gnu/store/pv2xg14lgghxfpl7jhirc7dp0m3172js-alsa-lib-1.0.27.1       62.7     2.0   1.3%
/gnu/store/sn3rchx4zcf55jc1388rq96z731ivk9w-speex-1.2rc1            62.2     1.0   0.7%
/gnu/store/w7vb2skc8q5wjcfbya0qba7nj83pl6z4-expat-2.1.0             61.3     0.6   0.4%
/gnu/store/84d0xnz6jjwl0bj7hlywpc7vckjg66kr-gdbm-1.11               61.2     0.5   0.3%
/gnu/store/8a2fncbkp9m8yq1xd1995i31c6b063f0-libogg-1.3.2            61.2     0.5   0.3%
/gnu/store/zvm9rk007dd6r7rzy0ykjggpi5rjrr56-libcap-2.24             61.1     0.1   0.1%
/gnu/store/hsxhfmjgh8m4c0pavq3gd3gcrn8zrgxj-zlib-1.2.8              61.1     0.4   0.2%
/gnu/store/rpwnky5cppw0j9qbapajin7k7n3fn1jj-attr-2.4.47             61.0     0.2   0.2%
/gnu/store/j45119cdl7r92z41bfkfnlv91waidf8k-json-c-0.12             60.9     0.2   0.1%
/gnu/store/zhrhrs1myalxjppwjyn2971l6gld22rp-libxdmcp-1.1.2          60.9     0.2   0.1%
/gnu/store/557i3227wv6h8rj2zrc5vr4rmh0zgi6i-libffi-3.2.1            60.8     0.1   0.1%
/gnu/store/rs3cww7dqv9x5zhbs87f0nvkzx8h3dn3-libltdl-2.4.6           60.8     0.1   0.1%
/gnu/store/g9jbnfywqq0v0mkkb3313r0z9p0kar4b-libdaemon-0.14          60.8     0.1   0.1%
/gnu/store/c56bqxg9clybrmsgj0nk1z5n425cgfas-libxau-1.0.8            60.8     0.0   0.0%
/gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib           60.7    22.9  14.9%
/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42             49.5     4.7   3.1%
/gnu/store/0wy21msm26sdgg1jdnvinbz7hgpz7cjm-readline-6.3            44.8     1.2   0.8%
/gnu/store/aj3jaf7jln8yfzy9k96mn01fnmjnyx0g-ncurses-6.0             43.6     5.7   3.7%
/gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22              37.9    36.5  23.7%
/gnu/store/5y72ql4zbnbd50lf88k91k0y766kq75x-bash-static-4.3.42       1.4     1.4   0.9%


With Bluetooth support:

store item                                                       total    self
/gnu/store/qzrc629zic2l99qlxpbq15icxzwxwvp6-pulseaudio-8.0         154.5     8.0   5.2%
/gnu/store/ls0g4gd1mrky3zgf6nw2khxkvjpqsvh7-avahi-0.6.31           113.0     2.4   1.5%
/gnu/store/m5hvapdxh6l8sr4b7mp23hb96csqmp4y-eudev-3.1.5             96.9     7.0   4.5%
/gnu/store/66nq87yz0syphfzay4x5w810jpf5dl5n-util-linux-2.27         88.5    10.2   6.6%
/gnu/store/lbkdykh3aa1469li01rwyya02q50r3b9-glib-2.46.1             86.0    13.2   8.5%
/gnu/store/vhl6a5harxz1pxjnkvqrm3f5fhygcx6k-fftwf-3.3.4             75.9     3.6   2.3%
/gnu/store/ndf679ac3g9kjfqika5fr73wg6zrdrnr-kmod-17                 74.1     0.3   0.2%
/gnu/store/z8vgpay1q450ndgil902xxxz5mq0b1qr-xz-5.2.2                73.4     1.1   0.7%
/gnu/store/dafbdv4drmyc40gia6hhin9n1s4aj0m6-dbus-1.10.0             73.2     1.7   1.1%
/gnu/store/7cdd8s466qyjh64m0byq0rz9gk1jid40-bash-4.3.42             72.3     4.7   3.0%
/gnu/store/xqzmjw2b2j5i9pmkjmnjp3dm7hdiqln0-libx11-1.6.3            70.9     4.9   3.2%
/gnu/store/jvxkis7gibms9x5irnvwha0a7x0zrsbi-libsndfile-1.0.26       68.0     1.8   1.1%
/gnu/store/p7kjmkfsax6qgz2ihh2wiicxmd0mydhz-readline-6.3            67.6     1.2   0.8%
/gnu/store/xadbq6k36aphlx0haxxzym3xmd5r1rp8-ncurses-6.0             66.4     5.7   3.7%
/gnu/store/jsy847sch7lnxjppkn1s1as22dbx74fx-libxcb-1.11             65.9     5.0   3.2%
/gnu/store/xr9p87kwcdgcxb0la74d7ichrshykz14-libvorbis-1.3.5         64.0     2.8   1.8%
/gnu/store/ryy53w510l3ppw3a0lspzqxbdkyg2li2-flac-1.3.1              63.4     2.2   1.5%
/gnu/store/pv2xg14lgghxfpl7jhirc7dp0m3172js-alsa-lib-1.0.27.1       62.7     2.0   1.3%
/gnu/store/sn3rchx4zcf55jc1388rq96z731ivk9w-speex-1.2rc1            62.2     1.0   0.7%
/gnu/store/w7vb2skc8q5wjcfbya0qba7nj83pl6z4-expat-2.1.0             61.3     0.6   0.4%
/gnu/store/84d0xnz6jjwl0bj7hlywpc7vckjg66kr-gdbm-1.11               61.2     0.5   0.3%
/gnu/store/8a2fncbkp9m8yq1xd1995i31c6b063f0-libogg-1.3.2            61.2     0.5   0.3%
/gnu/store/zvm9rk007dd6r7rzy0ykjggpi5rjrr56-libcap-2.24             61.1     0.1   0.1%
/gnu/store/hsxhfmjgh8m4c0pavq3gd3gcrn8zrgxj-zlib-1.2.8              61.1     0.4   0.2%
/gnu/store/9ff190v55r04p84vh6yjqqg403dagir0-sbc-1.3                 61.0     0.3   0.2%
/gnu/store/rpwnky5cppw0j9qbapajin7k7n3fn1jj-attr-2.4.47             61.0     0.2   0.2%
/gnu/store/j45119cdl7r92z41bfkfnlv91waidf8k-json-c-0.12             60.9     0.2   0.1%
/gnu/store/zhrhrs1myalxjppwjyn2971l6gld22rp-libxdmcp-1.1.2          60.9     0.2   0.1%
/gnu/store/557i3227wv6h8rj2zrc5vr4rmh0zgi6i-libffi-3.2.1            60.8     0.1   0.1%
/gnu/store/rs3cww7dqv9x5zhbs87f0nvkzx8h3dn3-libltdl-2.4.6           60.8     0.1   0.1%
/gnu/store/g9jbnfywqq0v0mkkb3313r0z9p0kar4b-libdaemon-0.14          60.8     0.1   0.1%
/gnu/store/c56bqxg9clybrmsgj0nk1z5n425cgfas-libxau-1.0.8            60.8     0.0   0.0%
/gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib           60.7    22.9  14.8%
/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42             49.5     4.7   3.0%
/gnu/store/0wy21msm26sdgg1jdnvinbz7hgpz7cjm-readline-6.3            44.8     1.2   0.8%
/gnu/store/aj3jaf7jln8yfzy9k96mn01fnmjnyx0g-ncurses-6.0             43.6     5.7   3.7%
/gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22              37.9    36.5  23.6%
/gnu/store/5y72ql4zbnbd50lf88k91k0y766kq75x-bash-static-4.3.42       1.4     1.4   0.9%

~~ Ricardo



Ricardo Wurmus (1):
  gnu: pulseaudio: Enable support for Bluetooth.

 gnu/packages/pulseaudio.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.7.3

[PATCH] gnu: pulseaudio: Enable support for Bluetooth.

[Ricardo Wurmus]

* gnu/packages/pulseaudio.scm (pulseaudio)[arguments]: Add
"--enable-bluez5" to configure flags.
[inputs]: Add "bluez" and "sbc".
---
 gnu/packages/pulseaudio.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index b2b0508..2d97539 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014, 2015, 2016 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -138,6 +139,7 @@ rates.")
     (arguments
      `(#:configure-flags (list "--localstatedir=/var" ;"--sysconfdir=/etc"
                                "--disable-oss-output"
+                               "--enable-bluez5"
                                (string-append "--with-udev-rules-dir="
                                               (assoc-ref %outputs "out")
                                               "/lib/udev/rules.d"))
@@ -153,8 +155,9 @@ rates.")
                  %standard-phases)))
     (inputs
      ;; TODO: Add optional inputs (GTK+?).
-     `(;; ("sbc" ,sbc)
-       ("alsa-lib" ,alsa-lib)
+     `(("alsa-lib" ,alsa-lib)
+       ("bluez" ,bluez)
+       ("sbc" ,sbc)
        ("json-c" ,json-c)
        ("speex" ,speex)
        ("libsndfile" ,libsndfile)
-- 
2.7.3

Re: [PATCH] Add Bluetooth support to Pulseaudio.

[Alex Kost]

Ricardo Wurmus (2016-05-14 12:43 +0300) wrote:

> Hello Guix,
>
> this patch adds Bluetooth support to pulseaudio.  (Since bluez5 there
> is no native support for the ALSA backend any more.)  This adds very
> little to the pulseaudio closure as you can see below.
>
> Note that this depends on the previous patch adding SBC.
>
> More than 100 packages would need to be rebuilt.  Among those are big
> packages like GNOME, Blender, and conkeror.  Should I push this to
> core-updates then?

Conkeror is not the big one; it's a rather small wrapper around icecat
(in our case).  I don't know why "guix refresh -l pulseaudio" shows
conkeror and not icecat, but icecat is a really big and important one,
so I think it's better to commit this to core-updates, indeed.  Although
ISTR Ludovic told that core-updates is only for the real core packages
(that rebuild the whole world).

BTW do you still have problems with using guix repo through ssh?  I do,
I mean I can't push or fetch.  And as I see that other people commit to
the guix repo, I begin to think that it's only me who have this problem.

-- 
Alex

Re: [PATCH] Add Bluetooth support to Pulseaudio.

[Danny Milosavljevic]

> BTW do you still have problems with using guix repo through ssh?  I do,
> I mean I can't push or fetch.  And as I see that other people commit to
> the guix repo, I begin to think that it's only me who have this problem.
> 

FWIW, I can't pull either, not even for 

	url = git://git.sv.gnu.org/guix.git

$ git pull
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Re: [PATCH] Add Bluetooth support to Pulseaudio.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On Sat, May 14, 2016 at 07:54:57PM +0300, Alex Kost wrote:
> Ricardo Wurmus (2016-05-14 12:43 +0300) wrote:
> 
> > Hello Guix,
> >
> > this patch adds Bluetooth support to pulseaudio.  (Since bluez5 there
> > is no native support for the ALSA backend any more.)  This adds very
> > little to the pulseaudio closure as you can see below.
> >
> > Note that this depends on the previous patch adding SBC.
> >
> > More than 100 packages would need to be rebuilt.  Among those are big
> > packages like GNOME, Blender, and conkeror.  Should I push this to
> > core-updates then?
> 
> Conkeror is not the big one; it's a rather small wrapper around icecat
> (in our case).  I don't know why "guix refresh -l pulseaudio" shows
> conkeror and not icecat, but icecat is a really big and important one,
> so I think it's better to commit this to core-updates, indeed.  Although
> ISTR Ludovic told that core-updates is only for the real core packages
> (that rebuild the whole world).

conkeror depends on iceweasel, `guix refresh -l foo' only shows the
leafs that need to be rebuilt.

> 
> BTW do you still have problems with using guix repo through ssh?  I do,
> I mean I can't push or fetch.  And as I see that other people commit to
> the guix repo, I begin to think that it's only me who have this problem.

if you change your url in .git/config to:

url = http://git.savannah.gnu.org/r/guix.git

you should be able to fetch/pull as before

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Add Bluetooth support to Pulseaudio.

[Alex Kost]

Efraim Flashner (2016-05-14 22:59 +0300) wrote:

> On Sat, May 14, 2016 at 07:54:57PM +0300, Alex Kost wrote:
>> Ricardo Wurmus (2016-05-14 12:43 +0300) wrote:
>>
>> > Hello Guix,
>> >
>> > this patch adds Bluetooth support to pulseaudio.  (Since bluez5 there
>> > is no native support for the ALSA backend any more.)  This adds very
>> > little to the pulseaudio closure as you can see below.
>> >
>> > Note that this depends on the previous patch adding SBC.
>> >
>> > More than 100 packages would need to be rebuilt.  Among those are big
>> > packages like GNOME, Blender, and conkeror.  Should I push this to
>> > core-updates then?
>>
>> Conkeror is not the big one; it's a rather small wrapper around icecat
>> (in our case).  I don't know why "guix refresh -l pulseaudio" shows
>> conkeror and not icecat, but icecat is a really big and important one,
>> so I think it's better to commit this to core-updates, indeed.  Although
>> ISTR Ludovic told that core-updates is only for the real core packages
>> (that rebuild the whole world).
>
> conkeror depends on iceweasel, `guix refresh -l foo' only shows the
> leafs that need to be rebuilt.

Iceweasel?  I see that conkeror depends only on icecat.  Anyway I don't
understand: icecat depends on pulseaudio so it should probably be
displayed after "guix refresh -l pulseaudio", or did I miss your point?

>> BTW do you still have problems with using guix repo through ssh?  I do,
>> I mean I can't push or fetch.  And as I see that other people commit to
>> the guix repo, I begin to think that it's only me who have this problem.
>
> if you change your url in .git/config to:
>
> url = http://git.savannah.gnu.org/r/guix.git
>
> you should be able to fetch/pull as before

Thanks, I know that http works, but I need ssh to be able to push :-)
Apparently admins know about this problem:
http://savannah.gnu.org/forum/forum.php?forum_id=8542

BTW, I didn't change .git/config manually; I just added another (http)
remote using magit (by pressing "M a" in the magit status).

-- 
Alex

Re: [PATCH] Add Bluetooth support to Pulseaudio.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2632 bytes --]

On Sun, May 15, 2016 at 11:27:39AM +0300, Alex Kost wrote:
> Efraim Flashner (2016-05-14 22:59 +0300) wrote:
> 
> > On Sat, May 14, 2016 at 07:54:57PM +0300, Alex Kost wrote:
> >> Ricardo Wurmus (2016-05-14 12:43 +0300) wrote:
> >>
> >> > Hello Guix,
> >> >
> >> > this patch adds Bluetooth support to pulseaudio.  (Since bluez5 there
> >> > is no native support for the ALSA backend any more.)  This adds very
> >> > little to the pulseaudio closure as you can see below.
> >> >
> >> > Note that this depends on the previous patch adding SBC.
> >> >
> >> > More than 100 packages would need to be rebuilt.  Among those are big
> >> > packages like GNOME, Blender, and conkeror.  Should I push this to
> >> > core-updates then?
> >>
> >> Conkeror is not the big one; it's a rather small wrapper around icecat
> >> (in our case).  I don't know why "guix refresh -l pulseaudio" shows
> >> conkeror and not icecat, but icecat is a really big and important one,
> >> so I think it's better to commit this to core-updates, indeed.  Although
> >> ISTR Ludovic told that core-updates is only for the real core packages
> >> (that rebuild the whole world).
> >
> > conkeror depends on iceweasel, `guix refresh -l foo' only shows the
> > leafs that need to be rebuilt.
> 
> Iceweasel?  I see that conkeror depends only on icecat.  Anyway I don't
> understand: icecat depends on pulseaudio so it should probably be
> displayed after "guix refresh -l pulseaudio", or did I miss your point?
> 

Ah I meant icecat. 5+ years of Debian, I see ice and think iceweasel.

Pulseaudio -> Icecat -> Conkeror, Icecat is the "unimportant" dependancy
of Conkeror here.

> >> BTW do you still have problems with using guix repo through ssh?  I do,
> >> I mean I can't push or fetch.  And as I see that other people commit to
> >> the guix repo, I begin to think that it's only me who have this problem.
> >
> > if you change your url in .git/config to:
> >
> > url = http://git.savannah.gnu.org/r/guix.git
> >
> > you should be able to fetch/pull as before
> 
> Thanks, I know that http works, but I need ssh to be able to push :-)
> Apparently admins know about this problem:
> http://savannah.gnu.org/forum/forum.php?forum_id=8542
> 
> BTW, I didn't change .git/config manually; I just added another (http)
> remote using magit (by pressing "M a" in the magit status).
> 
> -- 
> Alex

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Add Bluetooth support to Pulseaudio.

[Ricardo Wurmus]

Alex Kost <alezost@gmail.com> writes:

> Ricardo Wurmus (2016-05-14 12:43 +0300) wrote:
>
>> Hello Guix,
>>
>> this patch adds Bluetooth support to pulseaudio.  (Since bluez5 there
>> is no native support for the ALSA backend any more.)  This adds very
>> little to the pulseaudio closure as you can see below.
>>
>> Note that this depends on the previous patch adding SBC.
>>
>> More than 100 packages would need to be rebuilt.  Among those are big
>> packages like GNOME, Blender, and conkeror.  Should I push this to
>> core-updates then?
>
> Conkeror is not the big one; it's a rather small wrapper around icecat
> (in our case).  I don't know why "guix refresh -l pulseaudio" shows
> conkeror and not icecat, but icecat is a really big and important one,
> so I think it's better to commit this to core-updates, indeed.  Although
> ISTR Ludovic told that core-updates is only for the real core packages
> (that rebuild the whole world).

I guess we could have a “pulseaudio-update” branch then.

> BTW do you still have problems with using guix repo through ssh?  I do,
> I mean I can't push or fetch.  And as I see that other people commit to
> the guix repo, I begin to think that it's only me who have this problem.

I still have problems with it with that so I haven’t yet pushed anything
for about one week.

~~ Ricardo

Re: [PATCH] gnu: pulseaudio: Enable support for Bluetooth.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/pulseaudio.scm (pulseaudio)[arguments]: Add
> "--enable-bluez5" to configure flags.
> [inputs]: Add "bluez" and "sbc".

I think it’s a reasonable change.

Ideally a ‘pulseaudio-updates’ branch would be the right thing.
However, if it builds and works as expected on master (at least make
sure ‘guix gc --references’ shows bluez and SBC), then it’s OK to commit
to ‘core-updates’ since it looks like a non-disruptive change.

Thanks!

Ludo’.

Re: [PATCH] gnu: pulseaudio: Enable support for Bluetooth.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/packages/pulseaudio.scm (pulseaudio)[arguments]: Add
>> "--enable-bluez5" to configure flags.
>> [inputs]: Add "bluez" and "sbc".
>
> I think it’s a reasonable change.
>
> Ideally a ‘pulseaudio-updates’ branch would be the right thing.
> However, if it builds and works as expected on master (at least make
> sure ‘guix gc --references’ shows bluez and SBC), then it’s OK to commit
> to ‘core-updates’ since it looks like a non-disruptive change.

I’ve just pushed it to core-updates.  Thanks!

~~ Ricardo