From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joey Hess Subject: Re: [PATCH] gnu: Add wmbattery Date: Fri, 13 May 2016 11:17:49 -0400 Message-ID: <20160513151749.GA21802@kitenet.net> References: <20160404170451.5e21f8f0@openmailbox.org> <20160513122507.127a7227@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1Eqx-0001OJ-Uv for guix-devel@gnu.org; Fri, 13 May 2016 11:18:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1Eqs-0005r5-Ob for guix-devel@gnu.org; Fri, 13 May 2016 11:18:10 -0400 Received: from kitenet.net ([66.228.36.95]:59586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1Eqr-0005oK-H3 for guix-devel@gnu.org; Fri, 13 May 2016 11:18:06 -0400 Content-Disposition: inline In-Reply-To: <20160513122507.127a7227@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic , Doug Torrance Cc: guix-devel@gnu.org --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I'm not maintaining wmbattery anymore. I've cced Doug, its new maintainer. Danny Milosavljevic wrote: > On Mon, 4 Apr 2016 17:04:51 -0400 > Kei Yamashita wrote: >=20 > > The source tarball comes from Debian.=20 >=20 > The wmbattery version that we use in Guix has a memory leak. It's b= een eating up all memory of my laptop for some time now, so I tracked it do= wn. >=20 > The fix would be: >=20 > diff -ur orig/dockapps-30b9edb/upower.c dockapps-30b9edb/upower.c > --- orig/dockapps-30b9edb/upower.c 2015-08-31 01:58:13.000000000 +0200 > +++ dockapps-30b9edb/upower.c 2016-05-12 07:21:27.550374114 +0200 > @@ -56,7 +56,8 @@ > =20 > int upower_supported(void) > { > - up =3D up_client_new(); > + if (!up) > + up =3D up_client_new(); > =20 > if (!up) { > return 0; > @@ -78,7 +79,8 @@ > GPtrArray *devices =3D NULL; > static int retries =3D 0; > =20 > - up =3D up_client_new(); > + if (!up) > + up =3D up_client_new(); > =20 > if (!up) > return -1; >=20 > I added Joey Hess, the author of the program, to Cc. >=20 > @Joey Hess: what do you think? --=20 see shy jo --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBVzXwHckQ2SIlEuPHAQJlmQ//X3xVUPyN0hrj4UPpD16LvNqJh2w5hxFX 7qWtWwWtmnQv8jPm72JHIJ7WulObKCuSg9oEZVEQ+C9+fMMnjtHJbofBn5oNcnjI 144zdNLFNS0U2ujmkmcayxW/Bpisih2R9hL368HVVGEu5gZS5AylIgPo2VIRBccj pMiFg4CWdLKiTPSLCSo0cM3ORkJpPzgDL5azCRvFzpeXuznhX/NxwAJfbzPmmHo8 zbkE03OZjKv+8A/Fb/FlxFQxEluXAWRF2wCJ4QTcZrvRQgf0XSPO10GeIWxnX8w6 sI+HYIqwNVG3WmlDNGMyQ//pGKK+x09SiLMIEBf1M3RDs4Itc59HyiHG1jOClnUg MEAlKC6fUVyqoxM9bMCC//Lb2mGluvgKQnbjsxkP7N/46cwofs2XRjk18iG7xeJM LGGaldl+5M+Ir8CBS5yasHpAKhdx5iCoUiT0pSoC3W6DCYEcFuo7GqLAwOKlem8a MNnd8hOY7/12M7A6PFIVUPIDrYzR2keadJA2P/61m5eUPtO5RtKI65LRzXtNZWP7 /O04QBo+EVemmDX+E8lCKcdEnC4krrFzHv8JtYpbeqdxDCHQm2SE7egoZ9j3TOz6 rk9W6Yvuy5nRGkC0BS7rYHCvXJaJsy5zuO3QRqAl6FRk6H2vnoZw5ox4HM1S6ZNw /TlFFkLIvgc= =VpN1 -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT--