From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/3] gnu: Add utfcpp.
Date: Sat, 7 May 2016 18:19:23 -0400
Message-ID: <20160507221923.GA16050@jasmine>
References: <1462646181.1130095.601018617.5F6ADC8F@webmail.messagingengine.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1azAZc-0002fZ-1w
	for guix-devel@gnu.org; Sat, 07 May 2016 18:19:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1azAZX-0003XN-Pu
	for guix-devel@gnu.org; Sat, 07 May 2016 18:19:42 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:32807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1azAZV-0003Wc-40
	for guix-devel@gnu.org; Sat, 07 May 2016 18:19:39 -0400
Content-Disposition: inline
In-Reply-To: <1462646181.1130095.601018617.5F6ADC8F@webmail.messagingengine.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org

On Sat, May 07, 2016 at 01:36:21PM -0500, Alex Griffin wrote:
> This is a dependency of ledger. It's bundled in ledger's source but I
> think it's better to unbundle it. It's a bit unusual in that the headers
> contain the whole source.

> * gnu/packages/unicode.scm: New file.

Not a bad idea for a new module, but I wonder if you considered any of
the existing modules? Are none of them appropriate?

> +(define-public utfcpp

I'm curious — are there any significant differences between this and the
bundled library?

> +              (uri
> +               (string-append "mirror://sourceforge/project/utfcpp/utf8cpp_2x/Release%20"
> +                              version "/utf8_v"
> +                              (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)
> +                              ".zip"))

Can you make sure these lines are < 80 characters?

Otherwise, LGTM!