Re: [PATCH] Connman

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 3939 bytes --]

On Tue, Apr 26, 2016 at 12:04:21AM +0200, Ludovic Courtès wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > I think I've finally gotten connman working, with a service. I haven't
> > added an entry to doc/guix.texi yet, and for some reason when I started
> > the patch I stuck it in wicd.scm. I've also attached the OS config I
> > used while testing.
> 
> Neat!
> 
> > From efe1f20ecb23fc4ba2da647152c9f2a2e96293be Mon Sep 17 00:00:00 2001
> > From: Efraim Flashner <efraim@flashner.co.il>
> > Date: Thu, 19 Apr 2016 17:25:41 +0200
> > Subject: [PATCH 1/2] gnu: Add connman.
> >
> > * gnu/packages/wicd.scm (connman): New variable.
> 
> I think it should go in some other file, possibly connman.scm—whatever
> you deem appropriate, but probably not wicd.scm.  :-)

agreed :)

> 
> > +(define-public connman
> > +  (package
> > +    (name "connman")
> > +    (version "1.32")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (string-append "https://www.kernel.org/pub/linux/network/connman/"
> 
> Use mirror://kernel.org/…
> 
> > +             (string-append
> > +              "--with-dbusconfdir=" (assoc-ref %outputs "out") "/etc")
> > +             (string-append
> > +              "--with-dbusdatadir=" (assoc-ref %outputs "out") "/share"))))
> 
> I suppose this populates $out/etc/dbus-1 and $out/share/dbus-1, which is
> where our D-Bus service looks for its XML thingies?

it turns out it is

> 
> > +    (synopsis "Connection Manager daemon")
> 
> “Connection management daemon”
> 
> > +    (description "The Linux Connection Manager project provides a daemon for
> 
> s/The Linux Connection Manager project/Connman/
> 
> > +managing Internet connections within embedded devices running the Linux
> > +operating system.
> 
> s/within … system//
> 
> > +    (license gpl2)))
> 
> v2-only?

I thought this was strange and I took another look at the website and
the code and it turns out it is gpl2 only.

> 
> > From 2e99131f5b455ceb7c70c33eb4c89134caa755bb Mon Sep 17 00:00:00 2001
> > From: Efraim Flashner <efraim@flashner.co.il>
> > Date: Thu, 19 Apr 2016 22:10:11 +0200
> > Subject: [PATCH 2/2] services: Add connman-service.
> >
> > * gnu/services/networking.scm (connman-service): New procedure.
> > (connman-service-type, %connman-activation): New variables.
> > (connman-shepherd-service): New procedure.
> 
> [...]
> 
> > +(define %connman-activation
> > +  ;; Activation gexp for Connman.
> > +  #~(begin
> > +      (use-modules (guix build utils))
> > +      (mkdir-p "/etc/connman/")
> 
> Is an empty /etc/connman really needed?

It turns out no. I left /var/lib/connman-vpn because although I didn't
write a service for the vpn, the directory would be needed.

> 
> > +(define* (connman-service #:key (connman connman))
> > +  "Return a service that runs Connman, a network connection manager.  This
> 
> s/Connman/@uref{http://…, Connman}/

@uref or @url? wicd uses @url

> 
> > +service adds the @var{connman} package to the global profile, providing
> > +several the @command{connmanctl} command to interact with the daemon and
> > +configure networking."
> 
> Could you add this documentation to guix.texi?

Much less scary than I thought it was going to be

> 
> Otherwise LGTM!
> 
> How does Connman compare to Wicd, and to NetworkManager?

Its hard for me to say, Debian is stuck with 1.22 from forever ago, but
from playing around it seems almost as featureful as Network Manager
while being out of the way like wicd, and has better integration into
enlightenment than either one.

> 
> Thank you!
> 
> Ludo’.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]