From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add Red Eclipse. Date: Tue, 3 May 2016 21:23:17 +0200 Message-ID: <20160503192317.GA5737@solar> References: <20160423022054.16f7aeb7@openmailbox.org> <571B21C8.3050100@gmx.net> <20160423074645.545cb512@openmailbox.org> <87eg9sd5zq.fsf@gmail.com> <20160502103837.GA4942@solar> <20160503121022.71dde468@openmailbox.org> <87bn4n9cxn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axfv9-0000ah-Ju for guix-devel@gnu.org; Tue, 03 May 2016 15:24:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axfux-0001or-Lr for guix-devel@gnu.org; Tue, 03 May 2016 15:23:42 -0400 Received: from mailrelay7.public.one.com ([91.198.169.215]:39551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axfuw-0001eo-7L for guix-devel@gnu.org; Tue, 03 May 2016 15:23:35 -0400 Content-Disposition: inline In-Reply-To: <87bn4n9cxn.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org On Tue, May 03, 2016 at 10:08:52PM +0300, Alex Kost wrote: > Only the package name is renamed here. I think it would be more > consistent to rename the variable as well. My apologies, indeed. I will push an additional patch. On Tue, May 03, 2016 at 10:09:40PM +0300, Alex Kost wrote: > Probably; you are the master of guidelines, so I trust your judge :-) > OTOH we also have such packages as 'accountsservice', 'recordmydesktop', > 'randomjungle', 'rubberband' and others. Should they also be renamed to > 'accounts-service', 'record-my-desktop', 'random-jungle', 'rubber-band', It depends; I just noticed for red-eclipse since you brought up the question. Now I just checked accountsservice: (uri (string-append "https://www.freedesktop.org/software/" name "/" name "-" version ".tar.xz")) (description "The AccountService project provides a set of D-Bus interfaces for querying It looks as if this should remain accountservice, since there is no space in the project name. The same holds for recordmydesktop. For randomjungle, the tarball does not contain a space, the description does; then it is up to us to make a decision on what the project name is. The tarball name is always fine. The same holds for rubber band. It might also be more awkward to modify names of packages that are already there for some time. Andreas