From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add thinkfan. Date: Sun, 1 May 2016 17:14:18 -0400 Message-ID: <20160501211418.GA10221@jasmine> References: <87mvoay9wo.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awyhW-0006SB-3n for guix-devel@gnu.org; Sun, 01 May 2016 17:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awyhK-0001eV-BY for guix-devel@gnu.org; Sun, 01 May 2016 17:14:44 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awyhH-0001bb-SS for guix-devel@gnu.org; Sun, 01 May 2016 17:14:38 -0400 Content-Disposition: inline In-Reply-To: <87mvoay9wo.fsf@saiph.selenimh> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Nicolas Goaziou Cc: guix-devel@gnu.org On Sun, May 01, 2016 at 01:05:59AM +0200, Nicolas Goaziou wrote: > * gnu/packages/linux.scm (thinkfan): New variable. Thanks! > + (arguments > + `(#:tests? #f ;no test target > + #:configure-flags > + `("-DUSE_ATASMART:BOOL=ON"))) Can you add a brief comment explaining this flag? Also, can you add a phase that installs the "rcscripts"? They will be useful for Guix users on foreign distros. I'm not sure where to install them. Since they will probably have to be copied or symlinked out of ~/.guix-profile anyways, how about installing them into 'share/misc'? I'm open to better ideas! > + (synopsis "Simple fan control program") Is it specific to ThinkPads? If so, can you change the synopsis to "Simple fan control program for ThinkPads" and mention the limitation in the description?