unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v3] gnu: Add python2-shedskin.
Date: Sun, 1 May 2016 13:52:02 -0400	[thread overview]
Message-ID: <20160501175202.GA26317@jasmine> (raw)
In-Reply-To: <20160425040459.0fe60975@scratchpost.org>

On Mon, Apr 25, 2016 at 04:04:59AM +0200, Danny Milosavljevic wrote:
> > My instinct is that we should make it refer directly to the libraries
> > (pcre and libgc) but that user-facing executables like make and g++
> > should be installed by the user.
> 
> Yeah, I did it like that in the existing patch.

Sorry I took soooo long to read v4 of your patch! :/

I've shifted the indentation of arguments down one line and to the left,
to keep the lines shorter than 80 characters. Same for the description.

Applied as 63bcec7140.

      reply	other threads:[~2016-05-01 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 22:27 [PATCH] gnu: Add python2-shedskin Danny Milosavljevic
2016-03-29 22:49 ` Danny Milosavljevic
2016-03-30  5:26   ` [PATCH v2] " Danny Milosavljevic
2016-04-06 22:19     ` Leo Famulari
2016-04-07 12:13       ` [PATCH v3] " Danny Milosavljevic
2016-04-07 12:28         ` [PATCH v4] " Danny Milosavljevic
2016-04-07 15:16         ` [PATCH v3] " Leo Famulari
2016-04-25  2:04           ` Danny Milosavljevic
2016-05-01 17:52             ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160501175202.GA26317@jasmine \
    --to=leo@famulari.name \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).